[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #29 from Maik Qualmann  ---
The problem with this image is, all GPS data is invalid. Also for the altitude
the denominator is 0. If there is no valid value, the record is ignored and not
written to the database. The old problem, that the database will not be
overwriten if the information is not included in the image.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #28 from Nicofo  ---
Great, thanks for your reactivity !

Strange that reloading the metadata will not help because it worked for my
other pictures in NorthPole and your code modification is related to the same
functions (getGPSLatitudeNumber, ...)
Well I will see with next version of DK.
Thanks again :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #27 from Maik Qualmann  ---
Unfortunately, reloading the metadata does not help here to correct the values
in the database. For this, the bug 380876 must first be closed.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/dig |https://commits.kde.org/dig
   |ikam/67b348d8a86d53cc754e16 |ikam/871e904bb00ae53d3ad60f
   |394160c81f78531bc8  |0b247200df8d35c606
 Status|UNCONFIRMED |RESOLVED

--- Comment #26 from Maik Qualmann  ---
Git commit 871e904bb00ae53d3ad60f0b247200df8d35c606 by Maik Qualmann.
Committed on 29/12/2017 at 11:25.
Pushed by mqualmann into branch 'master'.

check denominators from the latitude and longitude if invalid
FIXED-IN: 5.8.0

M  +4-4libs/dmetadata/metaengine_gps.cpp

https://commits.kde.org/digikam/871e904bb00ae53d3ad60f0b247200df8d35c606

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=326406

Nicofo  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #25 from Nicofo  ---
Hello Maik,

thanks for the correction, I have tested the new appimage of Digikam
(digikam-5.8.0-20171227T061903-x86-64): it works well with the pictures I sent
you !

However there is a regression with some other pictures (from another camera)
that do not contain valid GPS data:

with DK 5.7 no problem (not geolocalised)
with DK 5.8, when I refresh the metadata, the picture is now geolocalised
in Equator :(

I sent you by mail an example of such picture.
GPS data is:
GPS Altitude (0/0)
GPD Latitude (0/0 0/0 0/0)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #24 from Maik Qualmann  ---
Thanks for the test images.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

Maik Qualmann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.8.0
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dig
   ||ikam/67b348d8a86d53cc754e16
   ||394160c81f78531bc8

--- Comment #23 from Maik Qualmann  ---
Git commit 67b348d8a86d53cc754e16394160c81f78531bc8 by Maik Qualmann.
Committed on 26/12/2017 at 17:24.
Pushed by mqualmann into branch 'master'.

fix map view from the right sidebar if image has only altitude and no
coordinates
FIXED-IN: 5.8.0

M  +2-1NEWS
M  +1-1libs/imageproperties/imagepropertiessidebardb.cpp

https://commits.kde.org/digikam/67b348d8a86d53cc754e16394160c81f78531bc8

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #22 from Maik Qualmann  ---
A new reading of the metadata of the wrong images is necessary. Can you send me
the last image as an email to test?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #21 from Maik Qualmann  ---
Git commit 88d97268df820436d23554607df0f4484693f6d2 by Maik Qualmann.
Committed on 26/12/2017 at 12:12.
Pushed by mqualmann into branch 'master'.

check valid range for longitude and latitude

M  +10   -0libs/dmetadata/metaengine_gps.cpp

https://commits.kde.org/digikam/88d97268df820436d23554607df0f4484693f6d2

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=326406

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #20 from Maik Qualmann  ---
Is the latitude or longitude outside the valid range as in your sample image?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #19 from Nicofo  ---
Created attachment 109526
  --> https://bugs.kde.org/attachment.cgi?id=109526=edit
Comparaison DK5.7 and  DK pre5.8

For information, comparaison DK 5.7 and pre 5.8 (12/12/2017)
Still problem also with pictures i North Pole

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #18 from Nicofo  ---
There is a little improvement with DK 5.8 (pre version 12/12/2017).

With DK 5.7, when GPS is not active with my camera, the picture:
 (1) had an indication 'geolocalised' (little map in the top-tight corner of
the thumbnail)
 (2) appeared in Equator in the Map ('Map' button on the right panel)
 (3) appeared in Equator in the Map ('Map' view in the top panel, between
'Preview' and 'Table')

Now with DK pre-5.8:
 (1) OK  no more 'geolocalised' icon
 (2)NOK  still appears in Equator in the Map ('Map' button on the right panel)
 (3) OK  does not appear in Equator in the Map ('Map' view in the top panel,
between 'Preview' and 'Table')

See attachment: the result is not consistent: on one side the picture is not
geolocalised (no top-right icon), but on the other hand the picture appears on
the map. But as said above, it appears only in (2), not in (3): very strange
...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo]

https://bugs.kde.org/show_bug.cgi?id=326406

--- Comment #17 from Nicofo  ---
Created attachment 109525
  --> https://bugs.kde.org/attachment.cgi?id=109525=edit
DK pre5.8 picture with no GPS

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326406

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Metadata-Engine |Metadata-Gps

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 326406] A picture without geolocalisation is localized in North Pole

[Nicofo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=326406

Nicofo  changed:

   What|Removed |Added

Version|4.10.0  |4.14.0

--- Comment #16 from Nicofo  ---
Hi Gilles,

what do you think about my previous suggestion ?

IF tag "GPS Latitude" or "GPS Longitude" is not present
OR   tag is present but out of range (latitute [0-90] North/South ;
longitude [-180 -180])
THEN  photo not geolocalised

Seems easy to implement ? (for a non-developper at least ;) )
Any chance to see that in Digikam 5.0 ?

-- 
You are receiving this mail because:
You are watching all bug changes.