[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 swatilodh...@gmail.com changed: What|Removed |Added Latest Commit||http://commits.kde.org/digi ||kam/868520574949d0f0febdc44 ||44875809360ad5626 Resolution|--- |FIXED Version Fixed In||5.1.0 Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #22 from swatilodh...@gmail.com --- Thanks a lot Maik for testing. I'll apply the patch and close this entry. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #21 from Maik Qualmann --- Yes, the patch works. With this patch, an image is again visible in the album when the image information is missing. After rereading metadata from the image are the image information also available again. I have so far found no negative side effects. We have before release from DigiKam-5.1.0 time to test. Swati, apply the patch. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com --- Comment #20 from Maik Qualmann --- Swati, I look to this problem and the patch tomorrow. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #19 from caulier.gil...@gmail.com --- I cannot test for the moment as i'm not at home. Ask to Maik if he can test. Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #18 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #17) > In your new patch xml file is untouched, only cpp files. It's wanted ? Yes, 'cause that cpp file decides the images to be displayed in the UI. So, JOIN must be changed here. Does it works well for you too? -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #17 from caulier.gil...@gmail.com --- In your new patch xml file is untouched, only cpp files. It's wanted ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #16 from caulier.gil...@gmail.com --- In your new patch xml file is untouched. It's the w -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #15 from swatilodh...@gmail.com --- Created attachment 100335 --> https://bugs.kde.org/attachment.cgi?id=100335&action=edit Updated patch Okay, I did realize after some testing that I made some unwanted changes in the XML schema file which weren't required. Please take a look at the updated patch, and let me know if it's good enough! Thank you. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 swatilodh...@gmail.com changed: What|Removed |Added Attachment #100320|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #14 from caulier.gil...@gmail.com --- Well, if the schema of tables are untouched no, and it sound the case. Only the way to handle data from table with SQL action are touched. But the revision of XML file need to be increased of course. Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #13 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #12) > By intrusive, i want mean it touch code in different place. > > As sqlite code in XML file is touched, the sqlite schema ID need to be > updated ? No schema updater need to be written ? Do you think it should be updated? Since it is only a fix for a issue? -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #12 from caulier.gil...@gmail.com --- By intrusive, i want mean it touch code in different place. As sqlite code in XML file is touched, the sqlite schema ID need to be updated ? No schema updater need to be written ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #11 from swatilodh...@gmail.com --- (In reply to caulier.gilles from comment #9) > Swati, > > In your patch, did you touch the sqlite schema or only mysql one ? I've changed the queries for both MySQL and SQLite in XML schema file, and of course the common queries for both in source code. > The patch is a little bit intrusive. Could you please tell me which part? Do you test this patch to see if side > effects are introduced in general digiKam use cases ? As far as I did, it worked fine for me! -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #10 from caulier.gil...@gmail.com --- Richard, This patch from Swati sound acceptable for you ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database [patch]
https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added Summary|MYSQL : Images not show if |MYSQL : Images not show if |corresponding |corresponding |ImageInformation entry does |ImageInformation entry does |not exist in database |not exist in database ||[patch] --- Comment #9 from caulier.gil...@gmail.com --- Swati, In your patch, did you touch the sqlite schema or only mysql one ? The patch is a little bit intrusive. Do you test this patch to see if side effects are introduced in general digiKam use cases ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #8 from swatilodh...@gmail.com --- Created attachment 100320 --> https://bugs.kde.org/attachment.cgi?id=100320&action=edit Patch to fix this issue. I've changed INNER JOIN to LEFT JOIN at several places in the source code to ensure that images are visible in UI, even if entry is removed from Image Information table. Please test and provide feedback. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #7 from swatilodh...@gmail.com --- MySQL and SQLite return the same results. Both do not show images if the entry for that image id is removed from Image Information table. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #6 from Richard Mortimer --- Sorry. Had missed this one. I cannot see an obvious reason why there would be a difference between SQLite and MySQL. It should be easy to test the queries from the commandline in both database types to see if they really do return different results. The only possible theory that springs to mind would be related to the fact that in getItemURLsInAlbumByItemDate and getItemURLsInAlbumByItemRating the ImageInformation.rating order by field is not included in the selected columns. I know that some databases (PostgresQL for instance) are very strict about that but MySQL and SQLite tend to be much looser in enforcing that type of SQL behaviour. Whatever of the cause I would certainly be in favour of Swati's suggestion of using a LEFT JOIN instead of an INNER JOIN in the 5 queries that are referencing ImageInformation within them. Of course the calling code would need auditing to ensure that it could cope with those fields having null values if the ImageInformation row is not present. -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #5 from caulier.gil...@gmail.com --- Richard, Do you see my previous comment ? Thanks in advance Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added CC||richm+...@oldelvet.org.uk --- Comment #4 from caulier.gil...@gmail.com --- Good question. Why it must be different between Mysql ans SQlite for a common statement in database ? Richard, your expertise here will be welcome. Thanks in advance. Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 --- Comment #3 from swatilodh...@gmail.com --- Using "LEFT JOIN" instead of "INNER JOIN" in the SQL queries involving Images and ImageInformation tables, would be useful here? -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 caulier.gil...@gmail.com changed: What|Removed |Added Version|4.3.0 |5.0.0 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 339607] MYSQL : Images not show if corresponding ImageInformation entry does not exist in database
https://bugs.kde.org/show_bug.cgi?id=339607 swatilodh...@gmail.com changed: What|Removed |Added CC||swatilodh...@gmail.com --- Comment #2 from swatilodh...@gmail.com --- (Used digikam version 5.0.0-beta6) I'm able to reproduce this error using MySQL Server. image is view-able using SQLite. -- You are receiving this mail because: You are watching all bug changes.
