[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #10 from Omar Amin  ---
Created attachment 98456
  --> https://bugs.kde.org/attachment.cgi?id=98456=edit
Screenshot of the new grouped images border

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #9 from Omar Amin  ---
Created attachment 98455
  --> https://bugs.kde.org/attachment.cgi?id=98455=edit
Group border modification patch

This patch is for grouped images border new background

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #8 from caulier.gil...@gmail.com ---
while next week, this will be fine

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Omar Amin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #7 from Omar Amin  ---
Hi Mr Gilles,


I'll look into it during this week, and will finish it by next Friday, Please
let me know if you need it finished earlier.

Regards,
Omar

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Mohamed via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

Mohamed  changed:

   What|Removed |Added

 CC||omar.moh.a...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||mohammed.ahmed.anwer@gmail.
   ||com

--- Comment #6 from caulier.gil...@gmail.com ---
Hi Mohamed and Omar,

I identify better where the code must be patched exactly :

https://quickgit.kde.org/?p=digikam.git=blob=35b917742c0a0eee08c453f0235190c87404b403=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e=libs%2Fwidgets%2Fitemview%2Fitemviewimagedelegate.cpp

In this implementation, the method ItemViewImageDelegate::drawThumbnail() from
the icon-view model is used by view class to draw the border over the
thumbnail.

The border pixmap is get through the call.

QPixmap borderPix = thumbnailBorderPixmap(actualPixmapRect.size());

This model class don't know if it's a grouped item or not. The view class know
this property. For ex, to draw the grouped icon, we call from view class the
method in the model  : ItemViewImageDelegate::drawGroupIndicator().

So i propose:

1/ to pass as argument a new bool value to
ItemViewImageDelegate::drawThumbnail() to indicate the grouped properties. This
properties will be get in view class (see how
ItemViewImageDelegate::drawGroupIndicator() is called).

2/ To implement relevant code in ItemViewImageDelegate::drawThumbnail() to draw
grouped frame over the current border pixmap. I'm not sure if additional
rotated border as proposed in this entry will be the best visual solution.
Experimentation is welcome.

Gilles Caulier

-

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Jens B . Benecke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #3 from Jens B. Benecke  ---
Thank you! :-)

I'd be happy to create a border / backdrop for grouped images, I'll be happy to
do it - just tell me what formats you need (probably SVG to zoom it, or are you
going to draw it in software?).

IMHO: The colored background for expanded groups should be very slight and
adhere to the theme that is currently set in KDE.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #2 from caulier.gil...@gmail.com ---
This idea is EXCELENT. I search a lots a visual solution to show grouped
images. The current icon was the only way to do it, and i agree that usability
is not very good.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[Jens B . Benecke via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #1 from Jens B. Benecke  ---
Created attachment 98114
  --> https://bugs.kde.org/attachment.cgi?id=98114=edit
mockup to better recognize groups of images

-- 
You are receiving this mail because:
You are watching all bug changes.