[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.6.0
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/dig
   ||ikam/4ed5f88f787329a29273bb
   ||b2fb2fe80714bc735d

--- Comment #60 from Simon  ---
Git commit 4ed5f88f787329a29273bbb2fb2fe80714bc735d by Simon Frei.
Committed on 12/05/2017 at 22:47.
Pushed by sfrei into branch 'master'.

Handle grouped images based on what operation is to be done
Related: bug 286609, bug 378552, bug 377632
FIXED-IN: 5.6.0

M  +4-1NEWS
M  +8-233  app/items/digikamimageview.cpp
M  +7-18   app/items/digikamimageview.h
M  +68   -11   app/items/imagecategorizedview.cpp
M  +12   -5app/items/imagecategorizedview.h
M  +6-6app/main/digikamapp.cpp
M  +2-2app/utils/contextmenuhelper.cpp
M  +341  -80   app/views/digikamview.cpp
M  +63   -13   app/views/digikamview.h
M  +93   -235  app/views/tableview/tableview.cpp
M  +31   -30   app/views/tableview/tableview.h
M  +14   -18   app/views/tableview/tableview_model.cpp
M  +2-0app/views/tableview/tableview_model.h
M  +5-122  libs/database/coredb/coredb.cpp
M  +1-12   libs/database/coredb/coredb.h
M  +106  -50   libs/database/utils/dbinfoiface.cpp
M  +9-2libs/database/utils/dbinfoiface.h
M  +39   -6libs/database/utils/dio.cpp
M  +4-0libs/database/utils/dio_p.h
M  +9-0libs/dmetadata/metadatasettingscontainer.cpp
M  +3-1libs/dmetadata/metadatasettingscontainer.h
M  +1-1libs/models/imagefiltermodel.cpp
M  +26   -5libs/settings/applicationsettings.cpp
M  +74   -2libs/settings/applicationsettings.h
M  +0-5libs/settings/applicationsettings_mime.cpp
M  +122  -0libs/settings/applicationsettings_miscs.cpp
M  +31   -2libs/settings/applicationsettings_p.cpp
M  +208  -196  libs/settings/applicationsettings_p.h
M  +1-1utilities/assistants/common/dimageslist.cpp
M  +0-5utilities/assistants/common/dinfointerface.cpp
M  +2-3utilities/assistants/common/dinfointerface.h
M  +4-1utilities/assistants/htmlgallery/wizard/htmlselectionpage.cpp
M  +12   -106  utilities/kdesupport/kipi/kipiimagecollection.cpp
M  +1-0utilities/setup/CMakeLists.txt
M  +10   -10   utilities/setup/album/setupmime.cpp
M  +116  -40   utilities/setup/metadata/setupmetadata.cpp
M  +1-0utilities/setup/metadata/setupmetadata.h
M  +8-6utilities/setup/setupdatabase.cpp
M  +137  -39   utilities/setup/setupmisc.cpp
M  +13   -0utilities/setup/setupmisc.h
A  +53   -0utilities/setup/setuputils.cpp [License: BSD]
A  +37   -0utilities/setup/setuputils.h [License: BSD]

https://commits.kde.org/digikam/4ed5f88f787329a29273bbb2fb2fe80714bc735d

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #59 from caulier.gil...@gmail.com ---
Simon,

I tested too on my computer. No side effect and all run as expected as i can
see...

Good work. I think all is fine to commit now.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #58 from Simon  ---
Created attachment 105489
  --> https://bugs.kde.org/attachment.cgi?id=105489=edit
Adjust kipi-plugins for grouping

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #105453|0   |1
is obsolete||
 Attachment #105454|0   |1
is obsolete||

--- Comment #57 from Simon  ---
Created attachment 105488
  --> https://bugs.kde.org/attachment.cgi?id=105488=edit
Customize grouping behavior patch version 13

So I did not follow through with my earlier statement and did patch
kipi-plugins. I reduced the number of ImageCollection instances created and
removed redundant calls to loadImagesFromCurrentSelection(). Before these were
merely inefficient, with this new grouping dialog these calls were disruptive.
Now everything runs smoothly (I hope I caught all plugins, I must admit I
didn't actually try all of them).

The html gallery does work with grouping as well now (part of "Tools"). I also
added the grouping functionality when the album selector is used for
consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #56 from Simon  ---
Created attachment 105454
  --> https://bugs.kde.org/attachment.cgi?id=105454=edit
Customize grouping behavior patch version 12

These changes somehow went missing patch 11, 12 should compile again (doesn't
contain anything new of notice yet).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #105446|0   |1
is obsolete||

--- Comment #55 from caulier.gil...@gmail.com ---
Created attachment 105453
  --> https://bugs.kde.org/attachment.cgi?id=105453=edit
Customize grouping behavior patch version 12

This one must compile fine...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #54 from Maik Qualmann  ---
Gilles,

The patch can not compile, the imagecategorizedview.h is not patched.

maik@linux-tpgn:~ gcc --version
gcc (SUSE Linux) 6.3.1 20170202 [gcc-6-branch revision 245119]

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #53 from caulier.gil...@gmail.com ---
This error can be generated by a different GC version than one, and of course
by different compilation options passed by KDE::ECM modules. Here we don't
manage anything.

The best way to hack is to check compilation trace with "export VERBOSE=1"

Mine :

[gilles@localhost core]$ gcc --version
gcc (GCC) 5.4.0

[ 85%] Building CXX object
core/app/CMakeFiles/digikamgui_src.dir/items/imagecategorizedview.cpp.o
cd /home/gilles/Devel/5.x/build/core/app && /bin/c++   -DLIBPGF_DISABLE_OPENMP
-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII
-DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING
-DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER
-DTRANSLATION_DOMAIN=\"digikam\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE
-I/home/gilles/Devel/5.x/build/core/app -I/home/gilles/Devel/5.x/core/app
-I/home/gilles/Devel/5.x/core/app/date
-I/home/gilles/Devel/5.x/core/app/dragdrop
-I/home/gilles/Devel/5.x/core/app/filters
-I/home/gilles/Devel/5.x/core/app/items
-I/home/gilles/Devel/5.x/core/app/items/overlays
-I/home/gilles/Devel/5.x/core/app/main -I/home/gilles/Devel/5.x/core/app/utils
-I/home/gilles/Devel/5.x/core/app/views
-I/home/gilles/Devel/5.x/core/app/views/tableview
-I/home/gilles/Devel/5.x/core/libs/album
-I/home/gilles/Devel/5.x/core/libs/database/collection
-I/home/gilles/Devel/5.x/core/libs/database/coredb
-I/home/gilles/Devel/5.x/core/libs/database/dbjobs
-I/home/gilles/Devel/5.x/core/libs/database/engine
-I/home/gilles/Devel/5.x/core/libs/database/haar
-I/home/gilles/Devel/5.x/core/libs/database/imagehistory
-I/home/gilles/Devel/5.x/core/libs/database/imgqsort
-I/home/gilles/Devel/5.x/core/libs/database/item
-I/home/gilles/Devel/5.x/core/libs/database/server
-I/home/gilles/Devel/5.x/core/libs/database/tags
-I/home/gilles/Devel/5.x/core/libs/database/thumbsdb
-I/home/gilles/Devel/5.x/core/libs/database/utils
-I/home/gilles/Devel/5.x/core/libs/dialogs
-I/home/gilles/Devel/5.x/core/libs/dimg
-I/home/gilles/Devel/5.x/core/libs/dimg/dklcms
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/auto
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/bcg
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/bw
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/cb
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/curves
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/decorate
-I/home/gilles/Devel/5.x/core/libs/dimg/filters
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/film
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/fx
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration/cimg
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/hsl
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/icc
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/lc
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/lens
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/levels
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/nr
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/redeye
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/sharp
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/transform
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/wb
-I/home/gilles/Devel/5.x/core/libs/dimg/imagehistory
-I/home/gilles/Devel/5.x/core/libs/dimg/loaders
-I/home/gilles/Devel/5.x/core/libs/dmetadata
-I/home/gilles/Devel/5.x/core/libs/dngwriter
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/md5
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/xmp_sdk/include
-I/home/gilles/Devel/5.x/core/libs/dtrash
-I/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing
-I/home/gilles/Devel/5.x/core/libs/facesengine/alignment-flandmark
-I/home/gilles/Devel/5.x/core/libs/facesengine
-I/home/gilles/Devel/5.x/core/libs/facesengine/detection
-I/home/gilles/Devel/5.x/core/libs/facesengine/facedb
-I/home/gilles/Devel/5.x/core/libs/facesengine/preprocessing-tantriggs
-I/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-lbph
-I/home/gilles/Devel/5.x/core/libs/facesengine/shape-predictor
-I/home/gilles/Devel/5.x/core/libs/fileactionmanager
-I/home/gilles/Devel/5.x/core/libs/filters
-I/home/gilles/Devel/5.x/core/libs/imageproperties
-I/home/gilles/Devel/5.x/core/libs/iojobs
-I/home/gilles/Devel/5.x/core/libs/jpegutils
-I/home/gilles/Devel/5.x/core/libs/kmemoryinfo
-I/home/gilles/Devel/5.x/core/libs/models
-I/home/gilles/Devel/5.x/core/libs/notificationmanager
-I/home/gilles/Devel/5.x/core/libs/pgfutils
-I/home/gilles/Devel/5.x/core/libs/progressmanager
-I/home/gilles/Devel/5.x/core/libs/rawengine
-I/home/gilles/Devel/5.x/core/libs/rawengine/libraw/internal
-I/home/gilles/Devel/5.x/core/libs/rawengine/libraw/libraw
-I/home/gilles/Devel/5.x/core/libs/settings
-I/home/gilles/Devel/5.x/core/libs/tags
-I/home/gilles/Devel/5.x/core/libs/tags/tagsmanager/models
-I/home/gilles/Devel/5.x/core/libs/tags/tagsmanager

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #52 from Maik Qualmann  ---
I have a compiler error here, but will check again, since Gilles has already
tested it already.

Maik

/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void
Digikam::DigikamImageView::deleteSelected(Digikam::ImageViewUtilities::DeleteMode)’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:384:58:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool)’
 ImageInfoList imageInfoList = selectedImageInfos(true);
  ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList
Digikam::ImageCategorizedView::selectedImageInfos() const
 ImageInfoList  selectedImageInfos() const;
^~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void
Digikam::DigikamImageView::deleteSelectedDirectly(Digikam::ImageViewUtilities::DeleteMode)’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:394:58:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool)’
 ImageInfoList imageInfoList = selectedImageInfos(true);
  ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList
Digikam::ImageCategorizedView::selectedImageInfos() const
 ImageInfoList  selectedImageInfos() const;
^~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void Digikam::DigikamImageView::rename()’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:431:67:
error: ‘needGroupResolving’ was not declared in this scope
 bool grouping = needGroupResolving(ApplicationSettings::Rename);
   ^
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:432:46:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedUrls(bool&)’
 QList  urls = selectedUrls(grouping);
  ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:81:28:
note: candidate: QList Digikam::ImageCategorizedView::selectedUrls()
const
 QListselectedUrls()   const;
^~~~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:81:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:444:63:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool&)’
 QUrl nextUrl =
nextInOrder(selectedImageInfos(grouping).last(),1).fileUrl();
   ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #51 from caulier.gil...@gmail.com ---
I tested with patch v11 and HTMLExport and i do not see any difference while
processing items. No time latency or something like that.

My grouped album to test :

https://www.flickr.com/photos/digikam/34596906595/in/dateposted-public/

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #105330|0   |1
is obsolete||
 Attachment #105389|0   |1
is obsolete||

--- Comment #50 from caulier.gil...@gmail.com ---
Created attachment 105446
  --> https://bugs.kde.org/attachment.cgi?id=105446=edit
Customize grouping behavior patch version 11

New version of patch compilable against git/master

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #49 from caulier.gil...@gmail.com ---
The patch V10 cannot not be applied it against git/master. New version is ready
on my computer. I will post it in few minutes...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #48 from Simon  ---
Yes, the deduplicate patch is integrated in the grouping patch. I just thought
that splitting the change into meaningful pieces makes it more readable (but
that's not really the case with patches, more with commits...) and maybe it
could be merged faster.

I will rename the kipi setting then.

About the panorama tool: That is already working with grouping in the current
patch.
I have a working solution for the html tool (it had the same problem as the
kipi tool with multiple dialogs), but I want to extend it. And I may be able to
fix this problem for the kipi plugins as well. So I will post an updated patch,
hopefully soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #47 from caulier.gil...@gmail.com ---
Simon, patch 9 must be obsolete no ?

What's about Deduplicate code patch ? It's not integrated in patch 10 ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #46 from caulier.gil...@gmail.com ---
I do not see why it's called more than one time with KIPI plugins.

I see your screenshot of setup panel. I like the new settings. It's clear.

Just a remark : "kipi plugins" => "plugins" : since there is no more image
editor plugins, only KIPI provide digiKam plugins. So no need to name KIPI...,
just plugins is enough.

I try your patch now...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #45 from Simon  ---
Gilles,

This is all done already. DigikamView::selectedUrls() accepts an (optional)
argument (either bool or ApplicationSettings::OperationType) to include grouped
items or not.

The change I proposed is working. The problem is just that it is called several
times when opening a kipi plugin, so the dialog asking the user whether to
include grouped items or not appears several times. This is a problem of kipi
plugins calling KIPI::Interface::currentSelection() several times on opening,
each time triggering DigikamView::selectedUrls(Applicationsettings::Kipi) and
opening a dialog about grouping.

I will look at HTMLGallery and panorama tools to support grouping for them as
well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #44 from caulier.gil...@gmail.com ---
Simon, 

Look this report :

https://bugs.kde.org/show_bug.cgi?id=286609

Panorama tool do not support grouped items behavior. Look how it's called from
DigikamApp::line 2621. It use also DigikamView::selectedUrls()...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #43 from caulier.gil...@gmail.com ---
Ah i forget to said that Digikamview::allUrls() must be patch to return also
the grouped items list depending of digiKam settings.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #42 from caulier.gil...@gmail.com ---
>The only change needed should be in line 190 of kipiimagecollection.cpp:
>return DigikamApp::instance()->view()->selectedUrls();
>to
>return 
> DigikamApp::instance()->view()->selectedUrls(ApplicationSettings::Kipi);

==> no. the only change is to patch DigikamView::selectedUrls() method to
return all grouped item depending of the application settings.

If you don't want to test with KIPI, i write a new application interface helper
to port batch tools from KIPI to digiKam core (yes, at least in the future only
export to web service tools will be hosted to KIPI. That all).

This new interface template is located in
core/utilities/assistants/common/dinfointerface.cpp. This is nothing to do here
are implementation is done with empty methods. The real implementation for
digiKam database is in core/libs/database/utils/dbinfoiface.cpp.

This implementation is mostly some code backport from kipi interface. I plan to
factorize this one with the Database info interface, later when implementation
will be finalized.

Currently HTMLGallery tool use this interface. When you start this tool, it can
use the image selection from icon view (look the option in intro page). If you
select some grouped items, only the first one of each groups is used instead
all items grouped (depending of grouped icon view option of course).

If you look on dbinfoiface.cpp::line 207, it call DigikamView::selectedUrls(),
which must return the right selection if grouped items are selected and
depending of icon view grouped options.

So, the patch to support grouped items from icon view must be done somewhere in
DigikamView::selectedUrls(). That all. all the rest (kipi included) will work
as expected.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #41 from Simon  ---
That was too good to be true. The only change needed should be in line 190 of
kipiimagecollection.cpp:

return DigikamApp::instance()->view()->selectedUrls();

to

return
DigikamApp::instance()->view()->selectedUrls(ApplicationSettings::Kipi);

However the problem is, that the kipi plugins (at least dropbox and facebook)
call this function several times, so the dialog pop ups multiple times. That's
a very bad user experience. I had a quick look at it and it seems to construct
the KipiImageCollection several times. I don't know that part at all (and don't
use kipi), so I am not overly motivated to read all this code to debug this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #40 from caulier.gil...@gmail.com ---
Simon,

The items selcted from icon view is passed to a plugin through the KIPI
interface. All is located in
core/utilities/kdesupport/kipi/kipiimagecollection.cpp. Look in function
images(), and especially line 188 which pass the selected items to the
interface as a list of URL. You nee to code something to take a care about the
grouped images in the current selection from icon view.

So the patch relevant must be located in DigikamView class.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #39 from Maik Qualmann  ---
Ok, I also see no code for the kipi-Plugins in the patch, except for the
configuration. Simon, I would suggest setting the default for Kipi plugins to
NO and disable for selection this line. Or hide the line. And apply the patch.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #38 from Simon  ---
I just had a look and couldn't even figure out how the selection makes it to
the kipi plugins. Apparently I just added the Kipi member to the enum as I
considered it relevant and then never followed through actually implementing
it. If you can give me a pointer for how this currently works, I might be able
to work around this limitation, otherwise I will remove kipi from this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #37 from caulier.gil...@gmail.com ---
Maik,

No objection from me. I just follow the file only and let's you to test Simon
patches.

Note : kipi interface do not support yet grouped items. If i remember, there is
a generic file in bugzilla about this topic.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #36 from Maik Qualmann  ---
Ignore the thing with the empty text line, I have not seen right. But the other
thing does not work.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #35 from Maik Qualmann  ---
Created attachment 105393
  --> https://bugs.kde.org/attachment.cgi?id=105393=edit
grouping.png

As I said, I think it would not be necessary if Gilles did not mind, I would
also agree. But see screenshot, the first line has no text. Everything stands
on ask, but the kipi-Plugins take only the first image of the group, no dialog.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #34 from Simon  ---
Created attachment 105389
  --> https://bugs.kde.org/attachment.cgi?id=105389=edit
Customize grouping behavior patch version 10

Version 10 fixes compiler warnings.

There was no more problems reported, the refactoring has been met positively
and I need it to do further improvements - so unless there is opposition, I
will push the non-grouping related changes (104828) to master soon.

Regarding the grouping and whether to have separate options for different
operations or just one option: Can you reply to my earlier statement explaining
why I think it is worth having separate options please.
Even if the answer is, that you still want the simpler version, that is better
than just letting this hang around. I will be disappointed (and run the full
version locally, as I already got used to it), but one option to control all is
still better than no option.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #105016|0   |1
is obsolete||

--- Comment #33 from Simon  ---
Created attachment 105330
  --> https://bugs.kde.org/attachment.cgi?id=105330=edit
Customize grouping behavior patch version 9

I updated this with information about the operation in the dialog, streamlined
the setup page creation and added some documentation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #32 from Simon  ---
Originally the request originated around tagging. After the change users
started complaining mostly about slideshow and lighttable. And for my personal
workflow it absolutely makes sense to do operations like moving and tagging
images together. However with slideshow and lighttable, it doesn't really. For
bqm it depends on what you want to do.
What I took out of all the responses is, that there is a multitude of different
workflows and I will never be able to think of each and every one. That's why I
tried to make it as customizable as possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=377197

Mario Frank  changed:

   What|Removed |Added

 CC||mario.fr...@uni-potsdam.de

--- Comment #31 from Mario Frank  ---
(In reply to Maik Qualmann from comment #30)
> I have not found any problems with the V8 patch. But I think we do not need
> to distinguish between BQM, light table, renaming, etc. An option for all
> cases (yes, no, ask) should be enough. Gilles, Mario what is your point of
> view?
> 
> Maik

I agree. Keep it simple if there is no really good reason. And I currently see
none.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #30 from Maik Qualmann  ---
I have not found any problems with the V8 patch. But I think we do not need to
distinguish between BQM, light table, renaming, etc. An option for all cases
(yes, no, ask) should be enough. Gilles, Mario what is your point of view?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104827|0   |1
is obsolete||

--- Comment #29 from Simon  ---
Created attachment 105016
  --> https://bugs.kde.org/attachment.cgi?id=105016=edit
Customize grouping behavior patch version 8

I would like to get this done, as there were some reports from users who had
problems with the "new" grouping behaviour. Also some other things I wanted to
fix depend partially on this.

Can I commit the refactor part (@Maik)?

The grouping part probably needs more attention.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104714|0   |1
is obsolete||

--- Comment #28 from Simon  ---
Created attachment 104828
  --> https://bugs.kde.org/attachment.cgi?id=104828=edit
Deduplicate code between icon and table view (V6)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104716|0   |1
is obsolete||

--- Comment #27 from Simon  ---
Created attachment 104827
  --> https://bugs.kde.org/attachment.cgi?id=104827=edit
Customize grouping behavior patch version 7

Update to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104641|0   |1
is obsolete||

--- Comment #26 from Simon  ---
Created attachment 104716
  --> https://bugs.kde.org/attachment.cgi?id=104716=edit
Customize grouping behavior patch version 6

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104675|0   |1
is obsolete||

--- Comment #25 from Simon  ---
Created attachment 104714
  --> https://bugs.kde.org/attachment.cgi?id=104714=edit
Deduplicate code between icon and table view (V5)

Fixed moving to album - thanks Maik!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #24 from Maik Qualmann  ---
Simon,

"Move To Album..." does not work.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104635|0   |1
is obsolete||
 Attachment #104648|0   |1
is obsolete||

--- Comment #23 from Simon  ---
Created attachment 104675
  --> https://bugs.kde.org/attachment.cgi?id=104675=edit
Deduplicate code between icon and table view (V4)

@Maik Sorry for the inconvenience, even C should be tested...

@Vincent Yes, the current state also addresses the behaviour of groups
regarding slideshow. You will be able to choose whether to include all or only
the first (visible) image.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #22 from Maik Qualmann  ---
Simon,

patch 104648 does not compile...

/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:
In member function ‘QList
Digikam::TableView::getExtraGroupingActions() const’:
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:297:84:
error: invalid conversion from ‘const QObject*’ to ‘QObject*’ [-fpermissive]
 QAction* const actionHideGrouped = new QAction(i18n("Hide grouped items"),
this);
   
^
In file included from /usr/include/qt5/QtWidgets/qmenu.h:46:0,
 from /usr/include/qt5/QtWidgets/QMenu:1,
 from
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:31:
/usr/include/qt5/QtWidgets/qaction.h:94:14: note:   initializing argument 2 of
‘QAction::QAction(const QString&, QObject*)’
 explicit QAction(const QString , QObject *parent = nullptr);
  ^~~
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:307:84:
error: invalid conversion from ‘const QObject*’ to ‘QObject*’ [-fpermissive]
 QAction* const actionIgnoreGrouping = new QAction(i18n("Ignore grouping"),
this);
   
^
In file included from /usr/include/qt5/QtWidgets/qmenu.h:46:0,
 from /usr/include/qt5/QtWidgets/QMenu:1,
 from
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:31:
/usr/include/qt5/QtWidgets/qaction.h:94:14: note:   initializing argument 2 of
‘QAction::QAction(const QString&, QObject*)’
 explicit QAction(const QString , QObject *parent = nullptr);
  ^~~
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:317:88:
error: invalid conversion from ‘const QObject*’ to ‘QObject*’ [-fpermissive]
 QAction* const actionShowSubItems = new QAction(i18n("Show grouping in
tree"), this);
   
^
In file included from /usr/include/qt5/QtWidgets/qmenu.h:46:0,
 from /usr/include/qt5/QtWidgets/QMenu:1,
 from
/home/maik/Devel/digikam-software-compilation/core/app/views/tableview/tableview.cpp:31:
/usr/include/qt5/QtWidgets/qaction.h:94:14: note:   initializing argument 2 of
‘QAction::QAction(const QString&, QObject*)’
 explicit QAction(const QString , QObject *parent = nullptr);
  ^~~
make[2]: *** [core/app/CMakeFiles/digikamgui_src.dir/build.make:1178:
core/app/CMakeFiles/digikamgui_src.dir/views/tableview/tableview.cpp.o] Fehler
1

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Vincent Tassy]

https://bugs.kde.org/show_bug.cgi?id=377197

Vincent Tassy  changed:

   What|Removed |Added

 CC||time...@free.fr

--- Comment #21 from Vincent Tassy  ---
Will this patch also fix the current behaviour of the Slideshow (that shows all
images in the groups instead of the visible one) ?

Or does something need to be changed in the Slideshow or Selection code ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #20 from Simon  ---
Created attachment 104648
  --> https://bugs.kde.org/attachment.cgi?id=104648=edit
Deduplicate code between icon and table view (V3)

Ok, thanks for fixing. I wasn't aware of a QT LTS version we should be
compatible with.

Also about the split patch: I would indeed like to get the refactoring part
merged independently, as I assume the grouping part will need longer discussion
(?) and another issue I was looking at recently would be easier to fix with
this in place already.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #19 from caulier.gil...@gmail.com ---
Qt 5.6 LTS need certainly an explicit parent, or null. You must pass a parent
to QAction constructor.

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #18 from Simon  ---
I intentionally removed "this" from these kind of calls:

 QAction* const actionIgnoreGrouping = new QAction(i18n("Ignore grouping"),
this);

The reason is that they will be children of DigikamView not of TableView.
According to QT5 specifications (http://doc.qt.io/qt-5/qaction.html#QAction) a
missing parent object should be acceptable. For me it compiles just fine, I
don't understand why it doesn't for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #104636|0   |1
is obsolete||

--- Comment #17 from caulier.gil...@gmail.com ---
Created attachment 104641
  --> https://bugs.kde.org/attachment.cgi?id=104641=edit
Customize grouping behavior patch version 5

This version of patch fix 2 last problems that i report here...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #16 from caulier.gil...@gmail.com ---
This warning need also to be corrected :

[ 90%] Building CXX object
core/app/CMakeFiles/digikamgui_src.dir/digikamgui_src_automoc.cpp.o
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp: In member function ‘bool
Digikam::DigikamView::needGroupResolving(Digikam::ApplicationSettings::OperationType,
bool) const’:
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2469:12: warning:
enumeration value ‘WelcomePageMode’ not handled in switch [-Wswitch]
 switch (viewMode())
^
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2469:12: warning:
enumeration value ‘TrashViewMode’ not handled in switch [-Wswitch]

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #15 from caulier.gil...@gmail.com ---
"Customize" patch version 4 do not compile. I has fixed this problem in version
3 :

/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp: In member
function ‘QList Digikam::TableView::getExtraGroupingActions()’:
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:301:78: error: no
matching function for call to ‘QAction::QAction(QString)’
 QAction* const actionHideGrouped = new QAction(i18n("Hide grouped
items"));
  ^
In file included from /usr/lib64/qt5/include/QtWidgets/qmenu.h:40:0,
 from /usr/lib64/qt5/include/QtWidgets/QMenu:1,
 from
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:31:
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note: candidate:
QAction::QAction(QActionPrivate&, QObject*)
 QAction(QActionPrivate , QObject *parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note: candidate:
QAction::QAction(const QIcon&, const QString&, QObject*)
 QAction(const QIcon , const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note:   candidate expects 3
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note: candidate:
QAction::QAction(const QString&, QObject*)
 QAction(const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:87:14: note: candidate:
QAction::QAction(QObject*)
 explicit QAction(QObject* parent);
  ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:87:14: note:   no known conversion
for argument 1 from ‘QString’ to ‘QObject*’
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:311:78: error: no
matching function for call to ‘QAction::QAction(QString)’
 QAction* const actionIgnoreGrouping = new QAction(i18n("Ignore
grouping"));
  ^
In file included from /usr/lib64/qt5/include/QtWidgets/qmenu.h:40:0,
 from /usr/lib64/qt5/include/QtWidgets/QMenu:1,
 from
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:31:
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note: candidate:
QAction::QAction(QActionPrivate&, QObject*)
 QAction(QActionPrivate , QObject *parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note: candidate:
QAction::QAction(const QIcon&, const QString&, QObject*)
 QAction(const QIcon , const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note:   candidate expects 3
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note: candidate:
QAction::QAction(const QString&, QObject*)
 QAction(const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:87:14: note: candidate:
QAction::QAction(QObject*)
 explicit QAction(QObject* parent);
  ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:87:14: note:   no known conversion
for argument 1 from ‘QString’ to ‘QObject*’
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:321:82: error: no
matching function for call to ‘QAction::QAction(QString)’
 QAction* const actionShowSubItems = new QAction(i18n("Show grouping in
tree"));
   
  ^
In file included from /usr/lib64/qt5/include/QtWidgets/qmenu.h:40:0,
 from /usr/lib64/qt5/include/QtWidgets/QMenu:1,
 from
/home/gilles/Devel/5.x/core/app/views/tableview/tableview.cpp:31:
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note: candidate:
QAction::QAction(QActionPrivate&, QObject*)
 QAction(QActionPrivate , QObject *parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:174:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note: candidate:
QAction::QAction(const QIcon&, const QString&, QObject*)
 QAction(const QIcon , const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:89:5: note:   candidate expects 3
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note: candidate:
QAction::QAction(const QString&, QObject*)
 QAction(const QString , QObject* parent);
 ^
/usr/lib64/qt5/include/QtWidgets/qaction.h:88:5: note:   candidate expects 2
arguments, 1 provided
/usr/lib64/qt5/include/QtWidgets/qaction.h:87:14: note: candidate:
QAction::QAction(QObject*)
 

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104633|0   |1
is obsolete||

--- Comment #14 from Simon  ---
Created attachment 104636
  --> https://bugs.kde.org/attachment.cgi?id=104636=edit
Customize grouping behavior patch version 4

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104632|0   |1
is obsolete||

--- Comment #13 from Simon  ---
Created attachment 104635
  --> https://bugs.kde.org/attachment.cgi?id=104635=edit
Deduplicate code between icon and table view (V2)

So the idea of the two patches is just to split this into smaller changes that
are easier to review. If the refactor has problems, the rest won't work either.

There were some typos and C errors in the context menu, the issues you (Maik
& Gilles) reported should be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #12 from caulier.gil...@gmail.com ---
Simon, 

With Customize patch applied, i can see this on the console :

digikam.general: Cancel Main Thread
QObject::connect: No such slot Digikam::DigikamView::deleteSelected() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2594
QObject::connect: No such signal
Digikam::ContextMenuHelper::signalslotCreateGroupByTime() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2655
QObject::connect: No such signal
Digikam::ContextMenuHelper::signalslotCreateGroupByFilename() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2658
QObject::connect: No such slot Digikam::DigikamView::deleteSelected() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2594
QObject::connect: No such signal
Digikam::ContextMenuHelper::signalslotCreateGroupByTime() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2655
QObject::connect: No such signal
Digikam::ContextMenuHelper::signalslotCreateGroupByFilename() in
/home/gilles/Devel/5.x/core/app/views/digikamview.cpp:2658
digikam.geoiface: 

The grouping behavior do not generate frame around thumb anymore...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Attachment #104490|0   |1
is obsolete||

--- Comment #11 from caulier.gil...@gmail.com ---
Created attachment 104633
  --> https://bugs.kde.org/attachment.cgi?id=104633=edit
Customize grouping behavior patch version 3

Updated patch to compile with git/master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #10 from Maik Qualmann  ---
I have patch 104632 tested.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #9 from Maik Qualmann  ---
Simon,

Short test here, cut, copy, paste, delete to the trash no longer works.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #8 from caulier.gil...@gmail.com ---
[gilles@localhost core]$ patch -p1 < customizeGrouping-2.patch 
patching file app/items/digikamimageview.cpp
patching file app/items/digikamimageview.h
patching file app/items/imagecategorizedview.cpp
patching file app/items/imagecategorizedview.h
patching file app/main/digikamapp.cpp
patching file app/utils/contextmenuhelper.cpp
patching file app/views/digikamview.cpp
patching file app/views/digikamview.h
patching file app/views/tableview/tableview.cpp
patching file app/views/tableview/tableview.h
patching file app/views/tableview/tableview_model.cpp
patching file app/views/tableview/tableview_model.h
patching file libs/models/imagefiltermodel.cpp
patching file libs/settings/applicationsettings.cpp
patching file libs/settings/applicationsettings.h
Hunk #2 succeeded at 463 (offset 3 lines).
patching file libs/settings/applicationsettings_miscs.cpp
Hunk #2 succeeded at 288 (offset 11 lines).
patching file libs/settings/applicationsettings_p.cpp
Hunk #3 succeeded at 236 (offset 1 line).
Hunk #4 succeeded at 366 (offset 2 lines).
patching file libs/settings/applicationsettings_p.h
Hunk #3 succeeded at 285 (offset 1 line).
patching file utilities/setup/setupmisc.cpp
patching file utilities/setup/setupmisc.h

[gilles@localhost core]$ patch -p1 < viewRefactor.patch 
patching file app/items/digikamimageview.cpp
Reversed (or previously applied) patch detected!  Assume -R? [n] 

Why ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #7 from caulier.gil...@gmail.com ---
Note : it's voluntary to not include "Deduplicate" patch in "Customize" patch ?

Do you want to apply "Deduplicate" patch quickly in git/master ?

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #6 from caulier.gil...@gmail.com ---
Yes good improvement in source code.

Can you reproduce the icon/widget overlays on icon view, when you enable all
options from setup and when you change the icon size from status bar ?

Also turn on Hdpi support for icons view (thumb size > 256)...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #5 from Simon  ---
Created attachment 104632
  --> https://bugs.kde.org/attachment.cgi?id=104632=edit
Deduplicate code between icon and table view

This is the part of the patch that is not actually directly related to
grouping. I just needed this to get consistent behaviour between the two views
and to get rid of duplicate code. In my opinion it is cleaner and much less
error prone. It probably makes sense if you first look at this and when this is
committed we can look at the grouping stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon  changed:

   What|Removed |Added

 Attachment #104362|0   |1
is obsolete||

--- Comment #4 from Simon  ---
Created attachment 104490
  --> https://bugs.kde.org/attachment.cgi?id=104490=edit
Patch to customize grouping behaviour - 2

This is an actualized patch squashing some more duplicated code and fixing the
issues mentioned by Maik.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[Simon]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #3 from Simon  ---
Yes, context menu is obviously broken. I tested all kinds of things but
for unknown reasons never once did a right click. This code is also
heavily duplicated between table and icon view, I am thus refactoring
while fixing.

On 08/03/17 20:21, Maik Qualmann wrote:
> Simon,
>
> I think we do not need that much. A simple "use first image of grouped or use
> all images" for all actions should be enough. Let's see what Gilles says when
> he has time. I have also found some errors on the right mouse button context
> menu:
>
> - Assign color label to a group, the dialog asks for each image
> - Assign or remove tags no longer works
> - Assign rating no longer works
> - Assign flags no longer works
>
> Maik
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 377197] Customize grouping behaviour [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com
Summary|Customize grouping  |Customize grouping
   |behaviour   |behaviour [patch]

--- Comment #2 from caulier.gil...@gmail.com ---
Simon,

Curiously, i never seen this entry until Maik comment it.

So, i will take a look when time permit, i hope while this week end...

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.