[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #20 from caulier.gil...@gmail.com --- Git commit a928b12583326706cf063608238f0709d7d1021e by Gilles Caulier. Committed on 20/04/2021 at 13:23. Pushed by cgilles into branch 'master'. Install exiftool windows binary in the bundle M +10 -0project/bundles/mxe/04-build-installer.sh https://invent.kde.org/graphics/digikam/commit/a928b12583326706cf063608238f0709d7d1021e -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #19 from caulier.gil...@gmail.com --- Git commit 5f9bbe697f25710013cb07eca726d83b507e7292 by Gilles Caulier. Committed on 20/04/2021 at 12:57. Pushed by cgilles into branch 'master'. Add ExifTool information action to save in text file, print, and copy to clipboard M +231 -11 core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp M +11 -0core/libs/widgets/metadata/exiftool/exiftoolwidget.h https://invent.kde.org/graphics/digikam/commit/5f9bbe697f25710013cb07eca726d83b507e7292 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #18 from caulier.gil...@gmail.com --- Git commit 98e0208de3a28d5a5efa5d35633a686e4d09f749 by Gilles Caulier. Committed on 20/04/2021 at 09:08. Pushed by cgilles into branch 'master'. Add serach text bar in ExifToll list view to show only desired tags M +47 -0core/libs/widgets/metadata/exiftool/exiftoollistview.cpp M +9-0core/libs/widgets/metadata/exiftool/exiftoollistview.h M +31 -8core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp https://invent.kde.org/graphics/digikam/commit/98e0208de3a28d5a5efa5d35633a686e4d09f749 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #17 from caulier.gil...@gmail.com --- Git commit 0187bef07e024540cf99fbedee987a389f0f27d5 by Gilles Caulier. Committed on 19/04/2021 at 21:06. Pushed by cgilles into branch 'master'. Add ExifTool config view in Showfoto setup dialog. Add button to open ExifTool configuration tab in ExifTool error view. M +5-0core/showfoto/main/showfoto.cpp M +1-0core/showfoto/main/showfoto.h M +3-0core/showfoto/main/showfoto_setup.cpp M +28 -0core/showfoto/setup/showfotosetup.cpp M +1-0core/showfoto/setup/showfotosetup.h M +39 -5core/showfoto/setup/showfotosetupmetadata.cpp M +2-1core/showfoto/setup/showfotosetupmetadata.h M +2-2core/utilities/setup/metadata/setupmetadata.cpp https://invent.kde.org/graphics/digikam/commit/0187bef07e024540cf99fbedee987a389f0f27d5 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #16 from caulier.gil...@gmail.com --- Git commit 27ba22ba8f9055545ddcb3c07f822211c40245eb by Gilles Caulier. Committed on 19/04/2021 at 17:57. Pushed by cgilles into branch 'master'. Add button to open ExifTool configuration tab. M +3-0core/app/views/stack/itemiconview.cpp M +1-0core/app/views/stack/itemiconview.h M +5-0core/app/views/stack/itemiconview_views.cpp M +3-0core/libs/properties/itempropertiesmetadatatab.cpp M +1-0core/libs/properties/itempropertiesmetadatatab.h M +3-0core/libs/properties/itempropertiessidebar.cpp M +1-0core/libs/properties/itempropertiessidebar.h M +23 -5core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp M +4-0core/libs/widgets/metadata/exiftool/exiftoolwidget.h M +32 -4core/utilities/setup/setup.cpp M +1-0core/utilities/setup/setup.h https://invent.kde.org/graphics/digikam/commit/27ba22ba8f9055545ddcb3c07f822211c40245eb -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #15 from caulier.gil...@gmail.com --- Git commit fc2e13dccdc8c923838d203699bfb61a95a7d473 by Gilles Caulier. Committed on 19/04/2021 at 15:47. Pushed by cgilles into branch 'master'. Add digiKam setup ExifTool tab in Setup Metadata to customize binary path. Use MetaEngineSettings container to store and retreive ExifTool path from application configuration file. TODO: patch Showfoto M +34 -0core/libs/metadataengine/engine/metaenginesettingscontainer.cpp M +5-1core/libs/metadataengine/engine/metaenginesettingscontainer.h M +25 -11 core/libs/metadataengine/exiftool/exiftoolparser.cpp M +2-0core/libs/metadataengine/exiftool/exiftoolparser.h M +5-0core/libs/metadataengine/exiftool/exiftoolprocess.cpp M +2-0core/libs/metadataengine/exiftool/exiftoolprocess.h M +2-1core/libs/widgets/metadata/exiftool/exiftoolbinary.cpp M +37 -1core/utilities/setup/metadata/setupmetadata.cpp M +1-0core/utilities/setup/metadata/setupmetadata.h https://invent.kde.org/graphics/digikam/commit/fc2e13dccdc8c923838d203699bfb61a95a7d473 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #14 from caulier.gil...@gmail.com --- Git commit 78bbca7948fc348d9813adf0b220c19d3caf508b by Gilles Caulier. Committed on 19/04/2021 at 11:20. Pushed by cgilles into branch 'master'. Use stackedWidget to show error message from ExifTool at run-time. M +6-6core/libs/properties/itempropertiesmetadatatab.cpp M +66 -0core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp M +21 -1core/libs/widgets/metadata/exiftool/exiftoolwidget.h https://invent.kde.org/graphics/digikam/commit/78bbca7948fc348d9813adf0b220c19d3caf508b -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #13 from caulier.gil...@gmail.com --- Git commit c86e2844bc4730b91a91458f9bc307863ed617c8 by Gilles Caulier. Committed on 19/04/2021 at 08:37. Pushed by cgilles into branch 'master'. files missing A +48 -0core/libs/widgets/metadata/exiftool/exiftoolbinary.cpp [License: GPL (v2+)] A +48 -0core/libs/widgets/metadata/exiftool/exiftoolbinary.h [License: GPL (v2+)] https://invent.kde.org/graphics/digikam/commit/c86e2844bc4730b91a91458f9bc307863ed617c8 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #12 from caulier.gil...@gmail.com --- Git commit cc2a9d2a5981537a6df099c765d244dcb8656dac by Gilles Caulier. Committed on 19/04/2021 at 08:36. Pushed by cgilles into branch 'master'. Add new widget to auto-detect ExifTool binary program and version M +2-1core/libs/widgets/CMakeLists.txt R +0-0core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp [from: core/libs/widgets/metadata/exiftoolwidget.cpp - 100% similarity] R +2-1core/libs/widgets/metadata/exiftool/exiftoolwidget.h [from: core/libs/widgets/metadata/exiftoolwidget.h - 096% similarity] https://invent.kde.org/graphics/digikam/commit/cc2a9d2a5981537a6df099c765d244dcb8656dac -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #11 from caulier.gil...@gmail.com --- Screenshot of ExifTool metatada viewer playing with a video file: https://imgur.com/FJvCAzX Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #10 from caulier.gil...@gmail.com --- Git commit 15bce2a888a41d1ca08b3fe28d1a5caa6294ba7d by Gilles Caulier. Committed on 18/04/2021 at 21:15. Pushed by cgilles into branch 'master'. Introduce the new ExifTool information viewer from Metadata sidebar tab. M +4-0core/libs/metadataengine/exiftool/exiftoolparser.cpp M +1-1core/libs/properties/import/importitempropertiessidebar.cpp M +39 -18 core/libs/properties/itempropertiesmetadatatab.cpp M +1-1core/libs/properties/itempropertiesmetadatatab.h M +1-1core/libs/properties/itempropertiessidebardb.cpp M +1-0core/libs/widgets/CMakeLists.txt A +151 -0core/libs/widgets/metadata/exiftoolwidget.cpp [License: GPL (v2+)] A +96 -0core/libs/widgets/metadata/exiftoolwidget.h [License: GPL (v2+)] https://invent.kde.org/graphics/digikam/commit/15bce2a888a41d1ca08b3fe28d1a5caa6294ba7d -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 --- Comment #9 from caulier.gil...@gmail.com --- Git commit c9dc01b30ced031242b98a87271183fe56784442 by Gilles Caulier. Committed on 18/04/2021 at 19:26. Pushed by cgilles into branch 'master'. Move ExifTool wrapper to digiKam core for a future use as simple extra info viewer in metadata sidebar Exiv2 translator is not yet used, and no DMetadata integration is done. We will do it step by step as ExifTool to Exiv2 tags name conversion is a big puzzle. M +9-0core/libs/metadataengine/CMakeLists.txt M +1-0core/libs/metadataengine/README R +9-0core/libs/metadataengine/exiftool/exiftoolparser.cpp [from: core/tests/metadataengine/exiftool/qt/exiftoolparser.cpp - 098% similarity] R +5-1core/libs/metadataengine/exiftool/exiftoolparser.h [from: core/tests/metadataengine/exiftool/qt/exiftoolparser.h - 096% similarity] R +0-0core/libs/metadataengine/exiftool/exiftoolprocess.cpp [from: core/tests/metadataengine/exiftool/qt/exiftoolprocess.cpp - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftoolprocess.h [from: core/tests/metadataengine/exiftool/qt/exiftoolprocess.h - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator.cpp - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator.h [from: core/tests/metadataengine/exiftool/common/exiftooltranslator.h - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator_exif.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_exif.cpp - 100% similarity] R +0-0 core/libs/metadataengine/exiftool/exiftooltranslator_ignoredgroups.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_ignoredgroups.cpp - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator_iptc.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_iptc.cpp - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator_p.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_p.cpp - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator_p.h [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_p.h - 100% similarity] R +0-0core/libs/metadataengine/exiftool/exiftooltranslator_xmp.cpp [from: core/tests/metadataengine/exiftool/common/exiftooltranslator_xmp.cpp - 100% similarity] M +41 -9core/tests/metadataengine/exiftool/CMakeLists.txt D +0-36 core/tests/metadataengine/exiftool/cpp/CMakeLists.txt D +0-3core/tests/metadataengine/exiftool/cpp/README D +0-1421 core/tests/metadataengine/exiftool/cpp/exiftoolcore.cpp D +0-129 core/tests/metadataengine/exiftool/cpp/exiftoolcore.h D +0-175 core/tests/metadataengine/exiftool/cpp/exiftoolloader_cli.cpp D +0-305 core/tests/metadataengine/exiftool/cpp/exiftoolpipe.cpp D +0-64 core/tests/metadataengine/exiftool/cpp/exiftoolpipe.h D +0-80 core/tests/metadataengine/exiftool/cpp/exiftooltaginfo.cpp D +0-58 core/tests/metadataengine/exiftool/cpp/exiftooltaginfo.h R +0-0core/tests/metadataengine/exiftool/qexiftoolexport_cli.cpp [from: core/tests/metadataengine/exiftool/qt/qexiftoolexport_cli.cpp - 100% similarity] R +0-0core/tests/metadataengine/exiftool/qexiftoolloader_cli.cpp [from: core/tests/metadataengine/exiftool/qt/qexiftoolloader_cli.cpp - 100% similarity] R +0-0core/tests/metadataengine/exiftool/qexiftooloutput_cli.cpp [from: core/tests/metadataengine/exiftool/qt/qexiftooloutput_cli.cpp - 100% similarity] R +0-0core/tests/metadataengine/exiftool/qexiftoolxmldb_cli.cpp [from: core/tests/metadataengine/exiftool/qt/qexiftoolxmldb_cli.cpp - 100% similarity] D +0-78 core/tests/metadataengine/exiftool/qt/CMakeLists.txt https://invent.kde.org/graphics/digikam/commit/c9dc01b30ced031242b98a87271183fe56784442 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 386299] Add ExifTool based wrapper to read and write metadata
https://bugs.kde.org/show_bug.cgi?id=386299 caulier.gil...@gmail.com changed: What|Removed |Added Summary|Add ExifTool based metadata |Add ExifTool based wrapper |wrapper as in XnView|to read and write metadata --- Comment #8 from caulier.gil...@gmail.com --- Hi Maik, * I experimented and review code from 2 ExifTool parser: - the official C++ version from ExifTool author: https://exiftool.org/cpp_exiftool/ This one use a low level C ANSI call internally and capture meta information using a PHP compliant container. It's limited to capture non binary tags values. So typically to get and set preview, markernote, icc profile, xmp packet, it's not possible. To evolve the C ANSI code is a puzzle. I tried, and after to reformat all source code to understand the structure, i admit this wrapper is not adapted for DK. Also this code do not compile under Windows with MSVC, only MinGW. The advantage to this wrapper is the speed and the capability to chain requests with a pending instance of ExifTool in memory. - this recent Qt wrapper from Github : https://github.com/philvl/ZExifTool Compatible with Qt5 and Qt6, this one use a json container to handle ExifTool information. This code is more simple as all the json parsing is delegate to Qt. It's definitively the best way to do, event if code is a little bit slower the official C++ wrapper. It can also chain request to ExifTool, but it use Qt signal slot mechanism with QProcess, which is less adapted to DMetadata integration. So is write a parser class to delegate and capture signal event from the core class with a dedicated event loop and now the code can be streamlined in DMetadata in a synchronous run-time. This code is fully portable. * I write 2 unit tests : one to display the ExifTool parsing results with Exiv2 tags conversion, and another one to backport ExifTool tags to Exiv2 with DMetadata container. Both work as expected, even if improvements still in my TODO list. * I write a ExifTool to Exiv2 tags converter (and vis-versa). Basically, one main hash table need to be populated to know the correspondence. I started to write the tags map one by one, and it really a huge task to achieve. It work but it's not the right way to do, as typically, the main tag "name" is at 80% the same between ExifTool and Exiv2: ExifTool tag naming scheme : group0:group1:group2:name Exiv2 tag naming scheme: family.group.name Take a look to the current hard-coded Exif tags list for ex : https://invent.kde.org/graphics/digikam/-/blob/c761d5550dc02edefbf003f8e9deabba1196021e/core/tests/metadataengine/exiftool/common/exiftooltranslator_exif.cpp A better way is to write generic rules to populate the hash table automatically which will support 80% of ExifTool tags compatible with Exiv2. For the 20% left, custom rules must be written to handle exceptions. A unit test to validate conversion and to found new exception must be written. Voilà, i continue to work on this ExifTool wrapper to at least provide a read metadata mechanism for 7.3.0 or 7.4.0 My best Gilles -- You are receiving this mail because: You are watching all bug changes.
