[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=388386

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #11 from caulier.gil...@gmail.com ---
yes, and it's already available in last official 6.0.0-beta3 released few days
ago...

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Jens]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #10 from Jens  ---
Will this make it into 6.0-final?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=388386

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||6.0.0
  Latest Commit||https://commits.kde.org/dig
   ||ikam/78a52448882d3819b5ae56
   ||44b83cf9e8b43d90ad
 Status|REPORTED|RESOLVED

--- Comment #9 from Maik Qualmann  ---
Git commit 78a52448882d3819b5ae5644b83cf9e8b43d90ad by Maik Qualmann.
Committed on 19/09/2018 at 11:03.
Pushed by mqualmann into branch 'master'.

first step to backport Time Adjust tool as a separate tool to digiKam
Related: bug 366777
FIXED-IN: 6.0.0

M  +3-1NEWS
M  +1-0core/app/CMakeLists.txt
M  +1-0core/app/main/digikamapp.h
M  +1-0core/app/main/digikamapp_p.h
M  +1-0core/app/main/digikamapp_setup.cpp
M  +22   -0core/app/main/digikamapp_tools.cpp
M  +2-1core/app/main/digikamui5.rc
M  +11   -0core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +5-0core/libs/widgets/mainview/dxmlguiwindow.h
M  +1-0core/utilities/CMakeLists.txt
M  +0-4core/utilities/queuemanager/CMakeLists.txt
A  +31   -0core/utilities/timeadjust/CMakeLists.txt
R  +0-0core/utilities/timeadjust/clockphotodialog.cpp [from:
core/utilities/queuemanager/tools/metadata/clockphotodialog.cpp - 100%
similarity]
R  +3-3core/utilities/timeadjust/clockphotodialog.h [from:
core/utilities/queuemanager/tools/metadata/clockphotodialog.h - 093%
similarity]
R  +0-0core/utilities/timeadjust/detbyclockphotobutton.cpp [from:
core/utilities/queuemanager/tools/metadata/detbyclockphotobutton.cpp - 100%
similarity]
R  +4-4core/utilities/timeadjust/detbyclockphotobutton.h [from:
core/utilities/queuemanager/tools/metadata/detbyclockphotobutton.h - 090%
similarity]
R  +0-0core/utilities/timeadjust/timeadjustcontainer.cpp [from:
core/utilities/queuemanager/tools/metadata/timeadjustcontainer.cpp - 100%
similarity]
R  +8-4core/utilities/timeadjust/timeadjustcontainer.h [from:
core/utilities/queuemanager/tools/metadata/timeadjustcontainer.h - 092%
similarity]
A  +442  -0core/utilities/timeadjust/timeadjustdialog.cpp [License: GPL
(v2+)]
A  +108  -0core/utilities/timeadjust/timeadjustdialog.h [License: GPL
(v2+)]
A  +113  -0core/utilities/timeadjust/timeadjustlist.cpp [License: GPL
(v2+)]
A  +74   -0core/utilities/timeadjust/timeadjustlist.h [License: GPL
(v2+)]
R  +0-0core/utilities/timeadjust/timeadjustsettings.cpp [from:
core/utilities/queuemanager/tools/metadata/timeadjustsettings.cpp - 100%
similarity]
C  +5-4core/utilities/timeadjust/timeadjustsettings.h [from:
core/utilities/queuemanager/tools/metadata/timeadjustsettings.h - 089%
similarity]
A  +226  -0core/utilities/timeadjust/timeadjusttask.cpp [License: GPL
(v2+)]
C  +17   -24   core/utilities/timeadjust/timeadjusttask.h [from:
core/utilities/queuemanager/tools/metadata/timeadjustsettings.h - 057%
similarity]
A  +133  -0core/utilities/timeadjust/timeadjustthread.cpp [License: GPL
(v2+)]
R  +24   -24   core/utilities/timeadjust/timeadjustthread.h [from:
core/utilities/queuemanager/tools/metadata/timeadjustsettings.h - 057%
similarity]

https://commits.kde.org/digikam/78a52448882d3819b5ae5644b83cf9e8b43d90ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[IWBR]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #8 from IWBR  ---
> But, as the original poster mentioned its not clear what "Overwrite" is 
> doing.  Hopefully its just editting the EXIF data.
It just changes the EXIF data, it doesn't affect the picture itself (I made
sure personally before correcting the date of many pictures).

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Jens]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #7 from Jens  ---
Then 
- either the Time adjust tool does not belong in BQM
or
- the BQM needs to hide this complexity from the user.


As a friend of mine (who does software development at Apple) keeps saying:
technical reasons are no excuse for bad UI design. 

;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=388386

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #6 from Maik Qualmann  ---
The BQM always needs a target file internally. For metadata tools, if there are
no image editing tools in the queue, a copy of the original file is created.
Then the metadata operations are performed on the copy. If there was no error,
either the copy is renamed, or if the overwrite option is set, the original
file is replaced.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Job E .]

https://bugs.kde.org/show_bug.cgi?id=388386

Job E.  changed:

   What|Removed |Added

 CC||jobev...@gmail.com

--- Comment #5 from Job E.  ---
Adding my two cents of agreement here.  The first time I ran through the BQM to
change a bunch of timestamps I ended up with a bunch of duplicate files as I
didn't set the "overwrite" settings

But, as the original poster mentioned its not clear what "Overwrite" is doing. 
Hopefully its just editting the EXIF data.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Jens]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #4 from Jens  ---
Created attachment 114557
  --> https://bugs.kde.org/attachment.cgi?id=114557=edit
iphoto timeadjust dialog

Same with iPhoto - the dialog is extremely simple, yet allows for relative and
absolute adjustments of multiple photos and can even directly adjust (existing)
metadata of the files.
With Digikam I am given seven options of metadata to adjust, how should a
normal user know which ones are relevant?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[IWBR]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #3 from IWBR  ---
I also believe the date and time change tools (either by editing metadata or
using the batch manager) are unnecessarily complicated.

Yes, it is good that we have the option to edit every single one of the date
metadata fields, either being XMP, Exif or IPTC, but for most cases, a much
simpler dialog could be used and wouldn't lead to confusion.

I have in mind Picasa's dialog, with just two fields and two options, and it is
often more than enough. See attached screenshot. It would be great if we could
have a simple date/time change option.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[IWBR]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #2 from IWBR  ---
Created attachment 114195
  --> https://bugs.kde.org/attachment.cgi?id=114195=edit
Picasa's date and time change option

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[IWBR]

https://bugs.kde.org/show_bug.cgi?id=388386

IWBR  changed:

   What|Removed |Added

 CC||iwannaber...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Johannes]

https://bugs.kde.org/show_bug.cgi?id=388386

Johannes  changed:

   What|Removed |Added

 CC||johannes.lists+bugs.kde.org
   ||@tannenhof-imshausen.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 388386] Time adjustment tool is misleading and potentially leads to data loss

[Jens]

https://bugs.kde.org/show_bug.cgi?id=388386

--- Comment #1 from Jens  ---
Hello, can somebody please handle this usability issue? I just messed up the
timestamps of about 400 photos because I accidentally re-executed a timestamp
batch job on a previously selected list of photos which - for some reason -
were still in the batch queue manager. Also, BQM went into an endless loop and
executed the time adjustment (subtraction of some hours) multiple times on some
photos!

I just want a simple UI to adjust the timestamp on my photos and videos. I
don't think this feature belongs into BQM ...

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.