[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389785

caulier.gil...@gmail.com changed:

   What|Removed |Added

   Version Fixed In||6.0.0
 Resolution|DUPLICATE   |FIXED

--- Comment #14 from caulier.gil...@gmail.com ---
Git commit 2eb13d7ceab223675a86bbdac0a1065b206c2954 by Gilles Caulier.
Committed on 14/08/2018 at 21:48.
Pushed by cgilles into branch 'master'.

use system() call instead QProcess

M  +6-13   project/bundles/3rdparty/ext_qt/qt-appimage-support.patch

https://commits.kde.org/digikam/2eb13d7ceab223675a86bbdac0a1065b206c2954

diff --git a/project/bundles/3rdparty/ext_qt/qt-appimage-support.patch
b/project/bundles/3rdparty/ext_qt/qt-appimage-support.patch
index 781ed92ca8..dd6d99b250 100644
--- a/project/bundles/3rdparty/ext_qt/qt-appimage-support.patch
+++ b/project/bundles/3rdparty/ext_qt/qt-appimage-support.patch
@@ -2,7 +2,7 @@ diff --git
a/qtbase/src/platformsupport/services/genericunix/qgenericunixservice
 index cdb5d33859..5a2bd5f724 100644
 --- a/qtbase/src/platformsupport/services/genericunix/qgenericunixservices.cpp
 +++ b/qtbase/src/platformsupport/services/genericunix/qgenericunixservices.cpp
-@@ -146,7 +146,30 @@ static inline bool launch(const QString , const
QUrl )
+@@ -146,7 +146,23 @@ static inline bool launch(const QString , const
QUrl )
  #if !QT_CONFIG(process)
  const bool ok = ::system(qPrintable(command + QLatin1String(" &")));
  #else
@@ -17,20 +17,13 @@ index cdb5d33859..5a2bd5f724 100644
 +{
 +qDebug() << "Adjusting environment variables for AppImage bundle";
 +
-+env.insert(QLatin1String("LD_LIBRARY_PATH"),
-+  
env.value(QLatin1String("APPIMAGE_ORIGINAL_LD_LIBRARY_PATH")));
-+env.insert(QLatin1String("QT_PLUGIN_PATH"),
-+  
env.value(QLatin1String("APPIMAGE_ORIGINAL_QT_PLUGIN_PATH")));
-+env.insert(QLatin1String("XDG_DATA_DIRS"),
-+  
env.value(QLatin1String("APPIMAGE_ORIGINAL_XDG_DATA_DIRS")));
-+env.insert(QLatin1String("PATH"),
-+   env.value(QLatin1String("APPIMAGE_ORIGINAL_PATH")));
++setenv("LD_LIBRARY_PATH",
env.value(QLatin1String("APPIMAGE_ORIGINAL_LD_LIBRARY_PATH")).toLatin1().data(),
1);
++setenv("QT_PLUGIN_PATH", 
env.value(QLatin1String("APPIMAGE_ORIGINAL_QT_PLUGIN_PATH")).toLatin1().data(),
 1);
++setenv("XDG_DATA_DIRS",  
env.value(QLatin1String("APPIMAGE_ORIGINAL_XDG_DATA_DIRS")).toLatin1().data(), 
 1);
++setenv("PATH",   
env.value(QLatin1String("APPIMAGE_ORIGINAL_PATH")).toLatin1().data(),  
 1);
 +}
 +
-+QProcess process;
-+process.setProcessEnvironment(env);
-+process.setProgram(command);
-+const bool ok = process.startDetached();
++const bool ok = ::system(qPrintable(command + QLatin1String(" &")));
  #endif
  if (!ok)
  qWarning("Launch failed (%s)", qPrintable(command));

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #13 from caulier.gil...@gmail.com ---
because in Qt5 framework, there is a mechanism to detect the current desktop
and choose the most appropriate rule to load a web browser. Xubuntu do not use
KDE, so no KIO in fact... and it work.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Carlos Echenique]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #12 from Carlos Echenique  ---
For the record, this is only a problem in Kubuntu. In Xubuntu, it works as
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Carlos Echenique]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #11 from Carlos Echenique  ---
I created a symbolic link between
/usr/lib/x86_64-linux-gnu/libexec/kf5/kioslave and /usr/bin and when I try to
export I get a desktop notification with the URL and dialog box asking me what
app to run. I enter /usr/bin/firefox and nothing happens.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Carlos Echenique]

https://bugs.kde.org/show_bug.cgi?id=389785

Carlos Echenique  changed:

   What|Removed |Added

 CC||car...@echenique.com

--- Comment #10 from Carlos Echenique  ---
Could you post the exact command you used to fix this? It is a little vague at
the end there. You said link to /usr/bin/ but link what exactly and where?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[tuxflo]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #9 from tuxflo  ---
I solved it! Instead of linking to /usr/lib64/libexec/kf5/kioslave I just had
to link to /usr/bin (I think that to other paths in the appimage are relative
paths as .././libexec/kf5...). So it works for me now.
To answer your question: I KDE Neon has the latest version (5.8.0 Build date:
Jan 14 2018 (target: Debian)) in the packages but I'd like to try the new
technologies as appimage since it is easier to switch between versions. And
this core functionality should work regardless of the used version.

To make this long story short: if anybody else has this issue, just link
kioslave to /usr/bin and everything is fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #8 from Maik Qualmann  ---
KIO is a big puzzle. Presumably QDesktopService has to be compiled together
with KF5 KIO, I do not know yet. Another question: If KDE Neon is an "official"
KDE distribution, are there no native digiKam-5.8.0 packages yet?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[tuxflo]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #7 from tuxflo  ---
Ok here is what I did so far:

tuxflo@Yoga-260 ~ % sudo ln -s /usr/lib/x86_64-linux-gnu/libexec/kf5/kioslave
/usr/lib64/libexec/kf5/kioslave

which seems ok:
tuxflo@Yoga-260 ~ % ll /usr/lib64/libexec/kf5 
total 0
lrwxrwxrwx 1 root root 46 Feb  2 12:38 kioslave ->
/usr/lib/x86_64-linux-gnu/libexec/kf5/kioslave

but I still get the same error when trying to open the filemanager from
digikam. Do I have to grant special permissions? Is there a way to "manually"
call kioslave with the parameters digikam uses?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #6 from Maik Qualmann  ---
Ok, actually the other way round ((:-))

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #5 from Maik Qualmann  ---
Can you create for testing a symbolic link from:

/usr/lib64/libexec/kf5/kioslave

to:

/usr/lib/x86_64-linux-gnu/libexec/kf5/kioslave

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[tuxflo]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #4 from tuxflo  ---
Thanks for the quick reply!
Here is what 'find' is telling me:

tuxflo@Yoga-260 ~ % find /usr -name "kioslave*"
/usr/lib/x86_64-linux-gnu/libexec/kf5/kioslave

Flo

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #3 from Maik Qualmann  ---
Let's see, maybe we can add another search path to the AppImage. Here it works
on openSUSE and the KF5 kioslave binary is located in /usr/lib64/libexec/kf5/.
Where is this file in KDE Neon?

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[tuxflo]

https://bugs.kde.org/show_bug.cgi?id=389785

--- Comment #2 from tuxflo  ---
Hmmm that sound strange, since KDE Neon is the "official" KDE distribution and
comes directly from the KDE community, so I think this should work. Also I'm
pretty sure, that there is not much KDE4 related stuff included in the system.

The other thing is, that I thought that the big advantage of technologies as
appimage (or snap, flatpak...) is that every dependency is included. So why not
add the needed kioslave executable to the package (if thats possible)?
Is there another way to get the recent version of digikam in this LTS version
of ubuntu (or KDE Neon)?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=389785

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||metzping...@gmail.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Maik Qualmann  ---
Open file manager or browser has the same cause under Ubuntu. This Ubuntu
version is a mix of KDE4 with a plasma desktop. I think we will not be able to
solve this problem. I did not get the kioslave5 to start under this Ubuntu
version, because in principle the kioslave of KDE4 is set up.

Maik

*** This bug has been marked as a duplicate of bug 387201 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=389785

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Albums-Engine   |Bundle-AppImage
 CC||caulier.gil...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 389785] 'Open in Filemanager' dolphin not working

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389785

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.