[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-06 Thread Peter Albrecht
https://bugs.kde.org/show_bug.cgi?id=394988

--- Comment #6 from Peter Albrecht  ---
Thanks! It works great in pre-release
"digikam-6.0.0-git-20180605T154040-x86-64.appimage"!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-04 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=394988

--- Comment #5 from Maik Qualmann  ---
Note: You must remove page up and down from the shortcut dialog. These
shortcuts must remain hardcoded. You can now use page up and down in the tag
search field.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-04 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=394988

Maik Qualmann  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||6.0.0
  Latest Commit||https://commits.kde.org/dig
   ||ikam/67976d43fb7c86f4ca7066
   ||ccc8f144f155f7b4a6

--- Comment #4 from Maik Qualmann  ---
Git commit 67976d43fb7c86f4ca7066ccc8f144f155f7b4a6 by Maik Qualmann.
Committed on 04/06/2018 at 10:37.
Pushed by mqualmann into branch 'master'.

add page up and down shortcuts to the right sidebar
FIXED-IN: 6.0.0

M  +2-1NEWS
M  +3-4core/app/views/digikamview.cpp

https://commits.kde.org/digikam/67976d43fb7c86f4ca7066ccc8f144f155f7b4a6

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-03 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=394988

Maik Qualmann  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Maik Qualmann  ---
Ok, in the preview I can confirm the problem. We add these shortcuts. I'll look
for a solution tomorrow.

void DigikamView::Private::addPageUpDownActions(DigikamView* const q, QWidget*
const w)
{
defineShortcut(w, Qt::Key_PageDown, q, SLOT(slotNextItem()));
defineShortcut(w, Qt::Key_Down, q, SLOT(slotNextItem()));
defineShortcut(w, Qt::Key_Right,q, SLOT(slotNextItem()));

defineShortcut(w, Qt::Key_PageUp,   q, SLOT(slotPrevItem()));
defineShortcut(w, Qt::Key_Up,   q, SLOT(slotPrevItem()));
defineShortcut(w, Qt::Key_Left, q, SLOT(slotPrevItem()));
}

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-03 Thread Peter Albrecht
https://bugs.kde.org/show_bug.cgi?id=394988

--- Comment #2 from Peter Albrecht  ---
@Maik:
I use KDE as desktop environment. And I installed Debian Stretch this morning
on this computer. (So I had not much time to change shortcuts. And can't
remember doing so anywhere else then in digiKam.)

I checked my defined shortcuts:
In digiKam there is no other shortcut bound to "PgDown" or "PgUp" then "Next
Image" or "Previous Image". There is no "PgDown" or "PgUp" shortcut defined in
KDE's "Global Shortcuts". But there had been defined shortcuts for
"PgUp"="Previous Page" and "PgDown"="Next Page" in KDE's "Standard Shortcuts".
After removing those, I can no longer scroll in KWrite via PgUp or PgDown. So
the change had some effect. But after restarting digiKam, the behavior is still
like my first comment said: Changing images in "preview mode" leads to the
messagebox: "Ambiguous shortcut detected".

Can you scroll through images in preview mode after having assigned "PgDown" to
"Next Image" while the input focus is on a thumbnail in the thumbnail roll
above the preview image?

For me, switching images via PgDown/PgUp works, if input is in the tag search
box. But it fails, if the focus is on a thumbnail in the thumbnail row above
the preview image.

(Just discovered: Alongside the configured default shortcuts
"space"/"backspace" one can also switch images in preview mode with: Cursor
left/right or cursor up/down - although not explicitly configured)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 394988] PgDown and PgUp hardcoded in preview mode

2018-06-03 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=394988

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #1 from Maik Qualmann  ---
That we hardcoded the page up and down keys does not matter here. If I remember
correctly, the keyboard event is queried, of which the shortcuts dialog knows
nothing. If I assign page up and down keys here and the focus is in the tag
search box, it works as desired. Check in the shortcuts dialog whether you are
not already using page up and down, or even globally from your desktop system.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.