[digikam] [Bug 403649] Filesystem changes are not visible in album view [patch]
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #13 from Lukáš Karas --- Thank you. Please consider to add some "isFileNested" variant anyway. Around collection is a lot of duplicate code that can be moved to utility methods... -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view [patch]
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #12 from Maik Qualmann --- I chose another variant of the patch. We should make sure that the function everywhere gives us a correct location root path. Otherwise this check would have to be repeated again and again. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view [patch]
https://bugs.kde.org/show_bug.cgi?id=403649 Maik Qualmann changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit||https://commits.kde.org/dig ||ikam/df26831e562625cd8ba731 ||c11f35a6279945a13b Version Fixed In||6.1.0 --- Comment #11 from Maik Qualmann --- Git commit df26831e562625cd8ba731c11f35a6279945a13b by Maik Qualmann. Committed on 14/03/2019 at 20:08. Pushed by mqualmann into branch 'master'. check a slash from the end of the album root path FIXED-IN: 6.1.0 M +2-1NEWS M +9-1core/libs/database/collection/collectionmanager_p.h https://commits.kde.org/digikam/df26831e562625cd8ba731c11f35a6279945a13b -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view [patch]
https://bugs.kde.org/show_bug.cgi?id=403649 Maik Qualmann changed: What|Removed |Added Attachment #117946|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view [patch]
https://bugs.kde.org/show_bug.cgi?id=403649 caulier.gil...@gmail.com changed: What|Removed |Added Summary|Filesystem changes are not |Filesystem changes are not |visible in album view |visible in album view ||[patch] --- Comment #10 from caulier.gil...@gmail.com --- As 6.0.0 will be released tomorrow, this patch is targeted to 6.1.0 Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #9 from Lukáš Karas --- Created attachment 117946 --> https://bugs.kde.org/attachment.cgi?id=117946=edit patch that solves albumRootPath method issue with database root ending with slash I can offer this patch, that solves problem with albumRootPath and deduplicate code little bit. I don't found better place where to put new method, CollectionManager don't sounds like a good place for it :-( More over, it don't solves original issue - re-scan is started properly, but view is not updated. It seems that more places in the code don't work with album root that is ending with slash... -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #8 from Maik Qualmann --- Lukas, look at the implementation of digikam-6.0.0. We now have an easy way to customize the AlbumRoot at drive change. Manual editing of the DB is no longer necessary. It also checks if the AlbumRoot exists and if it does not, it will set the collection unavailable to handle problems with network drives. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 caulier.gil...@gmail.com changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED Ever confirmed|0 |1 --- Comment #7 from caulier.gil...@gmail.com --- Thanks Lukas for your investigation. You are welcome to contribute. I re-open this file as the problem still open and you will provide a generic patch for this entry. Best Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 Lukáš Karas changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #6 from Lukáš Karas --- I found it. Problem comes from the moment when I replaced my notebook and manually updated drive UUID and path in "AlbumRoots" table. And I keep trailing slash in the path: "/home/karry/data/fotky/". Everything seemed be fine except collection scanning... When you look carefully to "albumRootPath" method - in current master here: https://cgit.kde.org/digikam.git/tree/core/libs/database/collection/collectionmanager_album.cpp#n93 there is fix for the launchpad bug #221155 that adds slash to the "rootPath" and in my case check if "/root/album" starts with "/root//"... I was able to fix my mistake with this knowledge and make scanning functional again. Question is if "albumRootPath" should be more robust? I saw similar pattern on multiple places, I will try to send a patch... -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #5 from Maik Qualmann --- It's very strange that the AlbumRoot or the Album is null. I do not really have an explanation for that at the moment. The QFileSystemWatcher seems to be send the event, but why the directory being scanned is not valid would actually need to debug. I see in your path special characters, the problem also occurs in folders that contain no special characters? I could not reproduce the problem with your folder name. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 --- Comment #4 from caulier.gil...@gmail.com --- With official package, you need to install the _debug_ package to have... debug symbols (:=)))... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649
--- Comment #3 from Lukáš Karas ---
I just upgrade to Ubuntu Cosmic (18.10) that distributes DigiKam in version
5.9.0 and problem is still here.
When I am looking to source (current master), some argument is probably empty:
if (albumRoot.isNull() || album.isEmpty())
{
// If you want to scan the album root, pass "/"
qCWarning(DIGIKAM_DATABASE_LOG) << "partialScan(QString, QString)
called with invalid values";
return;
}
How it is possible?
When I run digikam in debugger, it seems that there is no enough debug info,
local variables are not visible, just stack trace:
#0 0x7520bda0 in Digikam::CollectionScanner::partialScan(QString
const&, QString const&) () at /usr/lib/digikam/libdigikamdatabase.so.5.9.0
#1 0x7520c39e in Digikam::CollectionScanner::partialScan(QString
const&) () at /usr/lib/digikam/libdigikamdatabase.so.5.9.0
#2 0x778c70b8 in Digikam::ScanController::run() () at
/usr/lib/digikam/libdigikamgui.so.5.9.0
#3 0x75459c87 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4 0x73f2f164 in start_thread (arg=) at
pthread_create.c:486
ret =
pd =
now =
unwind_buf =
{cancel_jmp_buf = {{jmp_buf = {140736661997312,
-7856654273440063166, 140737488344030, 140737488344031, 140737488344240,
140736661992768, 7856551462427222338, 7856645503036744002}, mask_was_saved =
0}}, priv = {pad = {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0,
canceltype = 0}}}
not_first_call =
#5 0x74f2bdef in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95
...I will try to build digikam with debug symbols...
--
You are receiving this mail because:
You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 caulier.gil...@gmail.com changed: What|Removed |Added CC||caulier.gil...@gmail.com --- Comment #2 from caulier.gil...@gmail.com --- As, Maik said, i just tested with 6.0.0-beta3, and problem is not reproducible here too with this pre-release version... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com --- Comment #1 from Maik Qualmann --- The problem can not be reproduced here. Please try a more recent version of digiKam. If no current version is available for your distribution, please try if the problem is still reproducible with the AppImage from https://www.digikam.org/download/. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 403649] Filesystem changes are not visible in album view
https://bugs.kde.org/show_bug.cgi?id=403649 Lukáš Karas changed: What|Removed |Added Platform|Other |Ubuntu Packages -- You are receiving this mail because: You are watching all bug changes.
