[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416289

caulier.gil...@gmail.com changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #13 from caulier.gil...@gmail.com ---
Thanks for the feedback. Great to see the problem solved under MacOS

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

hmueller  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #12 from hmueller  ---
Perfect, the patch works. No crash any more. Thanks for this very quick
solution!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #11 from caulier.gil...@gmail.com ---
Wait a little bit, compilation is under progress. It must be published in one
hour

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-17 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #10 from hmueller  ---
Unfortunately there was no new build tonight at https://files.kde.org/digikam/
So I can not test it right away.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-16 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #9 from Maik Qualmann  ---
This crash was not specific to OSX and could also be reproduced under Linux,
depending on the tree structure of the bookmarks.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-16 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=416289

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||7.0.0
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||digikam/commit/21ac95e61167
   ||bcf705b46ba6f926e184f69608a
   ||e

--- Comment #8 from Maik Qualmann  ---
Git commit 21ac95e61167bcf705b46ba6f926e184f69608ae by Maik Qualmann.
Committed on 16/01/2020 at 22:05.
Pushed by mqualmann into branch 'master'.

fix delete order from the bookmark nodes
FIXED-IN: 7.0.0

M  +2-2NEWS
M  +4-3core/utilities/geolocation/geoiface/bookmark/bookmarknode.cpp

https://invent.kde.org/kde/digikam/commit/21ac95e61167bcf705b46ba6f926e184f69608ae

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-16 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #7 from Maik Qualmann  ---
Thanks, the backtrace is good, next try tonight.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-16 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #6 from hmueller  ---
Comment on attachment 125167
  --> https://bugs.kde.org/attachment.cgi?id=125167
Crash report 16.01.2020

Tried the new nightly build digiKam-7.0.0-beta2-20200116T073708-MacOS-x86-64.
No success. Sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-16 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #5 from hmueller  ---
Created attachment 125167
  --> https://bugs.kde.org/attachment.cgi?id=125167&action=edit
Crash report 16.01.2020

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-15 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #4 from Maik Qualmann  ---
Git commit 537345be7223394c47c7b41629b2997f706e3bd3 by Maik Qualmann.
Committed on 15/01/2020 at 21:47.
Pushed by mqualmann into branch 'master'.

try to fix crash under OSX

M  +0-1   
core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp
M  +2-1   
core/utilities/geolocation/geoiface/bookmark/gpsbookmarkowner.cpp

https://invent.kde.org/kde/digikam/commit/537345be7223394c47c7b41629b2997f706e3bd3

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-15 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=416289

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #3 from Maik Qualmann  ---
We delete the bookmark nodes to prevent a memory leak. It is possible that we
delete them too early because the view model accesses them again. A
QSharedPointer is not really possible because the bookmark nodes are
automatically deleted when the pointer is deleted. I'll watch it tonight.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #2 from caulier.gil...@gmail.com ---
If i remeber, Maik has touch something in BookmarkManager while Christmas
holidays, but i don't remember what exactly...

MacOs is more sensible than Linux and Windows as i can see.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-15 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=416289

--- Comment #1 from hmueller  ---
I havn't seen this crash on Win10 with latest build, so it might be Mac
specific.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 416289] 7.0.0-beta2 crash when closing Geolocation Editor

2020-01-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416289

caulier.gil...@gmail.com changed:

   What|Removed |Added

  Component|Geolocation |Geolocation-Bookmarks
 CC||caulier.gil...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.