[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-13 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=419744

caulier.gil...@gmail.com changed:

   What|Removed |Added

   Platform|Other   |macOS Disk Images

--- Comment #21 from caulier.gil...@gmail.com ---
Thanks for your feedback

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-13 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #20 from hmueller  ---
I can confirm that geotaging now works as expected.
Tested with: digiKam-7.0.0-beta3-20200413T082140-MacOS-x86-64.dmg
Thanks a lot, Mike!
Holger

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-10 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #19 from Maik Qualmann  ---
Git commit 1177a6f4972e31291f5a60dd8319d3b9e0086427 by Maik Qualmann.
Committed on 11/04/2020 at 05:29.
Pushed by mqualmann into branch 'master'.

only write the metadata to the file if the tag list has been changed

M  +1-1core/utilities/geolocation/geoiface/items/gpsitemcontainer.cpp

https://invent.kde.org/kde/digikam/commit/1177a6f4972e31291f5a60dd8319d3b9e0086427

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-10 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #18 from hmueller  ---
You are right. As soon as I remove the option "Image tags" the file date stays
unchanged. I copied the file before this test and a diff says the old file and
the file with the newer date are identical. If I allow tag write and do add a
tag then diff states a difference in the files (so diff detects changes in
binary files correctly). So once again, I do not understand why the file date
is changed while the file is actually unchanged.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-10 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #17 from Maik Qualmann  ---
You have activated tags writing. Possible reverse geolocation tags are
written/updatetd in the images and change the date.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-10 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #16 from hmueller  ---
Thanks. Just tested it right now. Not setting the option to change the file now
updates correctly the database. But the file date and time still gets modified.
Why does this happen?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=419744

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #15 from caulier.gil...@gmail.com ---
I do it now...

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-09 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #14 from hmueller  ---
Can someone please build the MacOS version of digikam. It wasn't updated since
April 3rd. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-07 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #13 from hmueller  ---
Ok, the note will help.

I will test the again with the new version as soon as it is available and
report the result. Thanks for changing the code so fast!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-06 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #12 from Maik Qualmann  ---
Starting from a new configuration where all metadata write operations are
deactivated and only activated by the user, the previous behavior was an error.
We will include information about this in the release announcement for
digiKam-7.0.0.
I tested again whether the image is changed if the option is deactivated, no it
will not. They may have written geological tags in the image, the setting for
tags and geological information are separate and will be treated as such.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-06 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #11 from hmueller  ---
> Like all other metadata write operations, the default setting is deactivated.

I personally to not like this default setting, as writing these data to the
image was the default before. Without this bug I would not notice this change
and live on in the belief that all my images store the correct location.

Another bug is, that without the write GPS option the image file gets touched
(no change, I made a diff, but file date and time are set to the current) so my
cloud service uploads this file to the server. This confused me in the first
time. This should be avoided imho.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-06 Thread hmueller
https://bugs.kde.org/show_bug.cgi?id=419744

--- Comment #10 from hmueller  ---
Hi Maik,
you are up early! :-)
Just to make it complete. The following options are set (and if not noted here
they are not set):
All options in section "Write This Information to the Metadata".
In "Reading and Writing Metadata"
- Update file modification timestamp when files are modified
- Rescan file when files are modified

The Rescan option did not have had an impact if checked or not.

I will test your change as soon as the Mac version has been compiled and
uploaded.
Holger

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-06 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=419744

Maik Qualmann  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||digikam/commit/ced318151c7b
   ||7d537147805c52d19187ff8b936
   ||a
   Version Fixed In||7.0.0
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #9 from Maik Qualmann  ---
Git commit ced318151c7b7d537147805c52d19187ff8b936a by Maik Qualmann.
Committed on 07/04/2020 at 04:23.
Pushed by mqualmann into branch 'master'.

do not reload metadata under digiKam in the Geolocation Editor
FIXED-IN: 7.0.0

M  +2-1NEWS
M  +5-2   
core/dplugins/generic/metadata/geolocationedit/dialog/geolocationedit.cpp

https://invent.kde.org/kde/digikam/commit/ced318151c7b7d537147805c52d19187ff8b936a

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 419744] 7.0.0-beta3 Geolocation Editor does not save new location

2020-04-06 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=419744

Maik Qualmann  changed:

   What|Removed |Added

Summary|7.0.0-beta2 Geolocation |7.0.0-beta3 Geolocation
   |Editor does not save new|Editor does not save new
   |location|location

-- 
You are receiving this mail because:
You are watching all bug changes.