[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 Maik Qualmann changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Version Fixed In||8.0.0 Latest Commit||https://invent.kde.org/grap ||hics/digikam/commit/41098bf ||120a6fb75ed1754144b9b324b36 ||087cb3 --- Comment #6 from Maik Qualmann --- Git commit 41098bf120a6fb75ed1754144b9b324b36087cb3 by Maik Qualmann. Committed on 13/07/2022 at 20:22. Pushed by mqualmann into branch 'master'. add separate icon for empty and full trash Breeze also knows "trash-empty" but the icon is a bit too "thin" for me. FIXED-IN: 8.0.0 M +2-1NEWS M +22 -0core/libs/album/engine/album.cpp M +5-0core/libs/album/engine/album.h M +14 -2core/libs/album/engine/albumthumbnailloader.cpp M +1-0core/libs/album/engine/albumthumbnailloader.h M +1-10 core/libs/models/albummodel.cpp https://invent.kde.org/graphics/digikam/commit/41098bf120a6fb75ed1754144b9b324b36087cb3 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 Nicofo changed: What|Removed |Added Version|7.8.0 |7.7.0 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 Nicofo changed: What|Removed |Added Version|7.0.0 |7.8.0 Platform|Fedora RPMs |Appimage -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047
--- Comment #5 from Nicofo ---
Additional info:
I think that the Trash icon's name is:
- user-trash (empty trash)
- user-trash-full (full trash)
I searched in the code for "user-trash" -> several matches
I searched in the code for "user-trash-full" -> no match (except in ChangeLog
file)
--> So I guess digikam does not handle different icons for the Trash depending
if it is full or empty.
In the matches for "user-trash", there is albumthumbnailloader.cpp:
QPixmap AlbumThumbnailLoader::getStandardAlbumTrashIcon(RelativeSize
relativeSize)
{
return loadIcon(QLatin1String("user-trash"),
computeIconSize(relativeSize));
}
Maybe should be changed there ?
QPixmap AlbumThumbnailLoader::getStandardAlbumTrashIcon(RelativeSize
relativeSize)
{
if //trash is empty
return loadIcon(QLatin1String("user-trash"),
computeIconSize(relativeSize));
else
return loadIcon(QLatin1String("user-trash-full"),
computeIconSize(relativeSize));
}
--
You are receiving this mail because:
You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 --- Comment #4 from Nicofo --- Hi Gilles and happy new year too ! I tested again -> same result: see attachment in comment #2 Best regards -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 caulier.gil...@gmail.com changed: What|Removed |Added CC||caulier.gil...@gmail.com --- Comment #3 from caulier.gil...@gmail.com --- Hi Nicofo and happy new year, With 7.5.0 we update KF5::Breeze icon to last stable 5.89. Can you double check if the AppImage fix this problem : https://files.kde.org/digikam/ Thanks in advance Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 --- Comment #2 from Nicofo --- Created attachment 130669 --> https://bugs.kde.org/attachment.cgi?id=130669=edit Trash icons Really ? Seems empty to me ;) See printscreen, done with 2 themes (Adwaita and Breeze). - Trash of "Desktop" collection is in fact full - Trash of "Photos" collection is in fact empty - both icons are empty :( -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 425047] Trash icon should reflect if trash is full or empty
https://bugs.kde.org/show_bug.cgi?id=425047 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com --- Comment #1 from Maik Qualmann --- You are wrong it always shows a full trash. ((:-)) The difference between the two Breeze icons is so small that you will be disappointed. You can activate the item counter, then the number of items contained in the trash is also displayed, or a 0 if empty. Maik -- You are receiving this mail because: You are watching all bug changes.
