[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #12 from Maik Qualmann --- Git commit 17dd52d44236204faf6a22fa387591ecc50538fb by Maik Qualmann. Committed on 24/03/2022 at 10:48. Pushed by mqualmann into branch 'master'. add gpx file with child elements to the track unit-test A +78 -0core/tests/geolocation/geoiface/data/gpx-child-elements.gpx M +17 -7core/tests/geolocation/geoiface/tracks_utest.cpp https://invent.kde.org/graphics/digikam/commit/17dd52d44236204faf6a22fa387591ecc50538fb -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #11 from Maik Qualmann --- Yes of course we can add it in a small version of the file as unit-test, I do it. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #10 from caulier.gil...@gmail.com --- Maik, Why not to integrate this GPX file in unit-tests ? Gilles -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #9 from Kristian Karl --- I verified the fix this morning. Looks all good now. Thanks Maik :-) -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 Maik Qualmann changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/digikam/commit/d3ce44e ||9de912b33627235fd910c846599 ||705a19 Status|REPORTED|RESOLVED Version Fixed In||8.0.0 Resolution|--- |FIXED --- Comment #8 from Maik Qualmann --- Git commit d3ce44e9de912b33627235fd910c846599705a19 by Maik Qualmann. Committed on 23/03/2022 at 20:00. Pushed by mqualmann into branch 'master'. fix reading child elements FIXED-IN: 8.0.0 M +2-1NEWS M +1-1core/utilities/geolocation/geoiface/tracks/trackreader.cpp https://invent.kde.org/graphics/digikam/commit/d3ce44e9de912b33627235fd910c846599705a19 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #7 from Maik Qualmann --- Git commit 6280a012ee10a9e588271568ff17aeaf825a1060 by Maik Qualmann. Committed on 23/03/2022 at 19:53. Pushed by mqualmann into branch 'master'. remove dead code and variables M +18 -201 core/utilities/geolocation/geoiface/tracks/trackreader.cpp M +0-17 core/utilities/geolocation/geoiface/tracks/trackreader.h https://invent.kde.org/graphics/digikam/commit/6280a012ee10a9e588271568ff17aeaf825a1060 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #6 from Maik Qualmann --- It's certainly a possibility, but there's an easier way. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802
--- Comment #5 from Kristian Karl ---
Inserting this code after
https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/geolocation/geoiface/tracks/trackreader.cpp#L332
seems to be one solution to the problem.
if (xml.name() == QLatin1String("extensions"))
{
do {
xml.readNext();
}
while (!(xml.tokenType() == QXmlStreamReader::EndElement && xml.name() ==
QLatin1String("extensions")) && !xml.hasError()) ;
continue;
}
Also, I don't think this code is used anymore?
https://invent.kde.org/graphics/digikam/-/blob/master/core/utilities/geolocation/geoiface/tracks/trackreader.cpp#L147-290
--
You are receiving this mail because:
You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 Maik Qualmann changed: What|Removed |Added Version|7.7.0 |8.0.0 -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #4 from Maik Qualmann --- The cause is not Comment 3, I leave the task for our student to solve. Is a nice track. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 --- Comment #3 from Maik Qualmann --- These elements must be added to the QXmlStreamreader as namespace. Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com --- Comment #2 from Maik Qualmann --- The track data contains an "extensions" block the first time reading "gpxtpx:TrackPointExtension" the QXmlStreamReader gives an error QXmlStreamReader::UnexpectedElementError. 21 97 77 Maik -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 caulier.gil...@gmail.com changed: What|Removed |Added CC||quochungtran1...@gmail.com --- Comment #1 from caulier.gil...@gmail.com --- I CC the student who provides the PR on Gitlab. Wait and see... Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.
[digikam] [Bug 451802] GPX files fails to load
https://bugs.kde.org/show_bug.cgi?id=451802 caulier.gil...@gmail.com changed: What|Removed |Added CC||caulier.gil...@gmail.com Version|unspecified |7.7.0 -- You are receiving this mail because: You are watching all bug changes.
