[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-03 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #25 from maderios  ---
Yes, I use sidecars, I never use IPTC and EXIF. Cameras creates EXIF but I
don't need this kind of metadata. 
May be I'm wrong but I think converting IPTC to XMP is useless because Digikam
never ends recreating interaction issue between  XMP and EXIF/IPTC. 
I tested it with 11 images this way:
In images test directory, I deleted .xmp files then, I deleted all images
metadata in this directory :
find . -type f -iname '*.tif' | xargs exiv2 -v -k delete
After launching Digikam, I see metadata have disappeared, good.
Then I tagged my 11 images normally, with XMP settings, only one tag 'animaux'
In metadata editor, all is right in XMP keyword section but  i see tag/keyword
'animaux' is present in IPTC section.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-02 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #24 from Maik Qualmann  ---
I'm guessing you're using sidecars. There is an interaction between XMP and
EXIF/IPTC. Check out the XMP conversion table:

https://exiv2.org/conversion.html

To prevent this, you would have to deactivate the sidecar.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-02 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #23 from maderios  ---
I see the new BQM tool doesn't remove all IPTC metadata
To reproduce:
select tiff image 
In BQM choose remove image IPTC metadata "completely"
remove IPTC 
In metadata editor
item -> edit metadata -> IPTC -> keyword 
One keyword tag is still there. I tested with other images, same issue, each
time, one keyword is not deleted (only one each time)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #22 from maderios  ---
Because the problem comes from IPTC, not using IPTC would be a good thing but i
did not find a way to disable it. Is it possible?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #21 from maderios  ---
Strangely, it keeps metadata now, it works. I don't understand what happened,
sorry for the noise...

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #20 from Maik Qualmann  ---
I can't reproduce it, I used your sample image for testing, XMP remains. Please
test it again.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #19 from maderios  ---
Yes, remove IPTC metadata works in BQM but i see XMP tags are no more displayed
in thumbnail after removing IPTC
To reproduce, in BQM:
Metadata
remove metadata
IPTC/preview image is checked
XMP and exif are not checked

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #18 from Maik Qualmann  ---
The function was just added yesterday, it is Comment 6. In the Metadata Remover
in the IPTC section.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #17 from maderios  ---
(In reply to Maik Qualmann from comment #15)
> As I said, we use the embedded preview image to create the thumbnail. If it
> is not updated by Gimp and other programs, it will display incorrectly. We
> can disable that. But then with large TIFF files created by digKam, the
> creation of new thumbnails will be significantly slower.
Slowness is not a problem if it solves issue
> However, I am of the opinion that the corresponding programs, if a preview
> is available, also have to update it.
Reasonably, I can't report that to Rawtherapee and Gimp upstream, it concerns
Digikam
> 
> With digiKam-8.3.0 you can remove the preview image with the BQM, then
> everything will be correct again.
In BQM/batch queue manager,  I don't see any option or function  to remove the
embedded preview image

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #16 from Maik Qualmann  ---
Another fact is that if programs like Gimp or Rawtherapee do not update the
embedded preview image, you think you have removed sensitive information with a
crop, but it is still in the preview image.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #15 from Maik Qualmann  ---
As I said, we use the embedded preview image to create the thumbnail. If it is
not updated by Gimp and other programs, it will display incorrectly. We can
disable that. But then with large TIFF files created by digKam, the creation of
new thumbnails will be significantly slower.
However, I am of the opinion that the corresponding programs, if a preview is
available, also have to update it.

With digiKam-8.3.0 you can remove the preview image with the BQM, then
everything will be correct again.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-02-01 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #14 from maderios  ---
I get same issue after rotating image with Gimp 2.10. 
Open tiff image in Digikam with Gimp
In Gimp, rotate and save it
New tiff image/rotated/thumbnail is not displayed in Digikam, only original
tiff image/thumbnail is displayed.
Clicking on this new thumbnail/image displays it normally/rotated

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #13 from maderios  ---
I understand what you mean, I have to investigate and may be, report issue
upstream.
Thanks for these explanations

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #12 from Maik Qualmann  ---
Do not you understand? digiKam uses the embedded preview image in the TIFF
image, if it exists, to create thumbnails faster. Rawtherapee removed this
thumbnail in older versions, so digiKam created the thumbnail from the full
TIFF - all good. Now the “old” preview image remains in the TIF, which of
course we then use and the display is not correct.

So either Rawtherapee removes the preview image as before or saves a correct
one.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #11 from maderios  ---
Same issue in Digikam with tiff files cropped with Rawtherapee git version.  
No issue with two file managers, Dolphin 23.08.4-1 and Pcmanfm-Qt  1.4.0.  They
display cropped cropped file/ tiff thumbnails normally. 
It seems bug comes from Digikam

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #10 from Maik Qualmann  ---
I have Rawtherapee 5.9 here, this version removes the IPTC preview, so the
thumbnail in digiKam is correct. If the Rawtherapee git version keeps the IPTC
preview but does not update it, that is a bug.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #9 from maderios  ---
(In reply to caulier.gilles from comment #2)
> TIFF can use special compress algorithm as ZIP. libtiff must be compiled
> with this kind of support (optional). If RawTherapee enable an exotic
> compression method, this is not portable.

Rawtherapee use deflate compression (see the code in my post below)

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread maderios
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #8 from maderios  ---
(In reply to Maik Qualmann from comment #1)
> At the moment I only have the Windows version of digiKam-8.3.0, no problems,
Issue happens with Rawtherapee git version
> both TIFF files have thumbnails and can be opened.
To be clear:
I can open both files and display thumbnails too but Digikam doesn't display
image cropped thumbnail, it displays two same thumbnails, as if one of these
images has not been cropped.  
I tested with Rawtherapee 5.9, issue is not present, cropped image thumbnail is
displayed normally. Something has changed with Rawtherapee git version. 
It seems RT uses deflate  compression
https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/imageio.cc

> 
> Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

Maik Qualmann  changed:

   What|Removed |Added

   Version Fixed In||8.3.0
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Maik Qualmann  ---
The error here is with Rrawtherapee that the IPTC preview image is not updated.
With the last commit you have the option to remove it.
Alternatively, save the image again with the digiKam editor, we update the
preview image.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #6 from Maik Qualmann  ---
Git commit e59b62583ab0cdb48fd76bd5de4e4aca02094b22 by Maik Qualmann.
Committed on 31/01/2024 at 17:51.
Pushed by mqualmann into branch 'master'.

add remove IPTC preview image to the BQM tool

M  +11   -3core/dplugins/bqm/metadata/removemetadata/removemetadata.cpp

https://invent.kde.org/graphics/digikam/-/commit/e59b62583ab0cdb48fd76bd5de4e4aca02094b22

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #5 from Maik Qualmann  ---
If you're concerned about the appearance/size of the cropped image, it's
because there's a preview image included that Rawtherapee hasn't adjusted when
I compare the bytes. Now digiKam uses the preview image for performance reasons
if it is available.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #4 from Maik Qualmann  ---
Both TIFF files are also displayed here under my Linux version. The original is
uncompressed, the cropped is compressed with Adobe Deflate.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #3 from caulier.gil...@gmail.com ---
Look tiff compresion notes in wikipedia page :

https://en.wikipedia.org/wiki/TIFF

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=480606

--- Comment #2 from caulier.gil...@gmail.com ---
TIFF can use special compress algorithm as ZIP. libtiff must be compiled with
this kind of support (optional). If RawTherapee enable an exotic compression
method, this is not portable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=480606

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #1 from Maik Qualmann  ---
At the moment I only have the Windows version of digiKam-8.3.0, no problems,
both TIFF files have thumbnails and can be opened.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 480606] Digikam git doesn't display thumbnails from tif images cropped with Rawtherapee

2024-01-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=480606

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com
  Component|Preview-Image   |Plugin-DImg-TIFF

-- 
You are receiving this mail because:
You are watching all bug changes.