[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=158264

Elvis Angelaccio  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||17.11.80
  Latest Commit||https://commits.kde.org/dol
   ||phin/bd47eb2e6d80315115bb3f
   ||58987162fcb4911b10
 Resolution|--- |FIXED

--- Comment #33 from Elvis Angelaccio  ---
Git commit bd47eb2e6d80315115bb3f58987162fcb4911b10 by Elvis Angelaccio, on
behalf of Miklos Marton.
Committed on 12/10/2017 at 21:21.
Pushed by elvisangelaccio into branch 'master'.

Don't block unmounting when terminal panel's cwd is the mountpoint

When unmounting a removable media Dolphin checks if there are
some files open on the device before performing the unmount.
If the terminal window in dolphin is open and the to be unmounted path is open,
 the unmount process will be blocked.

This patch sets the terminal window current path to the home directory upon
unmount request
 if the terminal directory is set to the mount path.

The unmount request could came from two sources:

The user could hit right click on the media in the dolphin's places panel
and hit unmount.
The user could request an unmount from the indicator applet

This patch was originally written by Arjun AK for the kdelibs4 version
of Dolphin: https://git.reviewboard.kde.org/r/121613/
FIXED-IN: 17.11.80

Differential Revision: https://phabricator.kde.org/D7847

M  +49   -19   src/dolphinmainwindow.cpp
M  +23   -0src/dolphinmainwindow.h
M  +7-0src/panels/places/placesitem.cpp
M  +2-0src/panels/places/placesitem.h
M  +34   -10   src/panels/places/placesitemmodel.cpp
M  +8-2src/panels/places/placesitemmodel.h
M  +12   -0src/panels/places/placesitemsignalhandler.cpp
M  +5-0src/panels/places/placesitemsignalhandler.h
M  +10   -1src/panels/places/placespanel.cpp
M  +3-0src/panels/places/placespanel.h
M  +16   -2src/panels/terminal/terminalpanel.cpp
M  +13   -1src/panels/terminal/terminalpanel.h

https://commits.kde.org/dolphin/bd47eb2e6d80315115bb3f58987162fcb4911b10

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[martonmiklos]

https://bugs.kde.org/show_bug.cgi?id=158264

martonmiklos  changed:

   What|Removed |Added

 CC||martonmiklosq...@gmail.com

--- Comment #32 from martonmiklos  ---
Proposed patch based on Arjun AK's work submitted to the Phabricator:
https://phabricator.kde.org/D7847

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Jerome]

https://bugs.kde.org/show_bug.cgi?id=158264

Jerome  changed:

   What|Removed |Added

 CC||hen...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=158264

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #31 from Nate Graham  ---
Yep, still in Dolphin 16.12.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Alexander Zhigalin]

https://bugs.kde.org/show_bug.cgi?id=158264

Alexander Zhigalin  changed:

   What|Removed |Added

 CC||alexan...@zhigalin.tk
Version|2.1 |16.12.0
   Version Fixed In|4.7.0   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Ritesh Raj Sarraf]

https://bugs.kde.org/show_bug.cgi?id=158264

Ritesh Raj Sarraf  changed:

   What|Removed |Added

 CC|kde-b...@researchut.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 158264] Terminal panel (konsole part) blocks the umount of removable media

[Hauke Laging]

https://bugs.kde.org/show_bug.cgi?id=158264

Hauke Laging  changed:

   What|Removed |Added

 CC||ha...@laging.de

--- Comment #30 from Hauke Laging  ---
This problem still exists in Dolphin 16.08.2 / KDE 5.27.0

-- 
You are receiving this mail because:
You are watching all bug changes.