[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #15 from Méven Car  ---
(In reply to Bill Werrel from comment #14)
> (In reply to Méven Car from comment #13)
> > (In reply to Bill Werrel from comment #12)
> > > The left/right arrow shortcuts for expand/collapse in 23.04.02 work great.
> > 
> > Great to here.
> > 
> > I will close this bug then, feel free to open a new for your new suggestion.
> > 
> > > It would good to also get a short cut for "expand all",
> > 
> > It exists sort-of "Ctrl+A" then "Right" ><
> > 
> > Would you case to suggest a default shortcut?
> 
> ,  does not do what I had in mind. By expand all I mean for
> the currently selected folder, recursively expand all subdirectories below
> it. You could use a shortcut like  or . It would
> probably need a limit on the maximum depth and/or number of files in case
> someone does this on a directory with a huge number of files in the subdirs.
> It could be similar to the Folder Size display depth limit setting.

For that, there is a way, using the keyboard up/down keys to select the folders
you want while holding SHIFT, then while keeping SHIFT held keep pressing right
and the sub-folders selected will expand one level at a time.

You can open a specific bug for that.
I tried to add a specific SHIFT+Right behavior while implementing the fix but
our code can't accommodate this ATM.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Bill Werrel]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #14 from Bill Werrel  ---
(In reply to Méven Car from comment #13)
> (In reply to Bill Werrel from comment #12)
> > The left/right arrow shortcuts for expand/collapse in 23.04.02 work great.
> 
> Great to here.
> 
> I will close this bug then, feel free to open a new for your new suggestion.
> 
> > It would good to also get a short cut for "expand all",
> 
> It exists sort-of "Ctrl+A" then "Right" ><
> 
> Would you case to suggest a default shortcut?

,  does not do what I had in mind. By expand all I mean for the
currently selected folder, recursively expand all subdirectories below it. You
could use a shortcut like  or . It would probably need
a limit on the maximum depth and/or number of files in case someone does this
on a directory with a huge number of files in the subdirs. It could be similar
to the Folder Size display depth limit setting.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=196772

Méven Car  changed:

   What|Removed |Added

   Version Fixed In||https://invent.kde.org/syst
   ||em/dolphin/-/commit/c17e6c8
   ||d2b33d6d62df46025b69cb7b401
   ||f09f62

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=196772

Méven Car  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
 CC||meve...@gmail.com

--- Comment #13 from Méven Car  ---
(In reply to Bill Werrel from comment #12)
> The left/right arrow shortcuts for expand/collapse in 23.04.02 work great.

Great to here.

I will close this bug then, feel free to open a new for your new suggestion.

> It would good to also get a short cut for "expand all",

It exists sort-of "Ctrl+A" then "Right" ><

Would you case to suggest a default shortcut?

> and to make the keyboard shortcuts configurable.

That would be down the road we have a lot of hardcoded shortcut in the view
currently, it won't be easy to change this, meaning requiring a lot of effort
and be error prone.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Bill Werrel]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #12 from Bill Werrel  ---
The left/right arrow shortcuts for expand/collapse in 23.04.02 work great. It
would good to also get a short cut for "expand all", and to make the keyboard
shortcuts configurable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #11 from Méven Car  ---
Git commit c17e6c8d2b33d6d62df46025b69cb7b401f09f62 by Méven Car.
Committed on 26/05/2023 at 16:10.
Pushed by meven into branch 'master'.

Expand or collapse all selected folders on Key Right/Left

M  +27   -8src/kitemviews/kitemlistcontroller.cpp
M  +85   -8src/kitemviews/kitemset.h
M  +5-0src/tests/CMakeLists.txt
A  +235  -0src/tests/kitemlistcontrollerexpandtest.cpp [License:
GPL(v2.0+)]

https://invent.kde.org/system/dolphin/-/commit/c17e6c8d2b33d6d62df46025b69cb7b401f09f62

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/system/dolphin/-/merge_requests/546

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=196772

almbor...@hotmail.com changed:

   What|Removed |Added

 CC||almbor...@hotmail.com

--- Comment #9 from almbor...@hotmail.com ---
I do not understand the logic about not having a shortcut to this feature.
I really think it would be great if it was made with a shortcut available.
I would use this feature multiple times every hour of the work day and to not
have a shortcut to it would not be so nice.

Why shortcuts:
A lot of people have multiple hi resolution screens meaning mouse movement are
on high sensitivity. 
Then to select from a menus many times during a workflow generates more tension
in shoulders and arm because you tense up to do micro movements. Many users
wants therefor to have shortcuts for repetitive tasks to take load of the mouse
arm.
Also in general the less mouse you need to use the less arm and shoulder
fatigue. 

e.g. select the  directory and press 'd',for just showing the directories, to
collapse all sub-directories and perhaps 'f' to expand then (d and f being next
to each other and on the home row. If you use your mouse in the right hand you
do not need to drop it and can directly select the directory you want). Vs
right click the directory then move the mouse to the right place.

This would be nice:
Right click directory opens menu > collapse (show the shortcut-key in the
margin)
Right click directory opens menu > expand (show the shortcut-key in the margin)
Keyboard shortcut for expanding selected directory and none of their children
Keyboard shortcut for expanding selected directory and all of their children
Perhaps for nodes as well. but I do not know what a node is so...

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #8 from p...@free.fr ---
I guess this includes the possibility to expand/collapse ALL folders including
subfolders from the folder we selected first.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=196772

vmel...@yahoo.com changed:

   What|Removed |Added

 CC||vmel...@yahoo.com

--- Comment #7 from vmel...@yahoo.com ---
I would implement this via a popup menu.
In other words, Dolphin would be in tree view mode.
The user right clicks the folder.
A popup menu opens.
Click on Expand This Folder.
or
Click on Collapse This Folder.

I don't think there is a need for a keyboard shortcut for this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Goh Mifune]

https://bugs.kde.org/show_bug.cgi?id=196772

Goh Mifune  changed:

   What|Removed |Added

 CC||gohmif...@gmail.com

--- Comment #6 from Goh Mifune  ---
Throwing in my support for this.

It seems we would need the following:

1. Button to expand selected folders
2. Keyboard shortcut for expanding selected folders and none of their children
3. Keyboard shortcut for expanding selected folders and all of their children
4. Keyboard shortcut for collapsing all selected nodes

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Bill Werrel]

https://bugs.kde.org/show_bug.cgi?id=196772

--- Comment #5 from Bill Werrel  ---
I am also after method of expanding the entire subtree of the selected node. My
preference is for keyboard shortcuts. Something like the '*' (expand all), '+'
(expand one level), '-' (collapse) keys that the old XTree Gold program used
would be nice as they are all next to each other on the numeric keypad and can
be easily operated while navigating through the tree using only the keyboard.

Also, the current keyboard shortcuts (left/right arrow) are not documented in
the Dolphin Handbook.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=196772

Nate Graham  changed:

   What|Removed |Added

 CC||werr...@mail.com

--- Comment #4 from Nate Graham  ---
*** Bug 430729 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Myriam Schweingruber]

https://bugs.kde.org/show_bug.cgi?id=196772

Myriam Schweingruber  changed:

   What|Removed |Added

Version|16.12.2 |20.08.0

--- Comment #3 from Myriam Schweingruber  ---
Bumping the version, this is still asked for

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Reuben]

https://bugs.kde.org/show_bug.cgi?id=196772

Reuben  changed:

   What|Removed |Added

 CC||reube...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=196772

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 196772] Dolphin tree view needs method to expand and collapse all/selected nodes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=196772

Nate Graham  changed:

   What|Removed |Added

Summary|Dolphin tree view needs |Dolphin tree view needs
   |method to expand   |method to expand and
   |all|selected nodes  |collapse all/selected nodes

-- 
You are receiving this mail because:
You are watching all bug changes.