[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=259382

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Version Fixed In||23.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[Serg Podtynnyi]

https://bugs.kde.org/show_bug.cgi?id=259382

Serg Podtynnyi  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/commit/96323e049
   ||c700fcd63d93f00c5b92a8ddfe0
   ||cb27
 Resolution|--- |FIXED

--- Comment #7 from Serg Podtynnyi  ---
Git commit 96323e049c700fcd63d93f00c5b92a8ddfe0cb27 by Serg Podtynnyi.
Committed on 25/01/2023 at 11:37.
Pushed by felixernst into branch 'master'.

Clear filter bar on clicking current folder in places

Reset the filter bar when user clicks on the current folder in places
list, also rename slot function to be more clear.

M  +2-0src/dolphinmainwindow.cpp
M  +6-1src/dolphinviewcontainer.cpp
M  +1-0src/dolphinviewcontainer.h
M  +1-1src/filterbar/filterbar.cpp
M  +1-1src/filterbar/filterbar.h

https://invent.kde.org/system/dolphin/commit/96323e049c700fcd63d93f00c5b92a8ddfe0cb27

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[Serg Podtynnyi]

https://bugs.kde.org/show_bug.cgi?id=259382

Serg Podtynnyi  changed:

   What|Removed |Added

 CC||s...@podtynnyi.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=259382

Kai Uwe Broulik  changed:

   What|Removed |Added

  Flags||Usability?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=259382

sowi...@dukun.de changed:

   What|Removed |Added

 CC||sowi...@dukun.de

--- Comment #5 from sowi...@dukun.de ---
Its technically correct, but not intuitive. For instance by clicking the
home-folder I would expect to get to a sane default, thus no filters selected,
for what other reason would I click this button (regardless if, but especially
when I already am inside). This is clearly only an edge case, but another step
on the road towards perfection.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 259382] Make clicking the current folder in places list reset filter bar

[Thomas Pfeiffer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=259382

Thomas Pfeiffer  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||colo...@autistici.org

--- Comment #6 from Thomas Pfeiffer  ---
I agree with sowi...@dukun.de: Yes, the current behavior is technically
correct, but what's technically correct isn't automatically what users expect.
>From a user perspective, there isn't much difference between clicking on the
current entry on the side bar, or a different one.

Also, why would users click on the folder they're already in if they didn't
expect anything to change?

Therefore the proposed change makes sense. Notice that this does not apply if
the filter is "locked", of course.

-- 
You are receiving this mail because:
You are watching all bug changes.