[dolphin] [Bug 318580] Hide facetsWidget if indexing is turned off and/or folder is not indexed
https://bugs.kde.org/show_bug.cgi?id=318580
Elvis Angelaccio changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Version Fixed In||19.11.80
Latest Commit||https://commits.kde.org/dol
||phin/c144701c28aa02a1fd9e1a
||24460ae9e5178ed069
--- Comment #5 from Elvis Angelaccio ---
Git commit c144701c28aa02a1fd9e1a24460ae9e5178ed069 by Elvis Angelaccio, on
behalf of Ismael Asensio.
Committed on 13/10/2019 at 15:22.
Pushed by elvisangelaccio into branch 'master'.
Hide search extra options when not available
Summary:
Hide the search extra options when they are not available, because the current
location is not indexed or Baloo is not enabled.
The button is disabled and shows a tooltip to provide feedback of why it's not
available.
Depends on D24478
{F7531893}
Related: bug 408680, bug 396898
FIXED-IN: 19.11.80
Test Plan:
- `Ctrl-F` on a non-indexed location
- `balooctl disable` and `Ctrl-F` on an indexed location
On both cases the extra options are not shown, the button is disabled and the
reason is shown in the tooltip
The user selection is remembered between indexed locations.
Reviewers: #dolphin, elvisangelaccio, meven, ngraham
Reviewed By: meven
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24446
M +43 -12 src/search/dolphinsearchbox.cpp
M +1-0src/search/dolphinsearchbox.h
https://commits.kde.org/dolphin/c144701c28aa02a1fd9e1a24460ae9e5178ed069
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 318580] Hide facetsWidget if indexing is turned off and/or folder is not indexed
https://bugs.kde.org/show_bug.cgi?id=318580 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 318580] Hide facetsWidget if indexing is turned off and/or folder is not indexed
https://bugs.kde.org/show_bug.cgi?id=318580 --- Comment #4 from Kai Uwe Broulik --- Yeah I think the patch would still make sense -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 318580] Hide facetsWidget if indexing is turned off and/or folder is not indexed
https://bugs.kde.org/show_bug.cgi?id=318580 Julian Schraner changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- CC||juliquad...@gmail.com --- Comment #3 from Julian Schraner --- This is theoretically still relevant, as the panel is still expanded even though all options are disabled. I'll set the status to CONFIRMED, maybe @broulik could dust off his old patch & submit it for review? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 318580] Hide facetsWidget if indexing is turned off and/or folder is not indexed
https://bugs.kde.org/show_bug.cgi?id=318580 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO --- Comment #2 from Nate Graham --- Is this still relevant? -- You are receiving this mail because: You are watching all bug changes.
