[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Elvis Angelaccio changed: What|Removed |Added Latest Commit|http://commits.kde.org/dolp |https://commits.kde.org/dol |hin/3775ef19eaca057985b92cf |phin/2fd85facf85b39f84eeada |a3716d3c3a1d22f0f |10bcf80060bb72ab51 Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Elvis Angelaccio --- Git commit 2fd85facf85b39f84eeada10bcf80060bb72ab51 by Elvis Angelaccio. Committed on 07/09/2017 at 19:31. Pushed by elvisangelaccio into branch 'master'. Fix DolphinRemoveAction Shift toggling on Wayland QGuiApplication::queryKeyboardModifiers() does not work on Wayland [1]. We don't need it in the first place, since we already know (thanks to the key events) whether Shift has been pressed or released. So we can just pass this information to DolphinRemoveAction::update(). [1]: https://bugreports.qt.io/browse/QTBUG-62786 Differential Revision: https://phabricator.kde.org/D7519 M +2-2src/dolphincontextmenu.cpp M +2-1src/dolphinpart.cpp M +22 -7src/dolphinremoveaction.cpp M +13 -3src/dolphinremoveaction.h https://commits.kde.org/dolphin/2fd85facf85b39f84eeada10bcf80060bb72ab51 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Dr. Chapatin changed: What|Removed |Added CC||yy...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Elvis Angelaccio changed: What|Removed |Added Resolution|FIXED |--- Keywords||wayland Status|RESOLVED|REOPENED --- Comment #7 from Elvis Angelaccio --- Yep, QGuiApplication::queryKeyboardModifiers() doesn't seem to work on Wayland. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #6 from Alexander Mentyu --- This bug reappeared for me in Wayland session. Distribution: KDE neon Developer Edition Unstable Branches KDE Plasma Version: 5.10.90 KDE Frameworks Version: 5.37.0 Qt Version: 5.9.1 Kernel Version: 4.10.0-32-generic -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Elvis Angelaccio changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/dolp ||hin/3775ef19eaca057985b92cf ||a3716d3c3a1d22f0f Version Fixed In||16.08.2 --- Comment #5 from Elvis Angelaccio --- Git commit 3775ef19eaca057985b92cfa3716d3c3a1d22f0f by Elvis Angelaccio. Committed on 21/09/2016 at 16:13. Pushed by elvisangelaccio into branch 'Applications/16.08'. Properly check Shift toggling in DolphinRemoveAction Documentation of QGuiApplication::keyboardModifiers() says that "It should be noted this may not reflect the actual keys held on the input device at the time of calling but rather the modifiers as last reported in one of the above events". Since this method is called in DolphinContextMenu's keyPressEvent() and keyReleaseEvent(), the first time that keyboardModifiers() is called it doesn't report that shift has been pressed. Replacing this method with queryKeyboardModifiers() does the job because the latter doesn't care about the event queue. FIXED-IN: 16.08.2 REVIEW: 128972 M +1-1src/dolphinremoveaction.cpp http://commits.kde.org/dolphin/3775ef19eaca057985b92cfa3716d3c3a1d22f0f -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 --- Comment #4 from Elvis Angelaccio --- Patch up for review: https://git.reviewboard.kde.org/r/128972/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Elvis Angelaccio changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||elvis.angelac...@kde.org --- Comment #3 from Elvis Angelaccio --- I can reproduce, confirming. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Carlos changed: What|Removed |Added CC||carlos.gomez.palacin@gmail. ||com --- Comment #2 from Carlos --- *** Bug 362235 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 354301] Shift key toggles "delete" and "move to trash" entries the wrong order
https://bugs.kde.org/show_bug.cgi?id=354301 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #1 from Wolfgang Bauer --- I can confirm this on openSUSE with the latest dolphin 15.12.2. In short: pressing Shift doesn't toggle "Move to Trash" to "Delete", only *releasing* it again does. Afterwards every press and release toggles, so the behavior is completely opposite to what it should be. -- You are receiving this mail because: You are watching all bug changes.
