[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=354330

Justin Zobel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #15 from Justin Zobel  ---
Can confirm with NTFS partition that it does not scroll to newly named file.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354330

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #14 from Nate Graham  ---
Info was provided; moving back to REPORTED

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #13 from Patrick Silva  ---
Created attachment 132830
  --> https://bugs.kde.org/attachment.cgi?id=132830=edit
reproducible with files located in a ntfs partition

Weirdly I can reproduce this bug with files located in my ntfs partition
but I can't with the ones located in my Home.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #12 from Justin Zobel  ---
Created attachment 132812
  --> https://bugs.kde.org/attachment.cgi?id=132812=edit
Video

Interesting that we're both on KDE Neon Unstable but I can't reproduce. Must be
a setting or configuration option somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #11 from Patrick Silva  ---
I can reproduce with any view mode on neon unstable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Justin]

https://bugs.kde.org/show_bug.cgi?id=354330

Justin  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO
 CC||justin.zo...@gmail.com

--- Comment #10 from Justin  ---
I cannot reproduce on Dolphin 20.08.1, can you please re-test and confirm if
this is still an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=354330

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #9 from Henrik Fehlauer  ---
Ideas for a potential patch: https://phabricator.kde.org/D6312#146843

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #8 from Elvis Angelaccio  ---
I'm leaving this bug open because there is still a corner case not fixed by the
above patch:

1. rename something so that it goes out of the view
2. dolphin scrolls the view
3. press CTRL+Z
4. dolphin should scroll the view back to the original place but it doesn't.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #7 from Elvis Angelaccio  ---
Git commit 478f404b8abf924a0e3e21bbf1dd49aefbe47672 by Elvis Angelaccio, on
behalf of Emirald Mateli.
Committed on 17/09/2017 at 09:12.
Pushed by elvisangelaccio into branch 'Applications/17.08'.

Keep renamed file(s) in view

When renaming a file, if its new name causes it to scroll out of view,
Dolphin will not scroll to the location of the new file.
This patch aims to address that. This affects all view modes.

Test Plan:
1. Have many files in a directory (or several files, just zoom in a lot)
2. Rename a file so that it will move out of view

Differential Revision: https://phabricator.kde.org/D6312

M  +19   -3src/views/dolphinview.cpp
M  +9-0src/views/dolphinview.h
M  +9-0src/views/renamedialog.cpp
M  +4-0src/views/renamedialog.h

https://commits.kde.org/dolphin/478f404b8abf924a0e3e21bbf1dd49aefbe47672

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #6 from Nate Graham  ---
Fair enough, I withdraw my objection.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=354330

Elvis Angelaccio  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

--- Comment #5 from Elvis Angelaccio  ---
Reopening, this should be properly discussed before a wontfix. (see my comment
in D6312)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354330

--- Comment #4 from Nate Graham  ---
FWIW, there is a patch for this: https://phabricator.kde.org/D6312

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354330

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Nate Graham  ---
There are lots of legit usability reasons why you might *not* want this. For
example, if you're renaming multiple files in such a manner that they will be
re-sorted elsewhere, after each one your view will change, making the
multiple-file-rename operation an infuriating experience. macOS finder behaved
this way for many years and Apple got a lot of complaints about it, eventually
reverting the behavior to match what Dolphin does today.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=354330

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=354330

Elvis Angelaccio  changed:

   What|Removed |Added

  Component|view-engine: compact mode   |view-engine: general
Version|16.08.3 |17.08.0
 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=354330

Dr. Chapatin  changed:

   What|Removed |Added

 CC||yy...@gmx.com

--- Comment #2 from Dr. Chapatin  ---
Annoying usability problem...

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nathan Shearer]

https://bugs.kde.org/show_bug.cgi?id=354330

Nathan Shearer  changed:

   What|Removed |Added

 CC||k...@nathanshearer.ca

--- Comment #1 from Nathan Shearer  ---
Still exists in Dolphin 16.08.3

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 354330] Renaming a file does not scroll to the selected file

[Nathan Shearer]

https://bugs.kde.org/show_bug.cgi?id=354330

Nathan Shearer  changed:

   What|Removed |Added

   Severity|minor   |normal
Version|unspecified |16.08.3
   Platform|Other   |Gentoo Packages
  Component|file list view  |view-engine: compact mode
Product|konqueror   |dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.