[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #35 from Martin Sandsmark --- > Also the backtraces above don't mention anything related to > KOverlayIconPlugin. I think that killing the preview job triggers the crash, > because the job emits a signal although kill should not emit anything. All the backtraces I can see point at «overlays.append(it->getOverlays(item.url()));» in src/kitemviews/kfileitemmodelrolesupdater.cpp. Which backtraces are you referring to? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #34 from Emmanuel Pescosta --- (In reply to Martin Sandsmark from comment #32) > Do you have any other plugins installed? No I don't have any plugins installed that are KOverlayIconPlugin based. Also the backtraces above don't mention anything related to KOverlayIconPlugin. I think that killing the preview job triggers the crash, because the job emits a signal although kill should not emit anything. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Martin Sandsmark changed: What|Removed |Added Latest Commit|http://commits.kde.org/dolp |http://commits.kde.org/dolp |hin/b1471bbd09d88da3ffe8159 |hin/bed16191b5e9253d8658c0d |075b3108bf9586220 |ac0d336b3dab5e0e3 --- Comment #33 from Martin Sandsmark --- Git commit bed16191b5e9253d8658c0dac0d336b3dab5e0e3 by Martin T. H. Sandsmark. Committed on 21/05/2016 at 16:16. Pushed by sandsmark into branch 'Applications/16.04'. Fix crash when closing split view with ownCloud plugin loaded KPluginLoader::instantiatePlugins() wraps QPluginLoader::instace(), which doesn't return a new object for each call, so if we set the KFileItemModelRolesUpdater instance as parent to the plugin the shared instance will be deleted leading to crashes when other instances of KFileItemModelRolesUpdater tries to use their plugin objects. To fix this, set the QApplication as a parent. REVIEW: 127930 M +1-1src/kitemviews/kfileitemmodelrolesupdater.cpp http://commits.kde.org/dolphin/bed16191b5e9253d8658c0dac0d336b3dab5e0e3 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #32 from Martin Sandsmark --- (In reply to Emmanuel Pescosta from comment #30) > This is a different bug, because I don't have anything Owcloud-related > installed on my system, but I can also trigger a crash when closing the > split view sometimes. Do you have any other plugins installed? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Martin Sandsmark changed: What|Removed |Added Latest Commit||http://commits.kde.org/dolp ||hin/b1471bbd09d88da3ffe8159 ||075b3108bf9586220 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #31 from Martin Sandsmark --- Git commit b1471bbd09d88da3ffe8159075b3108bf9586220 by Martin T. H. Sandsmark. Committed on 21/05/2016 at 16:11. Pushed by sandsmark into branch 'master'. Fix crash when closing split view with ownCloud plugin loaded KPluginLoader::instantiatePlugins() wraps QPluginLoader::instace(), which doesn't return a new object for each call, so if we set the KFileItemModelRolesUpdater instance as parent to the plugin the shared instance will be deleted leading to crashes when other instances of KFileItemModelRolesUpdater tries to use their plugin objects. To fix this, set the QApplication as a parent. REVIEW: 127930 M +1-1src/kitemviews/kfileitemmodelrolesupdater.cpp http://commits.kde.org/dolphin/b1471bbd09d88da3ffe8159075b3108bf9586220 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479
--- Comment #30 from Emmanuel Pescosta ---
(In reply to Martin Sandsmark from comment #24)
> the problem is that the owncloud plugin is destroyed (twice?) when the split
> is closed.
>
> QString pluginName =
> QString::fromLocal8Bit(plugin->metaObject()->className()) + " " +
> plugin->objectName();
> connect(plugin, &QObject::destroyed, [=](QObject *obj) {
> qWarning() << pluginName << obj << "destroyed";
> });
>
> gives:
>
> "OwncloudDolphinPlugin " QObject(0x190a040) destroyed
> "OwncloudDolphinPlugin " QObject(0x190a040) destroyed
Thanks for debugging the problem! :)
This is a different bug, because I don't have anything Owcloud-related
installed on my system, but I can also trigger a crash when closing the split
view sometimes.
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #29 from Lukasz --- Works for me to, thanks. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #28 from Martin Sandsmark --- Up for review: https://git.reviewboard.kde.org/r/127930/ -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #27 from Elvis Angelaccio --- (In reply to Martin Sandsmark from comment #26) > Created attachment 98990 [details] > possible fix > > This should fix it. > > The problem is that instantiatePlugin() only returns a new object if the old > one is deleted, so we shouldn't expect it to create a new one for every call. Works for me. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #26 from Martin Sandsmark --- Created attachment 98990 --> https://bugs.kde.org/attachment.cgi?id=98990&action=edit possible fix This should fix it. The problem is that instantiatePlugin() only returns a new object if the old one is deleted, so we shouldn't expect it to create a new one for every call. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479
--- Comment #25 from Martin Sandsmark ---
... and the reason is that the KFileItemModelRolesUpdater for both splits get
the same OwncloudDolphinPlugin object from
«KPluginLoader::instantiatePlugins(QStringLiteral("kf5/overlayicon"), nullptr,
this);» the first two times it is called:
KFileItemModelRolesUpdater(0x1bde1a0) Creating "OwncloudDolphinPlugin "
OwncloudDolphinPlugin(0x1cb9420)
(open split)
KFileItemModelRolesUpdater(0x20e7f90) Creating "OwncloudDolphinPlugin "
OwncloudDolphinPlugin(0x1cb9420)
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479
Martin Sandsmark changed:
What|Removed |Added
CC||martin.sandsm...@kde.org
--- Comment #24 from Martin Sandsmark ---
the problem is that the owncloud plugin is destroyed (twice?) when the split is
closed.
QString pluginName =
QString::fromLocal8Bit(plugin->metaObject()->className()) + " " +
plugin->objectName();
connect(plugin, &QObject::destroyed, [=](QObject *obj) {
qWarning() << pluginName << obj << "destroyed";
});
gives:
"OwncloudDolphinPlugin " QObject(0x190a040) destroyed
"OwncloudDolphinPlugin " QObject(0x190a040) destroyed
--
You are receiving this mail because:
You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #23 from Antonio Rojas --- (In reply to Elvis Angelaccio from comment #22) > (In reply to Antonio Rojas from comment #21) > > I'm getting the same crash with the owncloud plugin disabled. > > What do you mean with disabled? Do you have owncloud-client installed? > > (I'm not sure this plugin can be disabled in the Services page of the > settings dialog) Right, sorry. It seems the checkbox only disables the context menu, not the autial plugin. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #22 from Elvis Angelaccio --- (In reply to Antonio Rojas from comment #21) > I'm getting the same crash with the owncloud plugin disabled. What do you mean with disabled? Do you have owncloud-client installed? (I'm not sure this plugin can be disabled in the Services page of the settings dialog) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Antonio Rojas changed: What|Removed |Added CC||aro...@archlinux.org --- Comment #21 from Antonio Rojas --- I'm getting the same crash with the owncloud plugin disabled. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||ogoff...@kde.org --- Comment #20 from Elvis Angelaccio --- After some more digging, I found out that the bug is triggered by the Owncloud's overlay plugin [1], which is why not everyone can reproduce this crash. I uninstalled the owncloud-client and the bug was gone. I'm adding Olivier in CC, who added the plugin in commit 800d5114 [2] and maybe can help us to understand whether the bug is in Dolphin or in Owncloud. [1]: on my system: /usr/lib/qt/plugins/kf5/overlayicon/ownclouddolphinoverlayplugin.so [2]: https://quickgit.kde.org/?p=dolphin.git&a=commit&h=800d5114cb1a9b7d5c874f382cc831b4f142469b -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #19 from Elvis Angelaccio --- Created attachment 98830 --> https://bugs.kde.org/attachment.cgi?id=98830&action=edit Weng's backtrace (duplicate #361946) The Weng's backtrace in duplicate #361946 is more detailed, it looks like the crash happens when appending to the 'overlays' stringlist? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||wen...@gmail.com --- Comment #18 from Elvis Angelaccio --- *** Bug 361946 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||kde-b...@kristiankoch.com --- Comment #17 from Elvis Angelaccio --- *** Bug 362500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||m_loui...@yahoo.com --- Comment #16 from Elvis Angelaccio --- *** Bug 362506 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #15 from Kay Simon --- Still on 16.04 KDE Frameworks 5.21.0 Qt 5.6.0 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 cpon changed: What|Removed |Added CC||cpigat...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Lukasz changed: What|Removed |Added CC||dolo...@outlook.com --- Comment #14 from Lukasz --- Created attachment 98299 --> https://bugs.kde.org/attachment.cgi?id=98299&action=edit stracktrace with debug symbols Still on 15.12.3 I will try to dig a little bit by myself. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Christoph Feck changed: What|Removed |Added CC||dopazo.alv...@gmail.com --- Comment #13 from Christoph Feck --- *** Bug 361383 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Kay Simon changed: What|Removed |Added CC||kayingosi...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Dimitris Kardarakos changed: What|Removed |Added CC||dimk...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #11 from Emmanuel Pescosta --- (In reply to Emmanuel Pescosta from comment #10) > (In reply to Elvis Angelaccio from comment #7) > > Any news on this? I tried to have a look at the code, but without success. > > If you can point me in the right direction, I can try again and hopefully > > submit a patch... > > Sorry for the late reply. > > Can you please try if the attached patch fixes the crash? Hmm the failed signal was the problem (I should re-read the back-trace before I try to fix it, my memory was wrong :/) Ok this patch will not help, I'll debug it this weekend. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #10 from Emmanuel Pescosta --- (In reply to Elvis Angelaccio from comment #7) > Any news on this? I tried to have a look at the code, but without success. > If you can point me in the right direction, I can try again and hopefully > submit a patch... Sorry for the late reply. Can you please try if the attached patch fixes the crash? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #9 from Emmanuel Pescosta --- Created attachment 97929 --> https://bugs.kde.org/attachment.cgi?id=97929&action=edit Possible fix -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #12 from Elvis Angelaccio --- (In reply to Emmanuel Pescosta from comment #11) > (In reply to Emmanuel Pescosta from comment #10) > > (In reply to Elvis Angelaccio from comment #7) > > > Any news on this? I tried to have a look at the code, but without success. > > > If you can point me in the right direction, I can try again and hopefully > > > submit a patch... > > > > Sorry for the late reply. > > > > Can you please try if the attached patch fixes the crash? > > Hmm the failed signal was the problem (I should re-read the back-trace > before I try to fix it, my memory was wrong :/) > Ok this patch will not help, I'll debug it this weekend. Yep, unfortunately does not fix the crash. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||k...@openmailbox.org --- Comment #8 from Elvis Angelaccio --- *** Bug 358015 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #7 from Elvis Angelaccio --- Any news on this? I tried to have a look at the code, but without success. If you can point me in the right direction, I can try again and hopefully submit a patch... -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #6 from Emmanuel Pescosta --- (In reply to Emmanuel Pescosta from comment #5) > (In reply to Elvis Angelaccio from comment #4) > > Created attachment 96680 [details] > > valgrind log > > > > Valgrind log, I hope that will be more useful than my previous backtrace. > > Thanks for the really helpful valgrind log :) > The problem is that KFileItemModelRolesUpdater doesn't kill all running > preview jobs on destruction. Ok update -> correctly kill -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Emmanuel Pescosta changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC||emmanuelpescosta099@gmail.c ||om Ever confirmed|0 |1 --- Comment #5 from Emmanuel Pescosta --- (In reply to Elvis Angelaccio from comment #4) > Created attachment 96680 [details] > valgrind log > > Valgrind log, I hope that will be more useful than my previous backtrace. Thanks for the really helpful valgrind log :) The problem is that KFileItemModelRolesUpdater doesn't kill all running preview jobs on destruction. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #4 from Elvis Angelaccio --- Created attachment 96680 --> https://bugs.kde.org/attachment.cgi?id=96680&action=edit valgrind log Valgrind log, I hope that will be more useful than my previous backtrace. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #3 from Elvis Angelaccio --- Weird, I cannot reproduce it on a openSUSE live system (tumbleweed, dolphin 15.12). However, I can reproduce it every time here on archlinux. Very annoying, because it feels like dolphin randomly crashes. For instance, as soon as Firefox finished to download the above opensuse ISO, dolphin crashed with the very same backtrace. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 --- Comment #2 from Elvis Angelaccio --- Created attachment 96668 --> https://bugs.kde.org/attachment.cgi?id=96668&action=edit Backtrace, no debug symbols I'm attaching the backtrace I get, but I don't have debug symbols so it won't be that useful. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 357479] crash if I close the splitscreen while focused on it and then change the view
https://bugs.kde.org/show_bug.cgi?id=357479 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kdemail.ne ||t --- Comment #1 from Elvis Angelaccio --- Same bug here, also on Archlinux starting from 15.12 release. I also found another way to reproduce the crash (the backtrace looks the same): 1. Open the split view 2. Close the split view 3. Reload (F5) -> Crash -- You are receiving this mail because: You are watching all bug changes.
