[dolphin] [Bug 362593] allow terminal to be placed in right pane

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362593

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/dol
   ||phin/108e10ca15be6662fa02f5
   ||6665cc78808ab243e7
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Nate Graham  ---
Git commit 108e10ca15be6662fa02f56665cc78808ab243e7 by Nathaniel Graham.
Committed on 31/01/2018 at 00:06.
Pushed by ngraham into branch 'Applications/17.12'.

Let the terminal panel dock to any part of the window

Summary:

Just what it says: Let the terminal panel sit on the left or right side of the
window.

Test Plan:
Tested in KDE Neon:
- Opened terminal panel, unlocked widgets, and tried to drag it to the right or
left side of the window: I can
- Put terminal panel on right side, quit Dolphin and opened Dolphin again:
terminal panel appears on the right as expected
- Put terminal panel on right side, closed terminal panel, quit Dolphin, opened
Dolphin, and opened the terminal panel again: terminal panel appears on the
right as expected
- Removed dolphinrc file and opened terminal panel: appears on the bottom

{F5682428}

Reviewers: #dolphin

Subscribers: elvisangelaccio, anthonyfieroni, cfeck

Differential Revision: https://phabricator.kde.org/D10189

M  +0-1src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/108e10ca15be6662fa02f56665cc78808ab243e7

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 362593] allow terminal to be placed in right pane

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362593

--- Comment #4 from Nate Graham  ---
Submitted a slightly different patch that accomplishes the same thing:
https://phabricator.kde.org/D10189

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 362593] allow terminal to be placed in right pane

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362593

--- Comment #3 from Nate Graham  ---
Wow, a trivial change. Wanna submit it as a patch on
https://phabricator.kde.org/?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 362593] allow terminal to be placed in right pane

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362593

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 362593] allow terminal to be placed in right pane

[Rog131 via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362593

Rog131  changed:

   What|Removed |Added

 CC||samrog...@hotmail.com

--- Comment #2 from Rog131  ---
(In reply to web from comment #1)
> If not...
> Could I simply change the lines I linked to and compile it myself?
> I've never compiled something before, so I want to make sure this would
> actually fix it before I venture down that rabbit hole :)

Seems to work - a quick test:
https://www.kubuntuforums.net/showthread.php?70192-Dolphin-allow-terminal-to-be-placed-to-the-left-right-top-bottom=388040#post388040

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 362593] allow terminal to be placed in right pane

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362593

--- Comment #1 from w...@ahill.io ---
Is there any chance this will be changed in official Dolphin code?

If not...
Could I simply change the lines I linked to and compile it myself?
I've never compiled something before, so I want to make sure this would
actually fix it before I venture down that rabbit hole :)

-- 
You are receiving this mail because:
You are watching all bug changes.