[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 KDE Neon user changed: What|Removed |Added Version|16.12.2 |17.04.2 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 --- Comment #2 from Nate Graham --- Did some investigation. This is because baloo reports the type for ISOs as "raw CD image", and elsewhere when determining types, baloo is hardcoded to treat anything with the string "image" in it as an image. Here's a patch that fixes it: https://phabricator.kde.org/D7948 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/bal ||oo/db30f89f1c88fd3cf52e9df9 ||5c8411be69275a71 Resolution|--- |FIXED --- Comment #3 from Nate Graham --- Git commit db30f89f1c88fd3cf52e9df95c8411be69275a71 by Nathaniel Graham. Committed on 23/09/2017 at 13:58. Pushed by ngraham into branch 'master'. Only match real MIME types, not e.g. "raw CD image" Summary: Only match real MIME types when doing string matching to prevent pulling in unrelated files whose types match the string. This prevents weird situations such as ISO files (which show up as "raw CD image") appearing in image searches. Test Plan: - Confirmed at www.mime-type.net/ that all audio, video, and image MIME types have the key word before the slash (e.g. "image/") - Booted a clean KDE Neon VM and added an ISO and a bunch of pictures of various types - Confirmed the problem: `baloosearch -t image iso` shows ISO files - Patched and rebuilt Baloo - Forced a re-index operation (balooctl disable; rm ~/.local/share/baloo/index*; balooctl enable) - Did a new image search (`baloosearch -t image iso`) and confirmed that the ISO does not show up - Confirmed that other images still show up Reviewers: #frameworks, nicolasfella, dfaure, kossebau, vhanda Reviewed By: dfaure Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D7948 M +5-5src/file/basicindexingjob.cpp https://commits.kde.org/baloo/db30f89f1c88fd3cf52e9df95c8411be69275a71 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #1 from Nate Graham --- Heh, whoops. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Dr. Chapatin changed: What|Removed |Added CC||yy...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 --- Comment #2 from Nate Graham --- Did some investigation. This is because baloo reports the type for ISOs as "raw CD image", and elsewhere when determining types, baloo is hardcoded to treat anything with the string "image" in it as an image. Here's a patch that fixes it: https://phabricator.kde.org/D7948 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/bal ||oo/db30f89f1c88fd3cf52e9df9 ||5c8411be69275a71 Resolution|--- |FIXED --- Comment #3 from Nate Graham --- Git commit db30f89f1c88fd3cf52e9df95c8411be69275a71 by Nathaniel Graham. Committed on 23/09/2017 at 13:58. Pushed by ngraham into branch 'master'. Only match real MIME types, not e.g. "raw CD image" Summary: Only match real MIME types when doing string matching to prevent pulling in unrelated files whose types match the string. This prevents weird situations such as ISO files (which show up as "raw CD image") appearing in image searches. Test Plan: - Confirmed at www.mime-type.net/ that all audio, video, and image MIME types have the key word before the slash (e.g. "image/") - Booted a clean KDE Neon VM and added an ISO and a bunch of pictures of various types - Confirmed the problem: `baloosearch -t image iso` shows ISO files - Patched and rebuilt Baloo - Forced a re-index operation (balooctl disable; rm ~/.local/share/baloo/index*; balooctl enable) - Did a new image search (`baloosearch -t image iso`) and confirmed that the ISO does not show up - Confirmed that other images still show up Reviewers: #frameworks, nicolasfella, dfaure, kossebau, vhanda Reviewed By: dfaure Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D7948 M +5-5src/file/basicindexingjob.cpp https://commits.kde.org/baloo/db30f89f1c88fd3cf52e9df95c8411be69275a71 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #1 from Nate Graham --- Heh, whoops. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 Dr. Chapatin changed: What|Removed |Added CC||yy...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 364884] Dolphin displays ISO (disk image) file among results for "Search for: Images" pane
https://bugs.kde.org/show_bug.cgi?id=364884 KDE Neon user changed: What|Removed |Added Version|16.12.2 |17.04.2 -- You are receiving this mail because: You are watching all bug changes.
