[dolphin] [Bug 368418] Add audio -> "Bitrate" column to Details view mode

2017-09-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368418

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/dol
   ||phin/76698ff82cf5e88c1ea2e0
   ||686ce7450cf558af97
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Git commit 76698ff82cf5e88c1ea2e0686ce7450cf558af97 by Nate Graham.
Committed on 22/09/2017 at 04:56.
Pushed by ngraham into branch 'master'.

Add Bitrate to Dolphin's Additional Information

Summary:
Adds Bitrate to Dolphin's Additional information columns.

Test Plan:
Tested in KDE Neon. A bitrate column can be added and shows the bitrate in
kb/s:

{F3907210}

Works for audio as well as video files!

Reviewers: #dolphin, #kde_applications, broulik, aacid, dfaure, emmanuelp

Reviewed By: #dolphin, #kde_applications, emmanuelp

Subscribers: rkflx, alexeymin, anthonyfieroni

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D7763

M  +1-0src/kitemviews/kfileitemmodel.cpp
M  +1-1src/kitemviews/kfileitemmodel.h
M  +13   -0src/kitemviews/private/kbaloorolesprovider.cpp
M  +6-0src/kitemviews/private/kbaloorolesprovider.h

https://commits.kde.org/dolphin/76698ff82cf5e88c1ea2e0686ce7450cf558af97

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> "Bitrate" column to Details view mode

2017-09-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368418

--- Comment #2 from Nate Graham  ---
Submitted a patch: https://phabricator.kde.org/D7763

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> "Bitrate" column to Details view mode

2017-09-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368418

--- Comment #1 from Nate Graham  ---
The appropriate string in kbalooroledprovider.cpp is bitRate. This works using
the expected diff, but the column will express the bitrate using an integer
("193000") instead of a more nicely-formatted string like "193.0 kB/s". Take a
look at KBalooRolesProvider::durationFromValue() at the bottom of the file for
an idea of how to format the string nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> "Bitrate" column to Details view mode

2017-09-04 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=368418

Dr. Chapatin  changed:

   What|Removed |Added

 CC||yy...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> "Bitrate" column to Details view mode

2017-09-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368418

Nate Graham  changed:

   What|Removed |Added

Summary|Add audio -> bitrate column |Add audio -> "Bitrate"
   |to "Details" view mode  |column to Details view mode

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> bitrate column to "Details" view mode

2017-09-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=368418

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 368418] Add audio -> bitrate column to "Details" view mode

2017-06-14 Thread KDE Neon user
https://bugs.kde.org/show_bug.cgi?id=368418

KDE Neon user  changed:

   What|Removed |Added

Summary|Add audio -> bitrate column |Add audio -> bitrate column
   |to detais mode  |to "Details" view mode

-- 
You are receiving this mail because:
You are watching all bug changes.