[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=434617

Elvis Angelaccio  changed:

   What|Removed |Added

   Version Fixed In||21.04
 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-28 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

Kwon-Young Choi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/sdk/
   ||dolphin-plugins/commit/f136
   ||702d2adc8643ea12f1b6e3bf979
   ||25f1b33f0
 Status|ASSIGNED|RESOLVED

--- Comment #12 from Kwon-Young Choi  ---
Git commit f136702d2adc8643ea12f1b6e3bf97925f1b33f0 by Kwon-Young Choi.
Committed on 28/03/2021 at 07:03.
Pushed by elvisangelaccio into branch 'release/21.04'.

BackingFile property should be use with StorageVolume instead of StorageAccess

When mounting an iso with `udisksctl`, first a loop device is created
`/dev/loop0` then a second device `/dev/loop0p1` is used to mount it on
a filesystem location.

Querying for StorageAccess devices sometimes only returns the `/dev/loop0p1`
device without the `/dev/loop0` device and the BackingFile property does not
work on `/dev/loop0p1`.

Solution: query for StorageVolume instead which returns all loop devices:
`/dev/loop0` and `/dev/loop1`.

Warning: Because StorageVolume returns more devices, the function
`getDeviceFromBackingFile` could be a little bit slower.

M  +1-1mountiso/mountisoaction.cpp

https://invent.kde.org/sdk/dolphin-plugins/commit/f136702d2adc8643ea12f1b6e3bf97925f1b33f0

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #11 from Kwon-Young Choi  ---
(In reply to Nate Graham from comment #10)
> Not fixed yet since that merge request hasn't been merged. :)

Yes, my bad...

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=434617

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=434617

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||n...@kde.org
 Resolution|FIXED   |---

--- Comment #10 from Nate Graham  ---
Not fixed yet since that merge request hasn't been merged. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

Kwon-Young Choi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #9 from Kwon-Young Choi  ---
So I believed I know what is wrong, I've created a merge request
https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/28 which should
solve this.

(In reply to popov895 from comment #7)
> And just a question: should the mounted ISO images be shown in the "Disk &
> Devices" widget as well?

It's shown in the non-removable devices which by default is not visible.
You can change the view in the hamburger menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=434617

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/28

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #7 from popov895  ---
And just a question: should the mounted ISO images be shown in the "Disk &
Devices" widget as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

Kwon-Young Choi  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1
 Status|NEEDSINFO   |CONFIRMED

--- Comment #6 from Kwon-Young Choi  ---
Well, until now with the iso I tested with, it worked.

But I can reproduce your issue, so let me debug this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #5 from popov895  ---
Just checked the latest neon ISO image, same result. Does this feature work
well on your system?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #4 from popov895  ---
Created attachment 136846
  --> https://bugs.kde.org/attachment.cgi?id=136846&action=edit
`solid-hardware5` output

I put the output in one file. As you can see, all the "BackingFile" properties
are the same. You can download this ISO image from here:
https://drive.google.com/file/d/1xNMkFOCui8OSjOlS_nzip63uQpnRCgHt/view?usp=sharing

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

Kwon-Young Choi  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #3 from Kwon-Young Choi  ---
Ok, so just to be sure, what is the output of:

* `solid-hardware5 nonportableinfo
/org/freedesktop/UDisks2/block_devices/loop0`
* `solid-hardware5 nonportableinfo
/org/freedesktop/UDisks2/block_devices/loop1`
* `solid-hardware5 nonportableinfo
/org/freedesktop/UDisks2/block_devices/loop2`

If all the `BackingFile` properties are the same, I don't know what is
happening, and I'm going to need your iso so that I can try to reproduce this
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #2 from popov895  ---
Created attachment 136843
  --> https://bugs.kde.org/attachment.cgi?id=136843&action=edit
`udisksctl dump` output

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread Kwon-Young Choi
https://bugs.kde.org/show_bug.cgi?id=434617

--- Comment #1 from Kwon-Young Choi  ---
Hello,

It seems the detection of the mounting of the iso is not working.
Could you provide the output of `udiskctl dump` when you have mounted the iso
multiple times?

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 434617] It's possible to mount the same ISO image multiple times

2021-03-19 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=434617

popov895  changed:

   What|Removed |Added

 CC||popov...@ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.