[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #16 from Patrick Silva --- ok, thanks for your quick reply Harald. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #15 from Harald Sitter --- (In reply to Patrick Silva from comment #12) > Is this intentional? That is my understanding from https://invent.kde.org/system/dolphin/-/merge_requests/78 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #14 from Patrick Silva --- Created attachment 137832 --> https://bugs.kde.org/attachment.cgi?id=137832=edit Dolphin 20.12.3 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #13 from Patrick Silva --- Created attachment 137831 --> https://bugs.kde.org/attachment.cgi?id=137831=edit built 21.04 branch -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #12 from Patrick Silva --- I have built 21.04 branch on Arch Linux, now padding in Places panel with small icon size always (even with a new dolphinrc file) looks similar to what we can see in screenshot from comment 1. Is this intentional? I prefer the Places panel seen in the screenshot of Dolphin 20.12.3 but I can live with more padding if it is intentional. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 Nate Graham changed: What|Removed |Added Version Fixed In||21.04.1 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 Harald Sitter changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/syst ||em/dolphin/commit/56888a567 ||fc741713b6c905aeed3842a7fa2 ||30c7 Status|ASSIGNED|RESOLVED --- Comment #11 from Harald Sitter --- Git commit 56888a567fc741713b6c905aeed3842a7fa230c7 by Harald Sitter. Committed on 19/04/2021 at 16:07. Pushed by sitter into branch 'release/21.04'. fix padding in places view padding was only applied when the icon size was applied, the icon size however is only applied when the user had set an explicit size. this resulted in inconsistent spacing. by default no padding would be used if the user had changed the icon size to medium and back to small it would suddenly have padding. to fix this, set padding unconditionally on construction and never touch it again . M +5-1src/panels/places/placesview.cpp https://invent.kde.org/system/dolphin/commit/56888a567fc741713b6c905aeed3842a7fa230c7 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #10 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/197 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #9 from Nate Graham --- Will do. :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #8 from Harald Sitter --- I can, if you do the QA on it... it'd be the much more annoying bit :P -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #7 from Nate Graham --- Thanks for the investigation, Harald? I don't suppose you would be interested in submitting a little MR to fix it? :) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 Harald Sitter changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||sit...@kde.org --- Comment #6 from Harald Sitter --- https://invent.kde.org/system/dolphin/-/commit/e9a39700fc004004b1ff231023e9d5333a2b8317 The padding is only applied IFF an explicit size has been set, and the way the settings behave is that when you go to medium and then small it will not remove the explicit size but set it to 16 (which honestly is a bit of a bug in of itself). i.e. a "new" dolphinrc is not the same as a dolphinrc that changed the size at least once. If you remove your dolphinrc and start from a clean state the bug should be reproducible. Once you switched back to Small the config contains: [PlacesPanel] IconSize=16 Which then triggers the PlacesView::setIconSize call which then inject artificial padding forever more. The problem here really is that the commit I linked to is wrong. It shouldn't set the padding in the setIconSize, it should set it in the constructor. The padding never changes, there is no reason for it to be set over and over again to the same value. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #5 from Patrick Silva --- Weird. I can even reproduce with Dolphin 21.04 RC and KDE Qt on Arch Linux. Operating System: Arch Linux KDE Plasma Version: 5.21.4 KDE Frameworks Version: 5.81.0 Qt Version: 5.15.2 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #4 from Nate Graham --- Thanks. Cannot reproduce. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #3 from Patrick Silva --- Default Noto Sans. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #2 from Nate Graham --- What fonts are you using? -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 435731] Extra space between entries in Places panel after reverting icon size to "Small"
https://bugs.kde.org/show_bug.cgi?id=435731 --- Comment #1 from Patrick Silva --- Created attachment 137606 --> https://bugs.kde.org/attachment.cgi?id=137606=edit small icons after step 2 -- You are receiving this mail because: You are watching all bug changes.
