[dolphin] [Bug 444680] Right clicking on header shows file context-menu instead of column role context-menu

2022-01-16 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=444680

Felix Ernst  changed:

   What|Removed |Added

   Version Fixed In||22.04
  Latest Commit||https://invent.kde.org/syst
   ||em/dolphin/commit/d38396171
   ||93e92463806580699caa595c892
   ||b8a6
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Felix Ernst  ---
Git commit d3839617193e92463806580699caa595c892b8a6 by Felix Ernst, on behalf
of Tom Lin.
Committed on 16/01/2022 at 14:01.
Pushed by felixernst into branch 'master'.

Full row highlight implementation

This commit implements full-row selection and hover highlights for the
details view mode.

This commit also contains fixes for 444680, 444753, both uncovered
during this change.
Related: bug 181438, bug 444753
FIXED-IN: 22.04

M  +143  -36   src/kitemviews/kitemlistcontroller.cpp
M  +16   -0src/kitemviews/kitemlistheader.cpp
M  +9-0src/kitemviews/kitemlistheader.h
M  +51   -5src/kitemviews/kitemlistview.cpp
M  +11   -0src/kitemviews/kitemlistview.h
M  +32   -0src/kitemviews/kitemlistwidget.cpp
M  +10   -1src/kitemviews/kitemlistwidget.h
M  +4-0src/kitemviews/kstandarditemlistview.cpp
M  +42   -10   src/kitemviews/kstandarditemlistwidget.cpp
M  +6-0src/kitemviews/kstandarditemlistwidget.h
M  +92   -34   src/kitemviews/private/kitemlistheaderwidget.cpp
M  +15   -0src/kitemviews/private/kitemlistheaderwidget.h
M  +4-0src/settings/dolphin_detailsmodesettings.kcfg
M  +1-0src/views/dolphinitemlistview.cpp
M  +17   -0src/views/dolphinview.cpp
M  +1-0src/views/dolphinview.h

https://invent.kde.org/system/dolphin/commit/d3839617193e92463806580699caa595c892b8a6

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 444680] Right clicking on header shows file context-menu instead of column role context-menu

2021-11-01 Thread Tom Lin
https://bugs.kde.org/show_bug.cgi?id=444680

Tom Lin  changed:

   What|Removed |Added

 CC||tom91...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 444680] Right clicking on header shows file context-menu instead of column role context-menu

2021-11-01 Thread Tom Lin
https://bugs.kde.org/show_bug.cgi?id=444680

Tom Lin  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |tom91...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 444680] Right clicking on header shows file context-menu instead of column role context-menu

2021-10-30 Thread Tom Lin
https://bugs.kde.org/show_bug.cgi?id=444680

--- Comment #2 from Tom Lin  ---
This issue is most obvious if
https://invent.kde.org/system/dolphin/-/merge_requests/278 gets merged, I've
added a fix in that MR for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 444680] Right clicking on header shows file context-menu instead of column role context-menu

2021-10-30 Thread Tom Lin
https://bugs.kde.org/show_bug.cgi?id=444680

--- Comment #1 from Tom Lin  ---
Testing a bit more, it's not necessary to highlight anything.
The bug occurs if you simply right-click on the header in a location that needs
scrolling. Essentially, file item's text (and not the entire row) rect hit
check was done before the header's so the click events gets swallowed.

-- 
You are receiving this mail because:
You are watching all bug changes.