[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 soredake changed: What|Removed |Added CC|katyaberezy...@gmail.com| -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 Geert Janssens changed: What|Removed |Added CC||i...@kobaltwit.be -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #19 from tagwer...@innerjoin.org --- (In reply to cybea from comment #18) > ... To me this looks like many bugs and having only one bug report could make > tracking and prioritizing harder. But I appreciate having this overview ... I can see that, what was happening though was we had been drowning under a wave of overlapping reports. If there's a new report, we have the choice of flagging it as a duplicate or leaving it and cross-referencing with a "see also". There is, I think, the possibility of creating a "tracking bug" that gets resolved when all the component issues are resolved. I've no experience of these and am not sure whether it would be appropriate here... -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 cybea changed: What|Removed |Added CC||kde-b...@cyborgsociety.org --- Comment #18 from cybea --- It would be really great if this could be fixed (especially case 1a) since baloo search feels broken if there are files you know of but nothing is displayed. Doing a "dolphin filenamesearch" as a fallback could be considered as well. Maybe anyone can increase the importance of this bug? (To me this looks like many bugs and having only one bug report could make tracking and prioritizing harder. But I appreciate having this overview.) -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 Ahmet Sait changed: What|Removed |Added CC||nightmarex1...@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #17 from Stefan Brüns --- (In reply to tagwerk19 from comment #16) > (In reply to Stefan Brüns from comment #12) > > Dolphin returns the correct result only when the path of the current > > directory is its canonical name. > Meaning that Dolphin should follow any symlinks before doing a search and > (silently) query baloo with the canonical path? Although I'm not sure > whether Dolphin should then show the results relative to the symlink or with > the canonical path. The "Path" column should display the canonical path. After all, that's where the file is actually located. (And in case the symlink started on a different filesystem, also the place where the space is consumed). This is consistent with how directory sizes are calculated, symlinks are not followed, otherwise you may count files several times. > It makes sense ... > > ... although it implies that the index *only* ever contains canonical > paths. > > Would also need to be careful that baloosearch and filenamesearch do the > same thing. > > Edge cases? > > $ balooshow -x path-including-symlink balooshow already handles this correctly, the canonical path is shown in square brackets (if it differs from the specified path): > balooshow -x ~/Sources/testdata/symlink_parent/testdata/hello.txt > 12ccd4a002d 45 19713354 > /home/stefan/Sources/testdata/symlink_parent/testdata/hello.txt > [/home/stefan/Sources/testdata/hello.txt] > $ balooctl index path-including-symlink > $ balooctl clear path-including-symlink > > and then evil baloofilerc includes such as > > folders[$e]=$HOME/Desktop/Documents > > where you've got a symlink on your Desktop to your Documents folder? > > I think the "balooctl index" (and "balooctl clear") does things properly but > I suspect that the evil include does not... In case it is not, this should be trivial to fix. Also, if you break it, you may keep both parts. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #16 from tagwer...@innerjoin.org --- (In reply to Stefan Brüns from comment #12) > Dolphin returns the correct result only when the path of the current > directory is its canonical name. Meaning that Dolphin should follow any symlinks before doing a search and (silently) query baloo with the canonical path? Although I'm not sure whether Dolphin should then show the results relative to the symlink or with the canonical path. It makes sense ... ... although it implies that the index *only* ever contains canonical paths. Would also need to be careful that baloosearch and filenamesearch do the same thing. Edge cases? $ balooshow -x path-including-symlink $ balooctl index path-including-symlink $ balooctl clear path-including-symlink and then evil baloofilerc includes such as folders[$e]=$HOME/Desktop/Documents where you've got a symlink on your Desktop to your Documents folder? I think the "balooctl index" (and "balooctl clear") does things properly but I suspect that the evil include does not... -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #15 from Stefan Brüns --- Git commit d313aa5d0b4122aee26a1a2f7dab6054d7eb5cd1 by Stefan Brüns. Committed on 24/04/2023 at 19:35. Pushed by bruns into branch 'kf5'. baloosearch: Inform the user when the specified dir is not canonical The path supplied for any queries must use the canonical form. baloosearch already uses the canonical form, but does so silently. Inform the user when the actual used path differs, to aid debugging. (cherry picked from commit c40c6b2594d9b383e11ead53cc56ceaf9d51f62c) M +8-1src/tools/baloosearch/main.cpp https://invent.kde.org/frameworks/baloo/commit/d313aa5d0b4122aee26a1a2f7dab6054d7eb5cd1 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #14 from Stefan Brüns --- Git commit c40c6b2594d9b383e11ead53cc56ceaf9d51f62c by Stefan Brüns. Committed on 24/04/2023 at 19:33. Pushed by bruns into branch 'master'. baloosearch: Inform the user when the specified dir is not canonical The path supplied for any queries must use the canonical form. baloosearch already uses the canonical form, but does so silently. Inform the user when the actual used path differs, to aid debugging. M +8-1src/tools/baloosearch/main.cpp https://invent.kde.org/frameworks/baloo/commit/c40c6b2594d9b383e11ead53cc56ceaf9d51f62c -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #13 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/baloo/-/merge_requests/126 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 --- Comment #12 from Stefan Brüns --- > ls -l . ; readlink -f > /home/stefan/Sources/testdata/symlink_parent/testdata/symlink ; \ > baloosearch -v ; baloosearch -i -d > /home/stefan/Sources/testdata/symlink_parent/testdata/symlink foo > insgesamt 3960 > -rw-r--r-- 1 stefan users 6 18. Mär 15:44 foo2.txt > -rw-r--r-- 1 stefan users 6 18. Mär 15:44 foo.txt > -rw-r--r-- 1 stefan users 6 18. Mär 15:08 hello.txt > drwxr-xr-x 1 stefan users 36 5. Apr 12:18 Readonly > lrwxrwxrwx 1 stefan users 1 24. Apr 20:32 symlink -> . > lrwxrwxrwx 1 stefan users 2 24. Apr 20:36 symlink_parent -> .. > -rw-r--r-- 1 stefan users 1340684 18. Mär 15:19 test2.wav > -rw-r--r-- 1 stefan users 1340684 18. Mär 15:22 test3.wav > -rw-r--r-- 1 stefan users 1340684 18. Mär 15:19 test.wav > -rw-r--r-- 1 stefan users 12 18. Mär 15:08 world.txt > /home/stefan/Sources/testdata > Baloo 5.105.0 > 12ccf1f002d /home/stefan/Sources/testdata/foo2.txt > 12ccf01002d /home/stefan/Sources/testdata/foo.txt > Elapsed: 0,125005 msecs Dolphin returns the correct result only when the path of the current directory is its canonical name. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 447119] Summary: Dolphin/Baloo search with symlinks
https://bugs.kde.org/show_bug.cgi?id=447119 Stefan Brüns changed: What|Removed |Added Component|general |search Assignee|baloo-bugs-n...@kde.org |dolphin-bugs-n...@kde.org CC||kfm-de...@kde.org, ||stefan.bruens@rwth-aachen.d ||e Product|frameworks-baloo|dolphin --- Comment #11 from Stefan Brüns --- This is mostly a bug in dolphin, it should pass the canonical path to baloo. When you use `baloosearch -d ...`, it will return results even when the specified directory path contains symlinks, as it resolves the specified directory to its canonical path. In case you wonder why canonicalization is the callers (in this case dolphin) responsibility: Canonicalization is a potentially blocking file system operation. Dolphin can use KIO to resolve the path without blocking the UI, it may even already have the canonical path at hand. -- You are receiving this mail because: You are watching all bug changes.
