[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #11 from popov895 --- > In your anger you don't seem to be able to comprehend this bug report history Bug 458282, bug 458281, and bug 463048 reported that pressing the space bar activated Selection Mode instead of the expected action. Instead of fixing these issues properly, you decided to make this keyboard shortcut hardcoded, which basically fixed the first two issues but not the third. Not knowing how to fix the third issue, you just marked it as intentional. Very commendable! > Not sure what KDE Plasma has to do with any of this Because Plasma has become unpredictable. You can roll out a new "improvement" that will break my user experience again, and all arguments against it will be considered negligible. > I probably won't respond to your next comment It's expected, honestly. Anyway our dialogue isn't constructive. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #10 from Felix Ernst --- >What was the point of your MR that "fixes" this bug? Make this keyboard >shortcut hardcoded? In your anger you don't seem to be able to comprehend this bug report history. It was marked as fixed when the keyboard shortcut was still changeable. My commit only had this bug report in the CC so it would be notified by my change that would affect the reporter of this bug. This bug was later marked as intentional when this was no longer possible. The reasons for all of this are explained within this bug report. If you aren't even interested in reading comments, you certainly can't be reasoned with. >Anyway, I was so fed up with this change that I decided to switch to GNOME 44 >when it was released. Not sure what KDE Plasma has to do with any of this, but if this leads to less anger directed to me and others, this is probably for the best. I probably won't respond to your next comment if you choose to write another comment here. GL HF. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #9 from popov895 --- Damn, I'm so sick of these your "improvements". What was the point of your MR that "fixes" this bug? Make this keyboard shortcut hardcoded? You have only made it worse. > Don't make it sound like any of this breaks any essential functionality That's exactly what it does. At the moment this f***ing Selection Mode is trying to get out every chance it gets. It can't be turned off and it's very annoying to me! Why not use another keyboard shortcut for this? If using the Space is so important to you, why not make it open when you long press it? Anyway, I was so fed up with this change that I decided to switch to GNOME 44 when it was released. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 Felix Ernst changed: What|Removed |Added Resolution|--- |INTENTIONAL Status|REOPENED|RESOLVED --- Comment #8 from Felix Ernst --- Please read comment 4 https://bugs.kde.org/show_bug.cgi?id=463048#c4 above. This is intentional. >Please add an option to FULLY disable Selection Mode. Your reasoning doesn't make sense. This is a fully optional feature. Nobody forces you to use it (unless you are on a touch device where this solves a use case that wasn't really solved previously). Yes, the "Space" key doesn't select the current file anymore. Ctrl+Space can be used instead. The Space shortcut to select the current file has always been mostly useless anyway because it is only ever useful to select the very first pre-selected file in a folder. For every other file, using the arrow keys to navigate already auto-selects the next file. Don't make it sound like any of this breaks any essential functionality. You are most definitely misjudging the amount of disruption this brings. You are also wrong about putting "improvements" in quotes like that because this was most an improvement for a couple of use cases that many people agreed on needing improvement. You would know that if you looked at the feedback we got from this change. I know that you aren't easily persuaded, but I hope you can try to see the other side in this case. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #7 from popov895 --- And please stop breaking the user experience and adding all sorts of "improvements" that can't be turned off. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 popov895 changed: What|Removed |Added Resolution|FIXED |--- CC||popov...@ukr.net Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #6 from popov895 --- Still not fixed in Dolphin 22.12.2. Pressing Space still opens unwanted Selection Mode. But before 22.12.2 I could just remove the keyboard shortcut to at least partially disable it, now I don't have the ability to do that either. Please add an option to FULLY disable Selection Mode. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #5 from Felix Ernst --- Git commit aac61acf41fb3ccd6f9a807984336d9be07917a4 by Felix Ernst, on behalf of Felix Ernst. Committed on 12/01/2023 at 11:26. Pushed by felixernst into branch 'release/22.12'. Make space shortcut for selection mode view-local instead of global Before this commit, the "Space" keyboard shortcut was bound to triggering selection mode by default. After this commit, pressing "Space" will only trigger selection mode when the file view area has keyboard focus. Pros: + Other buttons in the UI can be triggered with Space once again just like it is expected from an accessibility point of view. + "Type-ahead" searching works once more when typing the space char for file names containing such a space char. Cons: - "Space" can no longer be used to add the currently underlined item to the selection. Instead "Ctrl+Space" needs to be used. (However, this is the current status anyway unless a user has manually unbound "Space" as a shortcut from Selection Mode.) - The Selection Mode action will no longer show "Space" as its shortcut in menus. Overall, I see solutions to all of these problems, but they seem over-engineered for the issues they are trying to solve, so I believe this somewhat small commit is the best solution for now. Related: bug 458282, bug 458281 FIXED-IN: 23.04 (cherry picked from commit 44c82a16b3e2fc2d40601fd70f8253dce40dda86) M +0-1src/dolphinmainwindow.cpp M +4-7src/kitemviews/kitemlistcontroller.cpp M +5-0src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp M +10 -1src/kitemviews/private/kitemlistkeyboardsearchmanager.h https://invent.kde.org/system/dolphin/commit/aac61acf41fb3ccd6f9a807984336d9be07917a4 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #4 from Felix Ernst --- The commit I have linked above will unfortunately remove the workaround I told you about. I don't really see a good alternative solution that would manage to keep "Space" working as the key to trigger buttons e.g. for blind people. I hope you understand. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/486 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 --- Comment #2 from kyrawer...@gmail.com --- Nice, thank you. I like to stick with my old habits and now that behavior has changed, I noticed how often I use this function. The setting is in Settings > Configure Keyboard Shortcuts for anyone else who's trying to find it. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 463048] Spacebar opens Selection mode
https://bugs.kde.org/show_bug.cgi?id=463048 Felix Ernst changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #1 from Felix Ernst --- >I want my old behavior back but there is no setting to do so. >– Can we get a setting to disable it? >– Can the selection mode be assigned to another key so it doesn't change >pre-existing behavior? Selection mode is an action like any other. As such you can change its keyboard shortcut and even assign nothing to it. If you remove the default shortcut "Space" from the action "Select Files and Folders", you will get the old behaviour back. Aside from this, I don't really think there would be an issue with the keyboard shortcut only being Ctrl+Space, since one already needs Ctrl+Arrows to move to items without selecting them. But I understand that every change like this will be disruptive to at least some existing users to some extent. In any case since you can easily change the keyboard shortcut so your expected behaviour happens, I think we should consider this specific bug report resolved. -- You are receiving this mail because: You are watching all bug changes.
