[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-11 Thread Serg Podtynnyi
https://bugs.kde.org/show_bug.cgi?id=465344

--- Comment #7 from Serg Podtynnyi  ---
I just found the bug, when you have selected multiple items via shift + mouse
and after you add some items with ctrl + mouse (toggle and untoggle) the shift
+ mouse selection stopped working for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-10 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=465344

--- Comment #6 from Felix Ernst  ---
(In reply to Nate Graham from comment #4)
> It should also show up if you have the Ctrl or Shift modifier key held down,
> such that clicking will in fact grow the selection rather than unselecting
> everything.

Makes sense to me.
(In reply to medin from comment #5)
> Sorry but your argument is not convincing at all, if I want to deselect my
> selected items I simply release ctrl key and click anywhere.

Not sure if I was able to communicate what I mean. When you are about to "click
anywhere" to deselect items, you would be confused if a file was highlighted.
You would think that your next click would act on that file instead of
deselecting everything and not acting on that file. For that reason the
highlight should only show up if your next click will interact with that file.

> > I personally would want the highlight to never appear if any item is
> > selected at all
> 
> Line Highlighting is a necessary way to make easy and fast selection instead
> of following that tiny mouse pointer and verify which one is going to be
> selected.

Right. As Nate said: The highlight should show up while you are for example
pressing Ctrl to select additional items.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread medin
https://bugs.kde.org/show_bug.cgi?id=465344

--- Comment #5 from medin  ---
(In reply to Felix Ernst from comment #1)
> I know this might seem weird at first, but this is intentional. You see, the
> highlight is meant to signify what your next click on that area will
> interact with. When less than two items are selected, the highlight is there
> because a click in that row will act on the item in that row. However, when
> two or more items are selected, there won't be a highlight, because the next
> click on the row will clear the selection instead of acting on the item.
> 

Sorry but your argument is not convincing at all, if I want to deselect my
selected items I simply release ctrl key and click anywhere.


> I personally would want the highlight to never appear if any item is
> selected at all

Line Highlighting is a necessary way to make easy and fast selection instead of
following that tiny mouse pointer and verify which one is going to be selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465344

--- Comment #4 from Nate Graham  ---
It should also show up if you have the Ctrl or Shift modifier key held down,
such that clicking will in fact grow the selection rather than unselecting
everything.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=465344

--- Comment #3 from Felix Ernst  ---
(In reply to Nate Graham from comment #2)
> Hmm... I can appreciate the subtleties of that behavior when using
> single-click outside of selection mode but that's not what's happening here.
> This happens even in selection mode where a click will select the list item
> under the cursor. So at least for that use case, the intentional behavior is
> triggering inappropriately.

I agree that the full row highlight should be showing up in selection mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread Serg Podtynnyi
https://bugs.kde.org/show_bug.cgi?id=465344

Serg Podtynnyi  changed:

   What|Removed |Added

 CC||s...@podtynnyi.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465344

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org
  Component|general |view-engine: details mode

--- Comment #2 from Nate Graham  ---
Hmm... I can appreciate the subtleties of that behavior when using single-click
outside of selection mode but that's not what's happening here. This happens
even in selection mode where a click will select the list item under the
cursor. So at least for that use case, the intentional behavior is triggering
inappropriately.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 465344] Full line highlight is disabled after selecting two items

2023-02-07 Thread Felix Ernst
https://bugs.kde.org/show_bug.cgi?id=465344

Felix Ernst  changed:

   What|Removed |Added

 CC||felixer...@kde.org

--- Comment #1 from Felix Ernst  ---
I know this might seem weird at first, but this is intentional. You see, the
highlight is meant to signify what your next click on that area will interact
with. When less than two items are selected, the highlight is there because a
click in that row will act on the item in that row. However, when two or more
items are selected, there won't be a highlight, because the next click on the
row will clear the selection instead of acting on the item.

I'd have to dig up all the details, but one of the reasons we implemented this
behaviour was to give users an easy way to clear their selection if they do
want to do that.

I personally would want the highlight to never appear if any item is selected
at all, but this wasn't done yet because Dolphin currently sometimes highlights
singular files "by itself" when navigating through the file system. See
https://bugs.kde.org/show_bug.cgi?id=424723 for details.

-- 
You are receiving this mail because:
You are watching all bug changes.