[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #8 from Ignacio Serantes --- (In reply to Robert-André Mauchin from comment #6) > Fix proposal: > > https://invent.kde.org/frameworks/kio/-/merge_requests/1608 > > > Commit 33785332 has purposely ordered actions by their name. However, this > break separators in service context menus. > > For example: > > Actions=progressive;optimize;SEPARATOR;compress_50;compress_70;compress_75 > > The separator would end up at the end of the list: > > Actions=compress_50;compress_70;compress_75;progressive|optimize;SEPARATOR > > And since the logic check is the separator is the last item to add it: > > !actions.last()->isSeparator() > > separators basically disappear from service context menus. > > The purpose of this commit is then to create groups of actions between each > separator. Actions will be sorted withing these groups, but it will keep > service menus original organisation. I don't understand the main reason for 33785332 commit, previous behavior, the sort is the one in Actions property, seems the right one behavior for me. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #7 from schick...@web.de --- Thanks a lot, Monsieur Mauchin! I hope your fix can find its way to master and to us soon. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #6 from Robert-André Mauchin --- Fix proposal: https://invent.kde.org/frameworks/kio/-/merge_requests/1608 Commit 33785332 has purposely ordered actions by their name. However, this break separators in service context menus. For example: Actions=progressive;optimize;SEPARATOR;compress_50;compress_70;compress_75 The separator would end up at the end of the list: Actions=compress_50;compress_70;compress_75;progressive|optimize;SEPARATOR And since the logic check is the separator is the last item to add it: !actions.last()->isSeparator() separators basically disappear from service context menus. The purpose of this commit is then to create groups of actions between each separator. Actions will be sorted withing these groups, but it will keep service menus original organisation. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #5 from Robert-André Mauchin --- Created attachment 168266 --> https://bugs.kde.org/attachment.cgi?id=168266&action=edit After fix -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #4 from Robert-André Mauchin --- Created attachment 168265 --> https://bugs.kde.org/attachment.cgi?id=168265&action=edit Before fix -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #3 from Ignacio Serantes --- In Dolphin 24.02.1 this behavior is worst because service menu is ordered using name instead of action name. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 Ignacio Serantes changed: What|Removed |Added CC||k...@aynoa.net -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 Oleg Bosis changed: What|Removed |Added CC||oleluk...@mail.ru -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 --- Comment #2 from schick...@web.de --- Thank a lot for these clarifications. You're perfectly right. I've noticed the new alphabetical sorting too, but failed to make the connection. Having one separator is better than none (thanks for that trick too), but I'm still hoping Dolphin will let us organize sub-menus with multiple separators again. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 466115] [Regression] Custom horizontal lines/bars in context menu no longer possible
https://bugs.kde.org/show_bug.cgi?id=466115 alan.n.dav...@gmail.com changed: What|Removed |Added CC||alan.n.dav...@gmail.com --- Comment #1 from alan.n.dav...@gmail.com --- It seems that actions now get sorted by the action ID. Because you have to specify the separator as _SEPARATOR_, it begins with an underscore, which comes after all the uppers letters in ASCII order, but before the lowercase letters. I think KDE then ignores any separators that appear at the start or end of the menu. If you only need a single separator, you can ID your actions like this, which will fix the issue (note the uppercase `A` in the IDs of the actions before the separator)... Actions=Action_a;Action_b;_SEPARATOR_;action_c;action_d;action_e; Unfortunately, you cannot have multiple separators, as they will all get ordered into the same position. I'm not sure why KDE is now ordering the actions by action ID, it seems very strange. The actions used to appear in the order they appeared in the action list. Ordering by action ID is completely arbitrary. If you are trying to make the menus more usable by putting stuff in alphabetical order, you should be ordering by the "Name" parameter, not the ID. The ID does not take any localization into account, and anyway, you may not want stuff in alphabetical order anyway. -- You are receiving this mail because: You are watching all bug changes.
