[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 --- Comment #19 from Felix Ernst --- Git commit e817c3246cf512a89a3de003763273f29d9cfe8c by Felix Ernst, on behalf of Felix Ernst. Committed on 23/01/2024 at 12:13. Pushed by felixernst into branch 'master'. Slightly refactor count resorting The bug fix 8f043b2958477d3fe2ef094b7e42f792f4cf0b02 introduced a secondary code path to trigger a resort of items. However, the previous way to trigger it only required a small bug fix to work and gives us a couple of optimisations for free. This commit removes the secondary code path and fixes the primary one. M +3-2src/kitemviews/kfileitemmodel.cpp M +2-2src/kitemviews/kfileitemmodel.h M +0-4src/kitemviews/kfileitemmodelrolesupdater.cpp https://invent.kde.org/system/dolphin/-/commit/e817c3246cf512a89a3de003763273f29d9cfe8c -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 --- Comment #18 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/705 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Nate Graham changed: What|Removed |Added Version Fixed In||24.02 --- Comment #17 from Nate Graham --- There are no LTS versions of Dolphin, which is an app. There are LTS versions of Plasma, but Dolphin is not on the Plasma release schedule, and also no further releases of Plasma 5 are planned. So I'm afraid you'll have to wait until Dolphin's 24.02 release next month. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 --- Comment #16 from opensuse.lietuviu.ka...@gmail.com --- Can you please backport this patch to 5.x LTS versions? This bus quite annoying. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Méven Car changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/syst ||em/dolphin/-/commit/8f043b2 ||958477d3fe2ef094b7e42f792f4 ||cf0b02 Resolution|--- |FIXED --- Comment #15 from Méven Car --- Git commit 8f043b2958477d3fe2ef094b7e42f792f4cf0b02 by Méven Car, on behalf of Akseli Lahtinen. Committed on 15/12/2023 at 14:07. Pushed by meven into branch 'master'. Resort directory size count after refreshing After refreshing the view when size count is selected as the sortRole, count is 0 at first. When the actual count is loaded, the sorting is done according to the count being 0. This can break the sort order and cause view and model to be out of sync. Making sure we always resort all items when the directory size/item count is changed fixes this M +7-0src/kitemviews/kfileitemmodel.cpp M +2-0src/kitemviews/kfileitemmodel.h M +3-0src/kitemviews/kfileitemmodelrolesupdater.cpp M +103 -0src/tests/kfileitemmodeltest.cpp https://invent.kde.org/system/dolphin/-/commit/8f043b2958477d3fe2ef094b7e42f792f4cf0b02 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Akseli Lahtinen changed: What|Removed |Added CC||cf...@kde.org --- Comment #14 from Akseli Lahtinen --- *** Bug 471102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #13 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/675 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 --- Comment #12 from Akseli Lahtinen --- It seems the bug happens because the sort order, when created, is thinking that every size count is 0, which leads to alphabetical order. It updates the correct counts later. This then confuses dolphin. The ordering should be done *after* all counting and such is finished. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Akseli Lahtinen changed: What|Removed |Added CC||akse...@akselmo.dev --- Comment #11 from Akseli Lahtinen --- Can confirm and reproduce the bug on Plasma 6. -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Fabian Arndt changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=411061 --- Comment #10 from Fabian Arndt --- Bug 433247 is a duplicate, it was marked as resolved by https://invent.kde.org/system/dolphin/-/merge_requests/232 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Fabian Arndt changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=433247 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Fabian Arndt changed: What|Removed |Added CC||opensuse.lietuviu.kalba@gma ||il.com --- Comment #9 from Fabian Arndt --- *** Bug 386317 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Fabian Arndt changed: What|Removed |Added CC||ard...@bbox.fr --- Comment #8 from Fabian Arndt --- *** Bug 430177 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load
https://bugs.kde.org/show_bug.cgi?id=473999 Fabian Arndt changed: What|Removed |Added Summary|Folder expanding on wrong |Folders in details view |position|expanding at wrong position ||- ordering by size is ||broken on load -- You are receiving this mail because: You are watching all bug changes.
