[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-15 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #11 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
Created attachment 169499
  --> https://bugs.kde.org/attachment.cgi?id=169499=edit
Flamegraph

https://discuss.kde.org/t/dolphin-struggles-to-load-directories-which-contain-many-files/15450/12?u=rokejulianlockhart

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-15 Thread Méven
https://bugs.kde.org/show_bug.cgi?id=486956

Méven  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/-/commit/a360462
   ||d5290200b27d874d1cb38953369
   ||42d55b
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #10 from Méven  ---
Git commit a360462d5290200b27d874d1cb3895336942d55b by Méven Car.
Committed on 15/05/2024 at 06:05.
Pushed by meven into branch 'master'.

kfileitem: cache group names

Since b1a0a7cfe704db2a0aa363fed4e03501f324df9e the group name is now
fetch in KFFileItem, it was previously fetched inside the file
kioworker.

Cache the group names in KFileItem using a thread local QMap.

M  +9-1src/core/kfileitem.cpp

https://invent.kde.org/frameworks/kio/-/commit/a360462d5290200b27d874d1cb3895336942d55b

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-13 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=486956

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #9 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/1630

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #8 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
(In reply to Roke Julian Lockhart Beedell from comment #7)
Indeed, disabling that fixes it for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #7 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
Created attachment 169449
  --> https://bugs.kde.org/attachment.cgi?id=169449=edit
View Display Style Preferences

(In reply to Méven Car from comment #6)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory when group column is shown

2024-05-13 Thread Méven Car
https://bugs.kde.org/show_bug.cgi?id=486956

Méven Car  changed:

   What|Removed |Added

Summary|Dolphin takes ≥5s to load ≈ |Dolphin takes ≥5s to load ≈
   |52 GiB, 7x10^3-file |52 GiB, 7x10^3-file
   |directory.  |directory when group column
   ||is shown

--- Comment #6 from Méven Car  ---
This is easily reproducible in dolphin, simply show the user group column with
a moderate to high number of files.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory.

2024-05-13 Thread Méven Car
https://bugs.kde.org/show_bug.cgi?id=486956

Méven Car  changed:

   What|Removed |Added

   Keywords||regression
 CC||meve...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #5 from Méven Car  ---
The flamegraph showed the process spend way too much time retrieve group name
for the files.

This is a regression from:
https://invent.kde.org/frameworks/kio/-/merge_requests/1276
b1a0a7cfe704db2a0aa363fed4e03501f324df9e

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≈ 52 GiB, 7x10^3-file directory.

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

Roke Julian Lockhart Beedell <4wy78...@rokejulianlockhart.addy.io> changed:

   What|Removed |Added

Summary|Dolphin takes ≥5s to load   |Dolphin takes ≥5s to load ≈
   |≥52 GiB, 7x10^3-file|52 GiB, 7x10^3-file
   |directory.  |directory.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≥52 GiB, 7x10^3-file directory.

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #4 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
Created attachment 169448
  --> https://bugs.kde.org/attachment.cgi?id=169448=edit
`.perfParser` file from Hotspot.

This allows me to retroactively view the performance data, so it might work for
you, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≥52 GiB, 7x10^3-file directory.

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #3 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
(In reply to Roke Julian Lockhart Beedell from comment #2)
Flamegraph is available at
https://discuss.kde.org/t/dolphin-struggles-to-load-directories-which-contain-many-files/15450/12?u=rokejulianlockhart.
If I can export a proper flamegraph, I'll attach it to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≥52 GiB, 7x10^3-file directory.

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #2 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
(In reply to Roke Julian Lockhart Beedell from comment #1)
Redacted due to uselessness, per
https://discuss.kde.org/t/dolphin-struggles-to-load-directories-which-contain-many-files/15450/8?u=rokejulianlockhart

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 486956] Dolphin takes ≥5s to load ≥52 GiB, 7x10^3-file directory.

2024-05-13 Thread Roke Julian Lockhart Beedell
https://bugs.kde.org/show_bug.cgi?id=486956

--- Comment #1 from Roke Julian Lockhart Beedell 
<4wy78...@rokejulianlockhart.addy.io> ---
The `perf.data` file is available at
https://wim.nl.tab.digital/s/B5Ptt4qN2CdtYNP

-- 
You are receiving this mail because:
You are watching all bug changes.