[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult |imedia/elisa/commit/3b80b00 |imedia/elisa/commit/b1931eb |01239f8c6a35f95ff940e6ba596 |86c224c7cdeb1c78fdc4112c214 |075310 |2212d6 --- Comment #5 from Nate Graham --- Git commit b1931eb86c224c7cdeb1c78fdc4112c2142212d6 by Nate Graham. Committed on 12/11/2020 at 22:43. Pushed by ngraham into branch 'master'. Replace homemade ScrollHelper with standard ScrollViews to hold view items We created the ScrollHelper component to fix scrolling with touchpads, which is quite terrible out of the box with QML's default flickables. However this solution had some drawbacks: - It broke touch scrolling - It broke fast scrolling by holding down the shift key while scrolling - It essentially re-wrote scroll handling locally, which is fragile - It required a bunch of extra code to handle scrollbar visibility which introduced various minor visual bugs in a few places In addition, this solution was not necessary since we can get the same result by putting views inside ScrollView components, which is a 100% supported and standard paradigm. Doing so preserves the nice touchpad scrolling we already have but fixes all of the above items automatically. Related: bug 427967 FIXED-IN: 20.12 M +0-1src/CMakeLists.txt M +23 -31 src/qml/GridBrowserView.qml M +28 -36 src/qml/ListBrowserView.qml M +18 -26 src/qml/MediaTrackMetadataView.qml M +113 -120 src/qml/PlayListBasicView.qml M +0-3src/qml/PlayListEntry.qml D +0-105 src/qml/ScrollHelper.qml M +80 -82 src/qml/SimplePlayListView.qml M +36 -52 src/qml/ViewSelector.qml M +0-1src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/b1931eb86c224c7cdeb1c78fdc4112c2142212d6 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 Matthieu Gallien changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/mult ||imedia/elisa/commit/3b80b00 ||01239f8c6a35f95ff940e6ba596 ||075310 Version Fixed In||20.12 Status|ASSIGNED|RESOLVED --- Comment #4 from Matthieu Gallien --- Git commit 3b80b0001239f8c6a35f95ff940e6ba596075310 by Matthieu Gallien, on behalf of Nate Graham. Committed on 12/11/2020 at 20:49. Pushed by mgallien into branch 'release/20.12'. Replace homemade ScrollHelper with standard ScrollViews to hold view items We created the ScrollHelper component to fix scrolling with touchpads, which is quite terrible out of the box with QML's default flickables. However this solution had some drawbacks: - It broke touch scrolling - It broke fast scrolling by holding down the shift key while scrolling - It essentially re-wrote scroll handling locally, which is fragile - It required a bunch of extra code to handle scrollbar visibility which introduced various minor visual bugs in a few places In addition, this solution was not necessary since we can get the same result by putting views inside ScrollView components, which is a 100% supported and standard paradigm. Doing so preserves the nice touchpad scrolling we already have but fixes all of the above items automatically. Related: bug 427967 FIXED-IN: 20.12 M +0-1src/CMakeLists.txt M +23 -31 src/qml/GridBrowserView.qml M +28 -36 src/qml/ListBrowserView.qml M +18 -26 src/qml/MediaTrackMetadataView.qml M +113 -120 src/qml/PlayListBasicView.qml M +0-3src/qml/PlayListEntry.qml D +0-105 src/qml/ScrollHelper.qml M +80 -82 src/qml/SimplePlayListView.qml M +36 -52 src/qml/ViewSelector.qml M +0-1src/resources.qrc https://invent.kde.org/multimedia/elisa/commit/3b80b0001239f8c6a35f95ff940e6ba596075310 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/183 -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 --- Comment #2 from Nate Graham --- This works natively with the scrollview we're using, so I suspect we broke it with our ScrollHelper component with has the goal of improving touchpad scrolling. To be honest, I'm not sure if it was worth it since it caused other regressions and any issues should really be fixed in Qt itself (if they still exist). -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 Nate Graham changed: What|Removed |Added CC||n...@kde.org Status|REPORTED|CONFIRMED Keywords||regression Ever confirmed|0 |1 --- Comment #1 from Nate Graham --- Yeah, this broke recently. -- You are receiving this mail because: You are watching all bug changes.
[elisa] [Bug 417859] Add touch scrolling to main pane
https://bugs.kde.org/show_bug.cgi?id=417859 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
