[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2024-03-04 Thread Ethan C
https://bugs.kde.org/show_bug.cgi?id=423669

--- Comment #12 from Ethan C  ---
It looks like QQC2 and Kirigami applications should use the layout we set for
Qt Widgets:
https://doc.qt.io/qt-6/qml-qtquick-controls-dialogbuttonbox.html#buttonLayout-prop

I don't know how we can configure the other GUI toolkits, such as EFL, Tk,
Flutter, GNUstep, MauiKit, Winelib, etc. I think some of those are not
configurable.

For Gtk integration, I think we'll need to add a config value in some config
file somewhere, add a method to retrieve the value to
https://invent.kde.org/plasma/kde-gtk-config/-/blob/master/kded/configvalueprovider.h?ref_type=heads
and a method to set the gtk configuration to
https://invent.kde.org/plasma/kde-gtk-config/-/blob/master/kded/gtkconfig.h?ref_type=heads
. If I'm missing something here, please tell me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2024-03-04 Thread Ethan C
https://bugs.kde.org/show_bug.cgi?id=423669

Ethan C  changed:

   What|Removed |Added

 CC||echaroenpit...@gmail.com

--- Comment #11 from Ethan C  ---
For implementation, we should probably have a toggle between "OK/Cancel" and
"Cancel/OK", with pictures of the layouts on each button. We could have
advanced settings that would allow the user to choose any
[QDialogButtonBox::ButtonLayout](https://doc.qt.io/qt-6/qdialogbuttonbox.html#details).
We need to expose this value somewhere in System Settings and patch
plasma-integration's [Qt5
khintssettings.cpp#L116](https://invent.kde.org/plasma/plasma-integration/-/blob/master/qt5/src/platformtheme/khintssettings.cpp?ref_type=heads#L116)
and [Qt6
khintssettings.cpp#L116](https://invent.kde.org/plasma/plasma-integration/-/blob/master/qt6/src/platformtheme/khintssettings.cpp?ref_type=heads#L116).
Additionally, we need to change the gtkrc to set
[alternate-button-order](https://docs.gtk.org/gtk4/property.Settings.gtk-alternative-button-order.html)
to true, if the user chooses "OK/Cancel", and to false, if the user chooses
"Cancel/OK". I might try to work on this, but I don't really know enough of how
System Settings and the Gtk integration works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2024-02-10 Thread Hyuri
https://bugs.kde.org/show_bug.cgi?id=423669

Hyuri  changed:

   What|Removed |Added

 CC||hyuri.pimen...@gmail.com

--- Comment #10 from Hyuri  ---
This small quality-of-life change would be perfect to feature in the Plasma 6
release ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2021-06-09 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=423669

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423669

Nate Graham  changed:

   What|Removed |Added

 CC||niccolo.venera...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423669

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #9 from Nate Graham  ---
Thanks, your arguments make sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=423669

--- Comment #8 from boski_ci...@o2.pl ---
> I guess it just depends on whether you consider "the rest of the industry"
> to mean "Windows" or "everything else apart from Windows." :)

10 years ago it would be Windows, but nowadays I believe not so much. I think
it is better to be more familiar for FSF users (e.g. AOSP) and have more
unified user experience on Linux Qt+GTK desktop as Windows is no longer as
ubiquitous as in the past - there is new generation growing up for which mobile
OSes (and maybe Chrome OS, which also uses "OK on the right -
https://o.aolcdn.com/hss/storage/midas/c15853eddb12fc3ac8c9dfc2cd8b3948/205362663/chromeos-printer-ipp.jpg)
are point of reference.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423669

--- Comment #7 from Nate Graham  ---
Yeah, in general I agree that it makes sense to align with the de facto
standard in the rest of the industry.

I guess it just depends on whether you consider "the rest of the industry" to
mean "Windows" or "everything else apart from Windows." :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=423669

--- Comment #6 from boski_ci...@o2.pl ---
Basically yes. As noted before I am a long time user and as such I am used to
current layout, but I believe it would be better in grand scheme of things to
change time. Time has changed and now there is much more KDE users that are
also using Android (or iOS) than users with KDE+Windows. Not to mention
KDE+GTK.

KDE also supports GTK applications by trying to make them look as native as
possible and I think such change would reduce uncanny valley for layman users
of KDE+GTK apps in KDE session.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423669

Nate Graham  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|1   |0

--- Comment #5 from Nate Graham  ---
So basically this boils down to whether we should be more like Windows, or more
like everyone else in the industry besides Windows.

Personally I would be okay with this, but I suspect it would be very
controversial.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=423669

--- Comment #4 from boski_ci...@o2.pl ---
Windows is still using "old" layout but it is the only one (in the mainstream)
I am aware of.
It would be nice to have it at least configurable (I think it was possible back
in KDE3 days) so we could experiment with that. Currently this is hard-coded in
source code and users have to resort to workarounds to achieve what they want
(https://unix.stackexchange.com/questions/149818/how-to-give-the-same-order-for-ok-and-cancel-buttons-in-kde-and-gnome-applic).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-07-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423669

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO

--- Comment #3 from Nate Graham  ---
Does Windows use the same button order as those platforms, or as us? Or
something else?

Regardless, it seems like this change would have to be made in Qt.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-frameworkintegration] [Bug 423669] Change OK/Cancel buttons order/layout to improve consistency with other software

2020-06-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=423669

Christoph Feck  changed:

   What|Removed |Added

  Component|general |general
Product|kde |frameworks-frameworkintegra
   ||tion
   Assignee|unassigned-b...@kde.org |kdelibs-b...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.