[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 CC||bartkess...@outlook.com

--- Comment #9 from David Edmundson  ---
*** Bug 359617 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 CC||lj910...@gmail.com

--- Comment #8 from David Edmundson  ---
*** Bug 359355 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kact
   ||ivities/6b83071705add65a5c0
   ||b4cf1b808c8ae8137967b
 Resolution|--- |FIXED

--- Comment #7 from David Edmundson  ---
Git commit 6b83071705add65a5c0b4cf1b808c8ae8137967b by David Edmundson.
Committed on 02/02/2016 at 13:23.
Pushed by davidedmundson into branch 'master'.

Don't call exec() from QML

This is dangerous and leads to crashes as the QML processing still
continues in the new event loop.

Ideally we should never block the plasmashell UI anyway.

This changes it for a non blocking version.
REVIEW: 126945

M  +6-2src/workspace/settings/imports/activitysettings.cpp

http://commits.kde.org/kactivities/6b83071705add65a5c0b4cf1b808c8ae8137967b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 CC||a.mccullo...@outlook.com

--- Comment #6 from David Edmundson  ---
*** Bug 357904 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

Product|plasmashell |frameworks-kactivities
   Assignee|k...@davidedmundson.co.uk|ivan.cu...@kde.org
  Component|general |general
   Target Milestone|1.0 |---
Version|5.5.2   |unspecified

--- Comment #1 from David Edmundson  ---
#62 0x7fad45ac1acd in QDialog::exec() () from /usr/lib/libQt5Widgets.so.5
#63 0x7fab0c3d8c7c in ?? () from
/usr/lib/qt/qml/org/kde/activities/settings/libkactivitiessettingsplugin.so


Gah. You can't exec() from inside QML. You'll get crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[Ivan Čukić via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

--- Comment #3 from Ivan Čukić  ---
@Vishnu

The comment was for me :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[Ivan Čukić via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

--- Comment #4 from Ivan Čukić  ---
@David

Can you elaborate why modal dialogs can not be used in qml?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #5 from David Edmundson  ---
http://doc.qt.io/qt-5/qtquick-performance.html

Note: A pattern which is tempting, but should never be used, is creating your
own QEventLoop or calling QCoreApplication::processEvents() in order to avoid
blocking within a C++ code block invoked from QML. This is dangerous, because
when an event loop is entered in a signal handler or binding, the QML engine
continues to run other bindings, animations, transitions, etc. Those bindings
can then cause side effects which, for example, destroy the hierarchy
containing your event loop.

--

You'd think it should be safe if you launch it from a queued connection so that
the heirachy doesn't contain anything on the QML side.. however we still got
crashes when kickoff did that. Didn't really understand that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kactivities] [Bug 357435] Plasma Crash on attempting to change desktop settings

[Vishnu via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357435

--- Comment #2 from Vishnu  ---
(In reply to David Edmundson from comment #1)
> Gah. You can't exec() from inside QML. You'll get crashes.

I don't know what that means. Am I not supposed to do that?

-- 
You are receiving this mail because:
You are watching all bug changes.