[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Christoph Feck --- Currently uses qRound, which returns int, but either should use qRound64 (and double instead of qreal), or just use int arithmetic for rounding, e.g. ((x + 50) / 100) * 100 will round to multiple of 100. https://cgit.kde.org/kcoreaddons.git/tree/src/lib/util/kformatprivate.cpp#n332 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 --- Comment #2 from Christoph Feck --- https://phabricator.kde.org/D14565 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Sune Vuorela changed: What|Removed |Added Latest Commit||https://commits.kde.org/kco ||readdons/ea2779611800e72b51 ||6f400abf18aa8ef4abfaec Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Sune Vuorela --- Git commit ea2779611800e72b516f400abf18aa8ef4abfaec by Sune Vuorela. Committed on 03/08/2018 at 16:01. Pushed by sune into branch 'master'. Fix overflow in rounding code Summary: qRound works with int. Test Plan: add unit tests Reviewers: cfeck, safaalfulaij Reviewed By: cfeck, safaalfulaij Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D14565 M +11 -0autotests/kformattest.cpp M +2-2src/lib/util/kformatprivate.cpp https://commits.kde.org/kcoreaddons/ea2779611800e72b516f400abf18aa8ef4abfaec -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Sune Vuorela changed: What|Removed |Added CC||k...@pusling.com Version Fixed In||5.49.0 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Christoph Feck --- Currently uses qRound, which returns int, but either should use qRound64 (and double instead of qreal), or just use int arithmetic for rounding, e.g. ((x + 50) / 100) * 100 will round to multiple of 100. https://cgit.kde.org/kcoreaddons.git/tree/src/lib/util/kformatprivate.cpp#n332 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 --- Comment #2 from Christoph Feck --- https://phabricator.kde.org/D14565 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Sune Vuorela changed: What|Removed |Added Latest Commit||https://commits.kde.org/kco ||readdons/ea2779611800e72b51 ||6f400abf18aa8ef4abfaec Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Sune Vuorela --- Git commit ea2779611800e72b516f400abf18aa8ef4abfaec by Sune Vuorela. Committed on 03/08/2018 at 16:01. Pushed by sune into branch 'master'. Fix overflow in rounding code Summary: qRound works with int. Test Plan: add unit tests Reviewers: cfeck, safaalfulaij Reviewed By: cfeck, safaalfulaij Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D14565 M +11 -0autotests/kformattest.cpp M +2-2src/lib/util/kformatprivate.cpp https://commits.kde.org/kcoreaddons/ea2779611800e72b516f400abf18aa8ef4abfaec -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 397008] KFormat::formatDuration returns different results with ms large
https://bugs.kde.org/show_bug.cgi?id=397008 Sune Vuorela changed: What|Removed |Added CC||k...@pusling.com Version Fixed In||5.49.0 -- You are receiving this mail because: You are watching all bug changes.
