[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In||5.43.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168
Bug 388168 depends on bug 388727, which changed state.

Bug 388727 Summary: networkingservice requires kded networking module
https://bugs.kde.org/show_bug.cgi?id=388727

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #6 from Ralf Habacker  ---
(In reply to Christoph Feck from comment #4)
> Code review from comment #3 says it is committed. Anything else needed for
> resolving this ticket?

I need to check that next time I'm coming back to kdelib4support.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #5 from Ralf Habacker  ---
(In reply to Ralf Habacker from comment #3)
> See https://phabricator.kde.org/D9468 for the related review request

The patch from the mentioned review was submitted with commit
https://phabricator.kde.org/R239:1d1af3e514071efc51281b7ac1154737e44aa224

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=388168

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #4 from Christoph Feck  ---
Code review from comment #3 says it is committed. Anything else needed for
resolving this ticket?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #3 from Ralf Habacker  ---
See https://phabricator.kde.org/D9468 for the related review request

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #2 from Ralf Habacker  ---
(In reply to Ralf Habacker from comment #1)
> Running the networkingclient prints out the following message:
> 
> [384] Warning:QObject::connect: No such slot
> solid::NetworkingPrivate::serviceStatusChanged(bool)

fixed with
https://phabricator.kde.org/D9468?vs=24256=25088=ignore-most#toc

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

--- Comment #1 from Ralf Habacker  ---
Running the networkingclient prints out the following message:

[384] Warning:QObject::connect: No such slot
solid::NetworkingPrivate::serviceStatusChanged(bool)

which seems to be created by the following code fragment located in
src/solid/networking_p.h

#ifndef Q_OS_WIN
/**
 * Called on DBus signal from the network status service
 */
void serviceStatusChanged(uint status);
#else
void serviceStatusChanged(bool status);
#endif

Because moc does not define Q_OS_WIN a signal with uint type is generated and
therefore related connection fails -> need to to define Q_OS_WIN on running moc
on Windows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kdelibs4support] [Bug 388168] networkingclient test application does not recognize state change of networkingclient

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=388168

Ralf Habacker  changed:

   What|Removed |Added

 Depends on||388727


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=388727
[Bug 388727] networkingservice requires kded networking module
-- 
You are receiving this mail because:
You are watching all bug changes.