[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414227

nda...@tutanota.com changed:

   What|Removed |Added

 CC|nda...@tutanota.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=414227

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||dupre...@gmail.com

--- Comment #11 from Elvis Angelaccio  ---
*** Bug 415312 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-26 Thread Ismael Asensio
https://bugs.kde.org/show_bug.cgi?id=414227

Ismael Asensio  changed:

   What|Removed |Added

 CC||kdede...@dutfoy.fr

--- Comment #10 from Ismael Asensio  ---
*** Bug 415590 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-23 Thread Ismael Asensio
https://bugs.kde.org/show_bug.cgi?id=414227

--- Comment #9 from Ismael Asensio  ---
I've just noticed that the fix was also commited to Frameworks 5.65, so it
should be fixed from there on.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-23 Thread Ismael Asensio
https://bugs.kde.org/show_bug.cgi?id=414227

Ismael Asensio  changed:

   What|Removed |Added

   Version Fixed In|5.66|5.65

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

 CC||govers...@gmail.com

--- Comment #8 from Nate Graham  ---
*** Bug 415212 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

 CC||s...@gmx.eu

--- Comment #7 from Nate Graham  ---
*** Bug 415418 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-18 Thread David Hallas
https://bugs.kde.org/show_bug.cgi?id=414227

David Hallas  changed:

   What|Removed |Added

 CC||nda...@tutanota.com

--- Comment #6 from David Hallas  ---
*** Bug 415275 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-18 Thread David Hallas
https://bugs.kde.org/show_bug.cgi?id=414227

David Hallas  changed:

   What|Removed |Added

 CC||eddy...@gmail.com

--- Comment #5 from David Hallas  ---
*** Bug 415198 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.66

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-12 Thread Ismael Asensio
https://bugs.kde.org/show_bug.cgi?id=414227

Ismael Asensio  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kfi
   ||lemetadata/4bb4195a6fc6841d
   ||d9ce1d3f564fc122b6032d86
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Ismael Asensio  ---
Git commit 4bb4195a6fc6841dd9ce1d3f564fc122b6032d86 by Ismael Asensio.
Committed on 12/12/2019 at 20:50.
Pushed by iasensio into branch 'master'.

xattr: fix crash on dangling symlinks

Summary:
When requesting metadata on a dangling symlink, the framestack ends up calling
`k_queryAttributes()` with the symlink path, where the `listxattr` syscall
returns `size==-1` and `errno==ENOENT` (No such file or directory).
This case was not covered before, and provoked a segfault on `QByteArray`.
Full traceback on: https://bugs.kde.org/show_bug.cgi?id=414227

It might be also a good idea to always protect the function when `size==-1`

Test Plan:
- `bin/usermetadatawritertest` : added test
- On dolphin, with panel information open, hover over a dangling symlink

Reviewers: astippich, bruns

Reviewed By: bruns

Subscribers: bruns, kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D25414

M  +11   -0autotests/usermetadatawritertest.cpp
M  +1-0autotests/usermetadatawritertest.h
M  +6-6src/xattr_p.h

https://commits.kde.org/kfilemetadata/4bb4195a6fc6841dd9ce1d3f564fc122b6032d86

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-12-12 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414227

d...@kaosx.us changed:

   What|Removed |Added

 CC||d...@kaosx.us

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-11-24 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=414227

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #3 from Elvis Angelaccio  ---
*** Bug 414453 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-11-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

 CC||a.stipp...@gmx.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-11-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

 CC||chesterhime...@yahoo.com

--- Comment #2 from Nate Graham  ---
*** Bug 414372 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 414227] Dolphin crashes in KFileMetaData::UserMetaData::queryAttributes() when retrieving metadata from dangling symlink

2019-11-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=414227

Nate Graham  changed:

   What|Removed |Added

Version|unspecified |5.64.0
Product|dolphin |frameworks-kfilemetadata
Summary|Dolphin crashes when|Dolphin crashes in
   |retrieving metadata from|KFileMetaData::UserMetaData
   |dangling symlink|::queryAttributes() when
   ||retrieving metadata from
   ||dangling symlink
   Assignee|dolphin-bugs-n...@kde.org   |pinak.ah...@gmail.com
  Component|general |general

--- Comment #1 from Nate Graham  ---
Moving to KFileMetaData, since that's what's crashing.

-- 
You are receiving this mail because:
You are watching all bug changes.