[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-04-08 Thread Jonas Baecker
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #15 from Jonas Baecker  ---
(In reply to Albert Astals Cid from comment #14)
> We believe this has been as fixed as it can be.
> 
> Please upgrade to the newer versions (still unreleased) and tell us if you
> (ideally KDE Frameworks 6 >= 6.1 and KDE Gear >= 24.05) and tell us if you
> still have the problem.

I recently upgraded to Plasma 6 and can confirm that it is indeed fixed for me
now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-04-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=479612

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #14 from Albert Astals Cid  ---
We believe this has been as fixed as it can be.

Please upgrade to the newer versions (still unreleased) and tell us if you
(ideally KDE Frameworks 6 >= 6.1 and KDE Gear >= 24.05) and tell us if you
still have the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-03-30 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=479612

dreamsyn...@gmail.com changed:

   What|Removed |Added

 CC||dreamsyn...@gmail.com

--- Comment #13 from dreamsyn...@gmail.com ---
I can confirm all Avalonia UI Desktop generated application executables result
in this same issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-03-15 Thread Mirco Miranda
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #12 from Mirco Miranda  ---
(In reply to Mirco Miranda from comment #11)
> I checked the plugin and it doesn't support options. On QT 5 therefore
> mitigating RAM usage is not possible. As soon as I have a moment I'll add
> the function to the plugin.

Done. See also
https://invent.kde.org/frameworks/kimageformats/-/merge_requests/212

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-03-03 Thread Mirco Miranda
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #11 from Mirco Miranda  ---
(In reply to Mirco Miranda from comment #10)

> To avoid excessive RAM usage, last year I modified the thumnailer with
> memory checks to prevent the system from threshing. I don't know if it still
> works though.

I checked the plugin and it doesn't support options. On QT 5 therefore
mitigating RAM usage is not possible. As soon as I have a moment I'll add the
function to the plugin.
However, with the imminent release of KDE6 there should be no problems because
the Qt6 RAM limitation is correctly implemented in the plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-02-29 Thread Mirco Miranda
https://bugs.kde.org/show_bug.cgi?id=479612

Mirco Miranda  changed:

   What|Removed |Added

 CC||mirco...@gmail.com

--- Comment #10 from Mirco Miranda  ---
This patch should help:
https://invent.kde.org/frameworks/kimageformats/-/merge_requests/209

If I remember correctly, the thumbnail generator leaves the task of determining
the correct format to the plugins (regardless of the extension and mime type).
As a result, formats like TGA that do not have a unique signature can result in
false positives and the plugin tries to read them. It is not a good thing.

To avoid excessive RAM usage, last year I modified the thumnailer with memory
checks to prevent the system from threshing. I don't know if it still works
though.
Also, while writing the patch for the TGA I saw that it uses double the
necessary memory. This probably doesn't help either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-02-18 Thread Jonas Baecker
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #9 from Jonas Baecker  ---
(In reply to Nicolas Fella from comment #4)
> Analyzing in heaptrack suggests the file is loaded as a TGA file. Not sure
> that makes sense

Yeah, it's not really a TGA file. Actually, quite a few of these MIX archives
are detected as TGA files for me in Dolphin, though only one of them used a lot
of memory. This false detection happens with all the old Command & Conquer
games that use MIX files. The games are freeware and can be downloaded from
here for testing: https://cnc-comm.com/

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479612

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-01-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #8 from Nicolas Fella  ---
For the thumbnails specifically we might be able to check the dimensions using
QImageReader before trying to load the whole file and bail out if it's more
than N pixels

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-01-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #7 from Nicolas Fella  ---
I can't reproduce it on Qt6, presumably because we run into the allocation
limit in Qt (see
https://invent.kde.org/frameworks/kimageformats/-/blob/master/src/imageformats/util_p.h?ref_type=heads#L19)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-01-11 Thread Jonas Baecker
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #6 from Jonas Baecker  ---
(In reply to Albert Astals Cid from comment #5)
> I'm not sure there's an actual bug, the header of the file describes an
> image of 41039 * 63040 in size, and thus lots of memory is needed to load it
> to memory.
> 
> You'd have to send us the actual file to confirm if it's a TGA file or not
> and if not if we could bail earlier.

Here's the whole file https://files.catbox.moe/fwoeqz.gz
I'm using a third party filehost here as the file is too big to be attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-01-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=479612

--- Comment #5 from Albert Astals Cid  ---
I'm not sure there's an actual bug, the header of the file describes an image
of 41039 * 63040 in size, and thus lots of memory is needed to load it to
memory.

You'd have to send us the actual file to confirm if it's a TGA file or not and
if not if we could bail earlier.

As a side thing, the QImageReader API would probably welcome a function saying
"fail if we try to read a file bigger than AxB in size"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kimageformats] [Bug 479612] Massive memory leak when looking at a file

2024-01-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479612

Nicolas Fella  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |alex.me...@kde.org
Product|dolphin |frameworks-kimageformats
  Component|general |general
Version|23.08.4 |5.113.0
 CC||aa...@kde.org,
   ||kdelibs-b...@kde.org

--- Comment #4 from Nicolas Fella  ---
Analyzing in heaptrack suggests the file is loaded as a TGA file. Not sure that
makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.