[frameworks-kio] [Bug 103331] Group should be preserved when making backup

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=103331

--- Comment #23 from Nate Graham  ---
Anything more to do here, or is this fully fixed now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 103331] Group should be preserved when making backup

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=103331

--- Comment #22 from Ahmad Samir  ---
Git commit de7aff60e81b05239fd3d6c17895c48a985dd27a by Ahmad Samir.
Committed on 19/09/2021 at 10:06.
Pushed by ahmadsamir into branch 'master'.

Fix permissions when copying files

This reverts commit 7863f595991c5, I was wrong :)

Reading the code some more (in copyjob, file_copy and file_unix), the
permissions arg is '-1' when we shouldn't touch the dest permissions at all,
i.e. leave them as the system default permissions for newly created files
(umask ...etc).

The scenarios are:
- calling KIO::copy() A to B, permissions are preserved by default, i.e. the
  job copies A's permissions to the permissions arg when it calls file_copy
- calling KIO::copy() A to B, and calling setDefaultPermissions(true),
  the job sets the permissions arg to '-1' when it calls file_copy
- calling KIO::file_copy() directly, the you have full control, if you want
  to preserve the permissions use A's permissions as the permissions arg,
  otherwise use '-1' to use the system default permissions

ACL attributes are handled implicitly at the moment, which isn't ideal but
can be improved later on.
Related: bug 404777

FIXED-IN: 5.87

M  +4-6src/core/filecopyjob.h
M  +15   -22   src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/de7aff60e81b05239fd3d6c17895c48a985dd27a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 103331] Group should be preserved when making backup

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=103331

--- Comment #21 from David Faure  ---
Git commit ff4bb61b2f5492f1942c1f11fe4c8b9a7eb654ea by David Faure, on behalf
of Ahmad Samir.
Committed on 22/08/2021 at 08:28.
Pushed by dfaure into branch 'master'.

file_unix: minor cleanup

Separate ::chmod() from acl_set_file() call, more readable that way.

If the permissions are -1, that means preserve the permissions/attributes
of the source file, this matches what the code is/was doing and the docs.
Maybe we should add a couple more setters for the job, e.g. setPermissions(),
setAcl(), then users can fine-tune the permissions of the dest, preserve,
don't set, leave as default

M  +9-5src/ioslaves/file/file_unix.cpp

https://invent.kde.org/frameworks/kio/commit/ff4bb61b2f5492f1942c1f11fe4c8b9a7eb654ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 103331] Group should be preserved when making backup

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=103331

Nate Graham  changed:

   What|Removed |Added

 CC||kdelibs-b...@kde.org,
   ||pointedst...@zoho.com
  Component|general |general
Product|kio |frameworks-kio

-- 
You are receiving this mail because:
You are watching all bug changes.