[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=343452

Nate Graham  changed:

   What|Removed |Added

 CC||kde-2011...@dotancohen.com

--- Comment #19 from Nate Graham  ---
*** Bug 236059 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=343452

Elvis Angelaccio  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.34
  Latest Commit||https://commits.kde.org/kio
   ||/f29bbfb1c17dbfa92b27fa6d5a
   ||1c86b06a71a6b8
 Status|CONFIRMED   |RESOLVED

--- Comment #18 from Elvis Angelaccio  ---
Git commit f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8 by Elvis Angelaccio, on
behalf of Mathis Beer.
Committed on 28/04/2017 at 15:21.
Pushed by elvisangelaccio into branch 'master'.

KDirSortFilterProxyModel: bring back natural sorting

This fixes a regression of the KF5 port.
FIXED-IN: 5.34
REVIEW: 128574

M  +1-0src/filewidgets/kdirsortfilterproxymodel.cpp

https://commits.kde.org/kio/f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=343452

--- Comment #17 from Nate Graham  ---
Er,  FeepingCreature's patch.

I know it's not perfect, but it does resolve the issue, and we can integrate
the perfect fix afterwards, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=343452

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #16 from Nate Graham  ---
Konstantinos Smanis's patch got downstreamed into openSUSE's Plasma repo, and I
can confirm that it works and resolves the issue. Can we get it moved alone
here so Plasma users in other distros can benefit as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=343452

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Konstantinos Smanis]

https://bugs.kde.org/show_bug.cgi?id=343452

--- Comment #15 from Konstantinos Smanis  ---
This bug managed to annoy the hell out of that itching part of my brain, so I
did a little digging. I posted my review on
https://git.reviewboard.kde.org/r/128574/

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Konstantinos Smanis]

https://bugs.kde.org/show_bug.cgi?id=343452

Konstantinos Smanis  changed:

   What|Removed |Added

 CC||konstantinos.smanis@gmail.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Konstantinos Smanis]

https://bugs.kde.org/show_bug.cgi?id=343452

Konstantinos Smanis  changed:

   What|Removed |Added

 CC||public+...@enkore.de

--- Comment #14 from Konstantinos Smanis  ---
*** Bug 349390 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Leszek Lesner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343452

--- Comment #13 from Leszek Lesner  ---
Was already uploaded there. See https://git.reviewboard.kde.org/r/128574/

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Burkhard Lueck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343452

Burkhard Lueck  changed:

   What|Removed |Added

 CC||lu...@hube-lueck.de

--- Comment #12 from Burkhard Lueck  ---
(In reply to FeepingCreature from comment #11)
> Created attachment 100413 [details]
> Enable natural sorting on the QCollator for KDirSortFilterProxyModel
> 
> Turns out this is actually a bug in KIO. QCollator does not enable "numeric
> mode", which KDirSortFilterProxyModel advertises as enabled, by default, and
> KIO's KDirSortFilterProxyModel does not enable it at all. As a result, as
> far as I can tell, natural sort never worked in KF5/Qt5.
> 
> Patch for KIO is attached.

Please upload your patch to https://git.reviewboard.kde.org (repository kio)
and add group kdeframewotks as reviewers

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[Florian Jacob via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343452

Florian Jacob  changed:

   What|Removed |Added

 CC||accounts+bugs.kde@florianja
   ||cob.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 343452] Does not sort numbers naturally any longer

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343452

David Edmundson  changed:

   What|Removed |Added

Product|gwenview|frameworks-kio
 CC||k...@davidedmundson.co.uk,
   ||kdelibs-b...@kde.org
  Component|general |general
   Assignee|gwenview-bugs-n...@kde.org  |fa...@kde.org
Version|Other (add details in bug   |5.24.0
   |description)|

-- 
You are receiving this mail because:
You are watching all bug changes.