[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=385189

Méven Car  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kio
   ||/bea5b68142e4f018a956fd2174
   ||152d9a3e0679cf
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.57
 Resolution|--- |FIXED

--- Comment #10 from Méven Car  ---
Git commit bea5b68142e4f018a956fd2174152d9a3e0679cf by Méven Car.
Committed on 28/03/2019 at 21:34.
Pushed by meven into branch 'master'.

KFileWidget In saving single file mode an enter/return press on the
KDirOperator triggers slotOk

Summary:
Draw inspiration from inspiration from https://phabricator.kde.org/D12538 for
reference.

The issue at hand:
 * the KDirOperator did not signal when it received an enter/return event when
it should.
 * This prevents expected behavior
FIXED-IN: 5.57

Test Plan:
1 compile kio and its test kfilewidgettest_saving_gui.cpp
2 launch kfilewidgettest_saving_gui
4 click on an place on the left
5 Hit enter
6 The dialog closes, the filename selected is printed out in the terminal

Reviewers: #frameworks, #dolphin, ngraham, dfaure

Reviewed By: #dolphin, ngraham, dfaure

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19824

M  +2-0src/filewidgets/kdiroperator.cpp
M  +6-0src/filewidgets/kdiroperator.h
M  +12   -0src/filewidgets/kfilewidget.cpp
M  +1-0src/filewidgets/kfilewidget.h
M  +1-0tests/CMakeLists.txt
A  +58   -0tests/kfilewidgettest_saving_gui.cpp [License: LGPL (v2+)]

https://commits.kde.org/kio/bea5b68142e4f018a956fd2174152d9a3e0679cf

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #9 from Méven Car  ---
I have a patch proposal :
https://phabricator.kde.org/D19824

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #8 from Nate Graham  ---
Ah you're right!

Seems like good patch material. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #7 from Méven Car  ---
I believe this is always reproducible in fact, it is just that the steps to
reproduce must be followed precisely.

STEPS TO REPRODUCE
1. Save a file in any KDE program in a way that triggers the Save dialog
2. Modify the filename to your liking
3. Navigate to the location that you want to save the file to, either using the
places panel or the main navigation view
4. Hit the return or enter key

I believe the bug is due to the KDirOperator widget not notifying the
kfilewidget when the user press enter/return.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #6 from Nate Graham  ---
I'm the opposite! I can reproduce with Kate but it works fine for me in
Spectacle! :p

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #5 from Méven Car  ---
I used kate to reproduce it and using it didn't reproduce but saving a
screenshot with spectacle is affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Patrick Silva]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #4 from Patrick Silva  ---
Bug is still reproducible here.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.2
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=385189

Méven Car  changed:

   What|Removed |Added

 CC||meve...@gmail.com

--- Comment #3 from Méven Car  ---
I tried to reproduce this bug, it seems to me it is fixed.
Can someone confirm ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385189

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
  Component|general |Open/save dialogs
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=385189

--- Comment #2 from Christoph Feck  ---
The difference was probably intended to make it harder to accidentally
overwrite a file, see also bug 267749.

I think in the meantime the overwrite dialog is enabled by default (I remember
seeing it popping up twice because the application assumed there was no
dialog). With this safety net, input handling could be unified between Open and
Save dialog modes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 385189] Save dialog: Return key only bound to Save button when text field has focus

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=385189

Nate Graham  changed:

   What|Removed |Added

 CC||kdelibs-b...@kde.org
   Assignee|kdelibs-b...@kde.org|fa...@kde.org
  Component|general |general
Product|kfile   |frameworks-kio
Version|unspecified |5.43.0

-- 
You are receiving this mail because:
You are watching all bug changes.