[frameworks-kio] [Bug 415567] "Could not find the program" dialog when program is found but malformed
https://bugs.kde.org/show_bug.cgi?id=415567 samoht0 changed: What|Removed |Added CC||samoht0-bugzi...@yahoo.com --- Comment #3 from samoht0 --- (In reply to David Faure from comment #2) > Differential Revision: https://phabricator.kde.org/D29170 > > M +16 -5autotests/applicationlauncherjobtest.cpp > M +11 -8src/core/desktopexecparser.cpp > M +42 -2src/gui/kprocessrunner.cpp > > https://commits.kde.org/kio/05cbbf06384bae0cad8de19d659864c0f8dbd651 The commit seems to cause a regression for me: https://bugs.kde.org/show_bug.cgi?id=422270 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 415567] "Could not find the program" dialog when program is found but malformed
https://bugs.kde.org/show_bug.cgi?id=415567 --- Comment #2 from David Faure --- Git commit 05cbbf06384bae0cad8de19d659864c0f8dbd651 by David Faure. Committed on 27/04/2020 at 21:22. Pushed by dfaure into branch 'master'. Detect executables without +x permission in $PATH to improve error message Summary: QStandardPaths::findExecutable will not return to us a non-executable binary. So implement our own iteration over $PATH to detect such a case. Note: this doesn't handle the case where PATH isn't set at all (QStandardPaths implements a fallback) nor do we implement this for Windows (where chmod -x doesn't really exist as is). I think this is fine, in the worst case the user will get the other error message, program not found. Test Plan: 'sudo chmod a-x /usr/bin/gwenview' then try opening a picture with gwenview from e.g. dolphin, see the error message Reviewers: ahmadsamir Reviewed By: ahmadsamir Subscribers: ngraham, meven, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D29170 M +16 -5autotests/applicationlauncherjobtest.cpp M +11 -8src/core/desktopexecparser.cpp M +42 -2src/gui/kprocessrunner.cpp https://commits.kde.org/kio/05cbbf06384bae0cad8de19d659864c0f8dbd651 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 415567] "Could not find the program" dialog when program is found but malformed
https://bugs.kde.org/show_bug.cgi?id=415567 Ahmad Samir changed: What|Removed |Added Ever confirmed|0 |1 CC||a.samir...@gmail.com Status|REPORTED|CONFIRMED --- Comment #1 from Ahmad Samir --- https://phabricator.kde.org/D27216 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 415567] "Could not find the program" dialog when program is found but malformed
https://bugs.kde.org/show_bug.cgi?id=415567 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
