[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files
https://bugs.kde.org/show_bug.cgi?id=422189 Méven Car changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/kio/commit/73cc5a82d ||e887b197ddfd35e0dce3d1a34d5 ||eb47 Version Fixed In||5.72 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #4 from Méven Car --- Git commit 73cc5a82de887b197ddfd35e0dce3d1a34d5eb47 by Méven Car, on behalf of Ahmad Samir. Committed on 16/06/2020 at 08:59. Pushed by meven into branch 'master'. [Trash] Remove trashinfo files referencing files/dirs that don't exist If the user moves a file to trash, the deletes that file without using kio_trash (e.g. with rm), then the relevant trashinfo file should be deleted the next time we try to list/stat that trashed file; otherwise kio_trash keep trying to stat that file every time the Trash dir is stat'ed/listed. The testtrash unit test still passes. Thanks to meven for pointing out how to fix this bug. FIXED-IN: 5.72 M +2-1src/ioslaves/trash/kio_trash.cpp M +24 -0src/ioslaves/trash/tests/testtrash.cpp M +1-0src/ioslaves/trash/tests/testtrash.h https://invent.kde.org/frameworks/kio/commit/73cc5a82de887b197ddfd35e0dce3d1a34d5eb47 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files
https://bugs.kde.org/show_bug.cgi?id=422189 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files
https://bugs.kde.org/show_bug.cgi?id=422189 --- Comment #3 from Ahmad Samir --- (In reply to Méven Car from comment #2) [..] > > Still we tru to dectect orhpaned files such as here where we have the > metadata but not the files. Your bug shows it does not clean its record, > once it has noticed the files are orphaned, since this repeats or at least > not correctly. Good point, non-existing files should indeed be removed from the Trash records/info. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files
https://bugs.kde.org/show_bug.cgi?id=422189 Méven Car changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||meven@enioka.com --- Comment #2 from Méven Car --- (In reply to Ahmad Samir from comment #1) > The records are kept because IIUC users are supposed to be able to restore > deleted files from the Trash. Exact > > Examine ~/.local/share/Trash/info/* and ~/.local/share/Trash/directorysizes > > I don't think this is a bug, you basically deleted the files in the Trash, > without telling kio_trash about it... :) Still we tru to dectect orhpaned files such as here where we have the metadata but not the files. Your bug shows it does not clean its record, once it has noticed the files are orphaned, since this repeats or at least not correctly. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files
https://bugs.kde.org/show_bug.cgi?id=422189 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com, ||meve...@gmail.com --- Comment #1 from Ahmad Samir --- The records are kept because IIUC users are supposed to be able to restore deleted files from the Trash. Examine ~/.local/share/Trash/info/* and ~/.local/share/Trash/directorysizes I don't think this is a bug, you basically deleted the files in the Trash, without telling kio_trash about it... :) -- You are receiving this mail because: You are watching all bug changes.
