[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-08-19 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=448859

Fabian Vogt  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |NOT A BUG

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-08-18 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=448859

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #11 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-08-03 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #10 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-07-20 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #9 from Nicolas Fella  ---
yes, env FOO=bar works

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-07-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448859

Ahmad Samir  changed:

   What|Removed |Added

 Status|REOPENED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Ahmad Samir  ---
Ping.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-04-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #7 from Ahmad Samir  ---
FTR, the commit was reverted.

The solution David posted works?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-03-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #6 from David Faure  ---
Yes this ends up in /bin/sh. I thought any shell command was valid for an Exec
line.
Thanks for the pointer to the spec, that's instructive. Sometimes we
voluntarily support more things than the spec, but it's probably not a great
idea (creates compat problems when people test something in KDE and assume
it'll work everywhere)

I just found desktop files that say

Exec=env WINEPREFIX="/home/dfaure/.wine" wine start /ProgIDOpen giffile %f

Isn't this a solution to this problem? I.e. change step 1 to prepend "env"
before the env var?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-27 Thread postix
https://bugs.kde.org/show_bug.cgi?id=448859

postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-25 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #5 from Fabian Vogt  ---
(In reply to Nicolas Fella from comment #4)
> The thing is, launching the app works perfectly fine and sets the env
> variable, it's just that executableName behaves differently

I'd say that's a bug - KIO should not accept it at all as it's invalid. That
can cause weird issues and hide compatibility problems.

I wonder how it works at all, it probably ends up in a /bin/sh context at some
point.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=448859

--- Comment #4 from Nicolas Fella  ---
The thing is, launching the app works perfectly fine and sets the env variable,
it's just that executableName behaves differently

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-25 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=448859

Fabian Vogt  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
   Assignee|kio-bugs-n...@kde.org   |a.samir...@gmail.com

--- Comment #3 from Fabian Vogt  ---
I don't think specifying environment variables like this is valid. The Exec=
line must start with the application and must not contain '=':

https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html

A command line consists of an executable program optionally followed by one or
more arguments. The executable program can either be specified with its full
path or with the name of the executable only. If no full path is provided the
executable is looked up in the $PATH environment variable used by the desktop
environment. The name or path of the executable program may not contain the
equal sign ("="). Arguments are separated by a space.

So the previous KIO behaviour was probably correct and the change should be
reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-23 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448859

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/4c4f4b919
   ||a81706913596e7ba518165dd80c
   ||9eb7
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.92

--- Comment #2 from Ahmad Samir  ---
Git commit 4c4f4b919a81706913596e7ba518165dd80c9eb7 by Ahmad Samir.
Committed on 23/02/2022 at 11:44.
Pushed by ahmadsamir into branch 'master'.

DesktopExecParser: parse environment variables too

And add a method that returns a QProcessEnvironment object containing those
environment variables (thanks to Meven for the idea of returning a QPE).

Add unittest.
FIXED_IN: 5.92

M  +33   -0autotests/krununittest.cpp
M  +2-0autotests/krununittest.h
M  +36   -1src/core/desktopexecparser.cpp
M  +28   -3src/core/desktopexecparser.h

https://invent.kde.org/frameworks/kio/commit/4c4f4b919a81706913596e7ba518165dd80c9eb7

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448859

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-02-09 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=448859

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #1 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kio/-/merge_requests/751

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 448859] KEmailClientLaucherJob can't lauch Thunderbird with env variable in Exec

2022-01-20 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=448859

Nicolas Fella  changed:

   What|Removed |Added

 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.