[frameworks-kirigami] [Bug 473241] Scrollbar handle size is incorrect until the view is scrolled at all

2023-08-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=473241

Nate Graham  changed:

   What|Removed |Added

Version|unspecified |Master
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
   Assignee|unassigned-b...@kde.org |kdelibs-b...@kde.org
 CC||m...@ratijas.tk,
   ||n...@kde.org,
   ||notm...@gmail.com
   Target Milestone|--- |Not decided
Product|kde |frameworks-kirigami
  Component|general |general
Summary|Scrollbar size changes  |Scrollbar handle size is
   |after scrolling |incorrect until the view is
   ||scrolled at all

--- Comment #1 from Nate Graham  ---
Can confirm. Seems like a bug in Kirigami.ScrollablePage.

Trivially reproducible example code:

import QtQuick 2.5
import QtQuick.Layouts 1.1
import org.kde.kirigami 2.13 as Kirigami

Kirigami.ScrollablePage {
width: 500
height: 500

ColumnLayout {
Repeater {
model: 100

Rectangle {
width: 50
height: 50
color: "green"
}
}
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 473241] Scrollbar handle size is incorrect until the view is scrolled at all

2023-08-11 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=473241

--- Comment #2 from ratijas  ---
I believe it's a bug in qqc2-desktop-style or QtQuick.Controls, as similar
thing occurs in other places as well. I noticed it as early as during ScrollBar
rework (that "mega-fix" MR) in January.

Basically, some ScrollBar's metrics properties are stalled. They don't notify
of their changes, but if you emit them by calling associated signals manually,
everything snaps into place. Might be a Qt 6 regression as well.

Just look at this comment:

> // Note about comma, operator: including visualPosition in this
> // expression help it propagate signals when needed; otherwise in
> // Qt 6 scrollbar might get stuck being too large, and clip out.
> minimum: 0
> maximum: (void controlRoot.visualPosition),
> Math.round(length / Math.max(0.001, controlRoot.visualSize) - length)
> value: Math.round(length / Math.max(0.001, controlRoot.visualSize) * 
> Math.min(1 - 0.001, controlRoot.visualPosition))

https://invent.kde.org/frameworks/qqc2-desktop-style/-/blob/f3dd8b22c83f896abfbfd0c03443c4f12e93e08c/org.kde.desktop/ScrollBar.qml#L219-225

Whichever component is at fault here, I bet it's not Kirigami. Unless…
ListView/Flickable really fails to recalculate its content height with all
those bindings and re-assignments during initialization… in which case it would
still be QtQuick's fault.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 473241] Scrollbar handle size is incorrect until the view is scrolled at all

2023-09-02 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=473241

ratijas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/qqc2-desktop-style/-
   ||/commit/a004faa08d905615fed
   ||5712c650de33378e53ebe
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from ratijas  ---
Git commit a004faa08d905615fed5712c650de33378e53ebe by ivan tkachenko.
Committed on 02/09/2023 at 15:38.
Pushed by ratijas into branch 'master'.

ScrollBar: Fix size being initially stuck on Qt 6

Due to a bug in Qt, explicit binding to ScrollBar::size is required to
help it notify the binding to reevaluate. According to my and Noah's
investigation, size can indeed change in a way that affects getter of
visualSize, but only signal sizeChanged will be dispatched, thus leaving
visualSize hanging in a limbo state when querying it manually would
result in a new value but change listeners would never know that.
See also: https://codereview.qt-project.org/c/qt/qtdeclarative/+/501319

M  +3-2org.kde.desktop/ScrollBar.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/a004faa08d905615fed5712c650de33378e53ebe

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 473241] Scrollbar handle size is incorrect until the view is scrolled at all

2023-09-02 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=473241

--- Comment #4 from ratijas  ---
Upstream patch: https://codereview.qt-project.org/c/qt/qtdeclarative/+/501319

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kirigami] [Bug 473241] Scrollbar handle size is incorrect until the view is scrolled at all

2023-11-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=473241

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=476483

-- 
You are receiving this mail because:
You are watching all bug changes.