[frameworks-knewstuff] [Bug 422048] When Breeze Dark global theme is used, white squares appear immediately before the preview of the addons to be loaded

2020-06-12 Thread Dan Leinir Turthra Jensen
https://bugs.kde.org/show_bug.cgi?id=422048

Dan Leinir Turthra Jensen  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/knewstuff/commit/087
   ||cf5c476c09bbf3a5f2b7bd57171
   ||a3386001ca
 Resolution|--- |FIXED

--- Comment #4 from Dan Leinir Turthra Jensen  ---
Git commit 087cf5c476c09bbf3a5f2b7bd57171a3386001ca by Dan Leinir Turthra
Jensen.
Committed on 12/06/2020 at 09:31.
Pushed by leinir into branch 'master'.

Hide the ShadowRectangle for non-loaded previews

This ommission is exposed when these views are used with a dark colour
scheme, as shown in the bug report https://bugs.kde.org/show_bug.cgi?id=422048

M  +1-0src/qtquick/qml/private/EntryScreenshots.qml
M  +1-0   
src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +1-0src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://invent.kde.org/frameworks/knewstuff/commit/087cf5c476c09bbf3a5f2b7bd57171a3386001ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 422048] When Breeze Dark global theme is used, white squares appear immediately before the preview of the addons to be loaded

2020-06-12 Thread Dan Leinir Turthra Jensen
https://bugs.kde.org/show_bug.cgi?id=422048

--- Comment #3 from Dan Leinir Turthra Jensen  ---
Yup, that was it - suggested fix at
https://invent.kde.org/frameworks/knewstuff/-/merge_requests/3 :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 422048] When Breeze Dark global theme is used, white squares appear immediately before the preview of the addons to be loaded

2020-06-12 Thread Dan Leinir Turthra Jensen
https://bugs.kde.org/show_bug.cgi?id=422048

--- Comment #2 from Dan Leinir Turthra Jensen  ---
(In reply to Nate Graham from comment #1)
> This is probably the default/placeholder image loading before
> the real image is displayed.

  Turns out to be the shadowed rectangle sat behind the thumbnail - should be
easy enough to sort out, just needs hiding when the image isn't loaded yet :)
(which really it wants to be anyway)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 422048] When Breeze Dark global theme is used, white squares appear immediately before the preview of the addons to be loaded

2020-06-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=422048

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||n...@kde.org
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Nate Graham  ---
Can reproduce. This is probably the default/placeholder image loading before
the real image is displayed. it's not visible with the default color scheme
since it's the same color as the background, but you'll see it when using a
colorscheme in which the view background isn't white. We should suppress this
image.

-- 
You are receiving this mail because:
You are watching all bug changes.