[frameworks-ktexteditor] [Bug 329247] Indenting a selection that starts or ends in leading whitespace changes the selection

2023-10-31 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=329247

Christoph Cullmann  changed:

   What|Removed |Added

   Version Fixed In||5.112
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/ktexteditor/-/commit
   ||/02d2aa2984a54fb63b586448b8
   ||d859a514ad285b

--- Comment #12 from Christoph Cullmann  ---
Git commit 02d2aa2984a54fb63b586448b8d859a514ad285b by Christoph Cullmann, on
behalf of RĂ©mi Peuchot.
Committed on 31/10/2023 at 16:30.
Pushed by cullmann into branch 'kf5'.

Fix selection shrink when indenting

'editRemoveText' indirectly triggers 'TextRange::checkValidity'
which silently shrink the selection if the removed text is at the start
or end of the given range.

'editInsertText' will insert text without expanding the selection.

The fix consists of doing insertion before deletion so that the
selection is not shrinked.

(more details in the Merge Request)
FIXED-IN:5.112


(cherry picked from commit 00f218cdf0adce8b0e0b96fd0107803946848e07)

M  +5-2src/utils/kateautoindent.cpp

https://invent.kde.org/frameworks/ktexteditor/-/commit/02d2aa2984a54fb63b586448b8d859a514ad285b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 329247] Indenting a selection that starts or ends in leading whitespace changes the selection

2023-10-27 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=329247

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/623

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 329247] Indenting a selection that starts or ends in leading whitespace changes the selection

2023-10-26 Thread remi
https://bugs.kde.org/show_bug.cgi?id=329247

remi  changed:

   What|Removed |Added

 CC||remiforkdebugreport@gmail.c
   ||om

--- Comment #10 from remi  ---
I have been able to reproduce this bug in a unit test.

If I can, I'll propose a fix that only involves the indent/unindent part of the
code.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 329247] Indenting a selection that starts or ends in leading whitespace changes the selection

2016-09-08 Thread Christoph Cullmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=329247

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #9 from Christoph Cullmann  ---
Hi, sorry we didn't take a look earlier, thought I am not sure if that change
would not cause other regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-ktexteditor] [Bug 329247] Indenting a selection that starts or ends in leading whitespace changes the selection

2016-05-26 Thread Ivan Yosifov via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=329247

--- Comment #8 from Ivan Yosifov  ---
HELLO !?

-- 
You are receiving this mail because:
You are watching all bug changes.