[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-24 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=435855

--- Comment #10 from Waqar Ahmed  ---
We made the change after rethinking the use cases, thanks for bringing it up.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=435855

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|INTENTIONAL |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/ktexteditor/commit/1
   ||16dc5c4e43f2e2be08ad0bf3c10
   ||e8df2d0906bd

--- Comment #9 from Christoph Cullmann  ---
Git commit 116dc5c4e43f2e2be08ad0bf3c10e8df2d0906bd by Christoph Cullmann, on
behalf of Waqar Ahmed.
Committed on 24/01/2022 at 19:07.
Pushed by cullmann into branch 'master'.

Don't scroll on select all

Tried Qtcreator, browsers etc. No one jumps to end.

We use setSelection here to ensure we don't scroll anywhere
The cursor stays in place i.e., it doesn't move to end of selection
that is okay and expected.

The idea here is to maintain scroll position in case select all was
mistakenly triggered, and also to if you just want to copy text,
there is no need to scroll anywhere.

M  +8-2src/view/kateview.cpp

https://invent.kde.org/frameworks/ktexteditor/commit/116dc5c4e43f2e2be08ad0bf3c10e8df2d0906bd

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-14 Thread witchhunter
https://bugs.kde.org/show_bug.cgi?id=435855

--- Comment #8 from witchhunter  ---
(In reply to Waqar Ahmed from comment #7)
Hey, thanks for all your effort. Since I'm not a developer, that's way over my
head. Never thought this so controversial though, and hope @Dominic finds that
discussion, really curious to hear the arguments. Anyway, scripting is far as I
go and KDE grows in other directions, too =). Thanks again

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-14 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=435855

--- Comment #7 from Waqar Ahmed  ---
Hi, not really a "works for me" I think since that'd apply if this was a bug.
Anyhow, the reason I linked the MR is that if you have really believe that this
is an improvement and have a solid argument, you can add a comment there. This
is how KDE grows (and I guess that's why we have so many options ;)). For me,
it didn't matter either ways but maybe others really have a usecase for this
that we didn't see.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-14 Thread witchhunter
https://bugs.kde.org/show_bug.cgi?id=435855

--- Comment #6 from witchhunter  ---
OK then.  Sorry I wasted everyone's time. I guess this is "works for me"
situation, since the provided workaround is easy to implement.

But, just for the record, IMHO:
- I have never encounter text/code/word editor that scroll view to the end on
"select all", and I see no benefit of such behavior (TBH never used new
QtCreator 6, but I'm confident that's a regression from 5 on their behalf)
- The considerations of insertion point placement are irrelevant here, since
there is no purpose to type or paste on "selected all"
- The workaround have added functionality. You can easily use (as a cross-app
consensus) left/right arrows to cancel selection and move to begin/end. Also
up/down arrows to move in the current view (no mouse involved).

As a silver lining, users can now found solution if annoyed/involved enough,
and maybe learn the power of Katepart scripting at the same time. Cheers!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-13 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=435855

Waqar Ahmed  changed:

   What|Removed |Added

 CC||waqar@gmail.com
 Resolution|--- |INTENTIONAL
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Waqar Ahmed  ---
It was decided that the current behaviour is intentional. See the linked MR for
details.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=435855

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/248

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2022-01-02 Thread witchhunter
https://bugs.kde.org/show_bug.cgi?id=435855

--- Comment #3 from witchhunter  ---
Created attachment 145058
  --> https://bugs.kde.org/attachment.cgi?id=145058=edit
myutils.js

As a workaround you can place the attached script as 
~/.local/share/katepart5/script/commands/myutils.js
and then create/reassign shortcut for "select all text" in GUI.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2021-05-04 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435855

Ahmad Samir  changed:

   What|Removed |Added

  Component|general |general
   Assignee|mon...@kde.org  |kwrite-bugs-n...@kde.org
Product|frameworks-ktextwidgets |frameworks-ktexteditor
Version|5.81.0  |unspecified
 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.